unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#59093] [PATCH] Add motif and xnedit
       [not found] <CAJsg1E9pb+vfoFdzxXNnDukX8tgwBBKJwmQwYXfUVqdTWnJMbA@mail.gmail.com>
@ 2023-01-30 12:44 ` Simon Tournier
  2023-01-30 15:35   ` Andy Tai
  0 siblings, 1 reply; 6+ messages in thread
From: Simon Tournier @ 2023-01-30 12:44 UTC (permalink / raw)
  To: Andy Tai; +Cc: 59093, control

Hi,

On sam., 28 janv. 2023 at 20:16, Andy Tai <lichengtai@gmail.com> wrote:

> close 59093

Why do you close it?  And then you open #61134 [1] with the same patch.

1: <http://issues.guix.gnu.org/issue/61134>


Cheers,
simon




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#59093] [PATCH] Add motif and xnedit
  2023-01-30 12:44 ` [bug#59093] [PATCH] Add motif and xnedit Simon Tournier
@ 2023-01-30 15:35   ` Andy Tai
  2023-01-31  9:56     ` Simon Tournier
  0 siblings, 1 reply; 6+ messages in thread
From: Andy Tai @ 2023-01-30 15:35 UTC (permalink / raw)
  To: Simon Tournier; +Cc: 59093, 61134

I did it so Guix QA can pick it up to queue it for testing.

Guix QA seemed confused about the old bug, always in a failed state

On Mon, Jan 30, 2023 at 4:47 AM Simon Tournier <zimon.toutoune@gmail.com> wrote:
>
> Hi,
>
> On sam., 28 janv. 2023 at 20:16, Andy Tai <lichengtai@gmail.com> wrote:
>
> > close 59093
>
> Why do you close it?  And then you open #61134 [1] with the same patch.
>
> 1: <http://issues.guix.gnu.org/issue/61134>
>
>
> Cheers,
> simon




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#59093] [PATCH] Add motif and xnedit
  2023-01-30 15:35   ` Andy Tai
@ 2023-01-31  9:56     ` Simon Tournier
  2023-01-31 17:15       ` [bug#61134] " Andy Tai
  0 siblings, 1 reply; 6+ messages in thread
From: Simon Tournier @ 2023-01-31  9:56 UTC (permalink / raw)
  To: Andy Tai; +Cc: 59093, 61134

Hi,

On Mon, 30 Jan 2023 at 07:35, Andy Tai <lichengtai@gmail.com> wrote:

> Guix QA seemed confused about the old bug, always in a failed state

It appears to me better to point the issues and then maybe fix them
instead of bypassing them.  My 2 cents.

Cheers,
simon




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#61134] [bug#59093] [PATCH] Add motif and xnedit
  2023-01-31  9:56     ` Simon Tournier
@ 2023-01-31 17:15       ` Andy Tai
  2023-01-31 18:12         ` Andy Tai
  0 siblings, 1 reply; 6+ messages in thread
From: Andy Tai @ 2023-01-31 17:15 UTC (permalink / raw)
  To: Simon Tournier; +Cc: 59093, 61134

you meant fixing the issue in Guix QA?

It goes without saying that Guix QA is far from the code in question
of this issue and my question on Guix QA also went unanswered on the
mailing list.



On Tue, Jan 31, 2023 at 3:36 AM Simon Tournier <zimon.toutoune@gmail.com> wrote:
>
> Hi,
>
> On Mon, 30 Jan 2023 at 07:35, Andy Tai <lichengtai@gmail.com> wrote:
>
> > Guix QA seemed confused about the old bug, always in a failed state
>
> It appears to me better to point the issues and then maybe fix them
> instead of bypassing them.  My 2 cents.
>
> Cheers,
> simon




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#61134] [bug#59093] [PATCH] Add motif and xnedit
  2023-01-31 17:15       ` [bug#61134] " Andy Tai
@ 2023-01-31 18:12         ` Andy Tai
  2023-02-01 10:08           ` Simon Tournier
  0 siblings, 1 reply; 6+ messages in thread
From: Andy Tai @ 2023-01-31 18:12 UTC (permalink / raw)
  To: Simon Tournier; +Cc: 59093, 61134

To clarify, when I mentioned Guix QA shows failure, Guiox QA was
showing "failure" trying to queue the issue to build, not that Gux QA
was showing some build log with the patch failing to build in some
way.

So I don't know if you are saying people should look at Guix QA
sources and help to fix that.  That is possible, of course, but people
contributing to Guix patches may have no background at all at how Guix
QA works.

On Tue, Jan 31, 2023 at 9:15 AM Andy Tai <atai@atai.org> wrote:
>
> you meant fixing the issue in Guix QA?
>
> It goes without saying that Guix QA is far from the code in question
> of this issue and my question on Guix QA also went unanswered on the
> mailing list.
>
>
>
> On Tue, Jan 31, 2023 at 3:36 AM Simon Tournier <zimon.toutoune@gmail.com> wrote:
> >
> > Hi,
> >
> > On Mon, 30 Jan 2023 at 07:35, Andy Tai <lichengtai@gmail.com> wrote:
> >
> > > Guix QA seemed confused about the old bug, always in a failed state
> >
> > It appears to me better to point the issues and then maybe fix them
> > instead of bypassing them.  My 2 cents.
> >
> > Cheers,
> > simon



-- 
Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2023 民國112年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#61134] [bug#59093] [PATCH] Add motif and xnedit
  2023-01-31 18:12         ` Andy Tai
@ 2023-02-01 10:08           ` Simon Tournier
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Tournier @ 2023-02-01 10:08 UTC (permalink / raw)
  To: Andy Tai; +Cc: 59093, 61134

Hi Andy,

On Tue, 31 Jan 2023 at 10:12, Andy Tai <atai@atai.org> wrote:
> To clarify, when I mentioned Guix QA shows failure, Guiox QA was
> showing "failure" trying to queue the issue to build, not that Gux QA
> was showing some build log with the patch failing to build in some
> way.
>
> So I don't know if you are saying people should look at Guix QA
> sources and help to fix that.  That is possible, of course, but people
> contributing to Guix patches may have no background at all at how Guix
> QA works.

I have understood the first time. :-)

I wrote: «It appears to me better to point the issues and then maybe fix
them instead of bypassing them.  My 2 cents.»

I am not saying that you should fix issues with QA, obviously not.
Instead, I am proposing that if you notice something unexpected with QA,
you should report it and not silently bypass it.

“Report it” means for example drop an email to guix-devel or open a bug
or roam on #guix and tell.  I do not know what is the best and it does
not mean that the issue about QA will be fixed.  It just helps in
improving the tools, IMHO.

Well, for what it is worth, I am trying to say that silently close and
reopen another ticket because QA does not behave as expected is a
short-term hack – and yes it is often necessary to have the task done
now :-) – but by silently closing it does not help for the longer term.

Thanks for your contributions and taking the time to discuss how we
could collectively improve Guix. :-)

Cheers,
simon




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-02-01 10:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CAJsg1E9pb+vfoFdzxXNnDukX8tgwBBKJwmQwYXfUVqdTWnJMbA@mail.gmail.com>
2023-01-30 12:44 ` [bug#59093] [PATCH] Add motif and xnedit Simon Tournier
2023-01-30 15:35   ` Andy Tai
2023-01-31  9:56     ` Simon Tournier
2023-01-31 17:15       ` [bug#61134] " Andy Tai
2023-01-31 18:12         ` Andy Tai
2023-02-01 10:08           ` Simon Tournier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).