From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UJ9vLT13YWARVAEAgWs5BA (envelope-from ) for ; Mon, 29 Mar 2021 08:44:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oH1RJz13YWAiagAA1q6Kng (envelope-from ) for ; Mon, 29 Mar 2021 06:44:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CE5081BAEC for ; Mon, 29 Mar 2021 08:44:12 +0200 (CEST) Received: from localhost ([::1]:39040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQldD-00006v-GO for larch@yhetil.org; Mon, 29 Mar 2021 02:44:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQld4-00006h-Nx for guix-patches@gnu.org; Mon, 29 Mar 2021 02:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQld4-0000mB-Co for guix-patches@gnu.org; Mon, 29 Mar 2021 02:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQld4-0002lG-AZ for guix-patches@gnu.org; Mon, 29 Mar 2021 02:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#46724] [PATCH] gnu: vtk: Update to 9.0.1 Resent-From: Andy Tai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 29 Mar 2021 06:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46724 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch Cc: 46724@debbugs.gnu.org Received: via spool by 46724-submit@debbugs.gnu.org id=B46724.161700022210575 (code B ref 46724); Mon, 29 Mar 2021 06:44:02 +0000 Received: (at 46724) by debbugs.gnu.org; 29 Mar 2021 06:43:42 +0000 Received: from localhost ([127.0.0.1]:47638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQlck-0002kU-DD for submit@debbugs.gnu.org; Mon, 29 Mar 2021 02:43:42 -0400 Received: from mail-io1-f45.google.com ([209.85.166.45]:35697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQlci-0002kD-5W for 46724@debbugs.gnu.org; Mon, 29 Mar 2021 02:43:41 -0400 Received: by mail-io1-f45.google.com with SMTP id x17so11693105iog.2 for <46724@debbugs.gnu.org>; Sun, 28 Mar 2021 23:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:cc :content-transfer-encoding; bh=Boz2r9m6KzXpoUHy2bbchZlME3Uy52t9bSD9Gnj2jjg=; b=WkzH20/IaDhr21liB0xGgF13X7t5fBKb+IoOfb6BbdcK4nQHa6QXXyn23dkXk2Xjnb 8H4cnRE+e1OtGxEdMATlVKn/dSwV86/UwSLAZCyJme/SOTE1Bkk0bC4VQq4R5irAQEjm 4MbxqDgqLL/iMaf28RUQuKqEi427xbZcGdxi4EnqHrWZSBvK83HdWqTdd5u+9qdFxXsO 865IV6rzyaCLNw7MqCY64CVLD3uYJ8zNAovN84uELKe9ZesSxGgXHAGh44/E+EQ7Qs+i eDe+mNliwzEjkCQFcQhqLRjF0MxFNduqTUvFk27U6VV99MlX0jauikRhokFv5zkPNO7Q G7EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc:content-transfer-encoding; bh=Boz2r9m6KzXpoUHy2bbchZlME3Uy52t9bSD9Gnj2jjg=; b=j7RLNvBUYjaogl3BCiMnZ/wqwvPO5Ps5VUSjo3UyaxvKODF4rewCbm8sWQE3XpFLgi 7Jw5h7a0pgrwv5lW3kfh5UH2yU03Z8OPzqx4S3vxHF3Hmr+zLVV+11amkPOO98yDvhTA xABjS91H+LxYF4I7kWajo4pedCIo2D2S3GDs6JgrpExpZWzx9ZV3LcP/L0nouKdTzM8D m08bRO9IA9JO6Cbce7NK8KpWDy/5suzlGtv5nlRTSa9bxvmXcp3X6wfdAXiNN1kOFSYG 6rygQF8zB2V+mqTqSFazYr0scj5eR+bmMY54Hc6N3+xwBpp1NTXL+wSYn7BOoguTxPls fSzA== X-Gm-Message-State: AOAM532ptY1GrgOr0DmHqel87Bl5+t9EkUabn0c3DMMpgaigZ6Vz4EOO W3oGpT6VmRWNm5eIUd/kWMMAJnLYmcMZW1UzDpBGY1YxcBQRew== X-Google-Smtp-Source: ABdhPJwwgaES2x8APbaFKMRV8Fo6lju8iouWNS31U9f5KA6X/zTOV593nkFDONa3rPnj9fXoMFqgGOLioHya2jjlUMs= X-Received: by 2002:a6b:c881:: with SMTP id y123mr18236987iof.152.1617000214295; Sun, 28 Mar 2021 23:43:34 -0700 (PDT) MIME-Version: 1.0 References: <87r1kxuzqa.fsf@gnu.org> <877dm3jzgo.fsf_-_@gnu.org> In-Reply-To: From: Andy Tai Date: Sun, 28 Mar 2021 23:42:58 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617000253; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Boz2r9m6KzXpoUHy2bbchZlME3Uy52t9bSD9Gnj2jjg=; b=NLEqFjaJf/Vn3iJTus/ya41tVZ55JNz2PEbr7QZanZftc7DfvuEs2He/z+ug1jImRg3vCQ AmSWt3vMNYU1LcNNYf5Uigf2Jswrq/t4OAH2VsMNF/UK/GVamDEb38mHc2Ly2olJfvtMWt zP7PKBToRYs+pMK6/g/QfZHZfBnKYVuD27I47zyF3gYTvdQoDD1qWEChU5PLJ/pDWfucf+ CWTS26LOq6SkkWtn2uSBsnMY2v7LQH2L7tYsRBe7WIT+OW4nMkvoTMRMbz0+ePcGku+ASv SodWPeHJUdzutU1SKVgb16Hx32bmjTCeXeiGJHWmfMAwvBZmNNZyUSUeno+8dA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617000253; a=rsa-sha256; cv=none; b=My0GxkYsph+bNfhLryW/vBNeLNtcrcPxXGlEhOPMlqyj06EG4ZOqcKV+pwOi7CV8EP3snQ 1kD2khDB580d4Dl/x9cRvv1Mwd9E7H40diGp6e2/FjSR8E+48s93iQ76c2s6DlpQJfW6xF I8RYKAhz4VtJ54mFPkeWxm8XZQ2otJg2W0ROWAUohAB9MlGyu55vZX02HGAN7K6xJTbQ3v D0lcVXZ4/aa3GcRhsp5YHtG5zSMk/4a7RUgPo9+sfyYU0Uk3MrjKRXPradcVhMunicHvJO 1z2h2THB38vzYWyNqcHmHwvMOq6rxM5cyfJXfnwM2QhtPtHQy70SDdlfly0dMA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=atai-org.20150623.gappssmtp.com header.s=20150623 header.b="WkzH20/I"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.58 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=atai-org.20150623.gappssmtp.com header.s=20150623 header.b="WkzH20/I"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CE5081BAEC X-Spam-Score: 0.58 X-Migadu-Scanner: scn0.migadu.com X-TUID: xJ7tPA9rVbFo currently, mia build is actually broken with vtk 8.2.0, the version in guix repo; If I do guix install mia that actually fail in build: [ 13%] Building CXX object mia/core/fastica/CMakeFiles/test-fastica-deflation-deflationnonlinearity.di= r/test_deflationnonlinearity.cc.o cd /tmp/guix-build-mia-2.4.6.drv-0/build/mia/core/fastica && /gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0/bin/c++ -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_VERSION=3D3 -DBOOST_SYSTEM_DYN_LINK -DBOOST_UNIT_TEST_FRAMEWORK_DYN_LINK -DHAVE_CONFIG_H -I/gnu/store/n50ikpnyzdda0zklwnmqasklcrif2csg-eigen-3.3.8/include/eigen3 -I/gnu/store/c8w9z48vvx2a3q3k44ch9yn00wk1qwhb-libxml2-2.9.10/include/libxml= 2 -I/tmp/guix-build-mia-2.4.6.drv-0/build -I/tmp/guix-build-mia-2.4.6.drv-0/mia-2.4.6 -fpermissive -fvisibility=3Dhidden -O2 -g -DNDEBUG -DBOOST_TEST_DYN_LINK -o CMakeFiles/test-fastica-deflation-deflationnonlinearity.dir/test_deflationn= onlinearity.cc.o -c /tmp/guix-build-mia-2.4.6.drv-0/mia-2.4.6/mia/core/fastica/test_deflatio= nnonlinearity.cc /tmp/guix-build-mia-2.4.6.drv-0/mia-2.4.6/addons/vtk/vtkmesh.cc: In function =E2=80=98void vtkmia::read_normals(mia::CTriangleMesh&, vtkPointData&)=E2=80=99: /tmp/guix-build-mia-2.4.6.drv-0/mia-2.4.6/addons/vtk/vtkmesh.cc:179:12: error: =E2=80=98class vtkFloatArray=E2=80=99 has no member named =E2=80=98G= etTupleValue=E2=80=99; did you mean =E2=80=98GetValue=E2=80=99? normals->GetTupleValue(i, &is->x); ^~~~~~~~~~~~~ GetValue /tmp/guix-build-mia-2.4.6.drv-0/mia-2.4.6/addons/vtk/vtkmesh.cc: In function =E2=80=98void vtkmia::read_colors(mia::CTriangleMesh&, vtkPointData&)=E2=80=99: /tmp/guix-build-mia-2.4.6.drv-0/mia-2.4.6/addons/vtk/vtkmesh.cc:211:11: error: =E2=80=98class vtkFloatArray=E2=80=99 has no member named =E2=80=98G= etTupleValue=E2=80=99; did you mean =E2=80=98GetValue=E2=80=99? colors->GetTupleValue(i, &is->x); ^~~~~~~~~~~~~ GetValue make[2]: *** [addons/vtk/CMakeFiles/mesh-io-vtkmesh-common.dir/build.make:6= 6: addons/vtk/CMakeFiles/mesh-io-vtkmesh-common.dir/vtkmesh.cc.o] Error 1 make[2]: Leaving directory '/tmp/guix-build-mia-2.4.6.drv-0/build' make[1]: *** [CMakeFiles/Makefile2:23838: addons/vtk/CMakeFiles/mesh-io-vtkmesh-common.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... make[2]: Leaving directory '/tmp/guix-build-mia-2.4.6.drv-0/build' So this makes a separate bug... On Fri, Mar 19, 2021 at 10:43 AM Andy Tai wrote: > > Ok, I'll take a look. > > On Fri, Mar 19, 2021 at 1:54 AM Ludovic Court=C3=A8s wrote= : > > > > Hi Andy, > > > > Thanks for the update! I spent some time checking whether dependents, > > as returned by =E2=80=98guix refresh -l vtk=E2=80=99, would still build= . > > > > It turns out tha =E2=80=98mia=E2=80=99 no longer builds after this upda= te because the > > =E2=80=98VTK_INCLUDE_DIRS=E2=80=99 CMake variable remains empty. I=E2= =80=99m not > > familiar (or averse to?) CMake, and I couldn=E2=80=99t figure out why t= hat is > > the case. > > > > Could you take a look? > > > > As a last resort, we could preserve VTK 8.2 and use it in MIA. > > > > Attached is my variant of the patch, which propagates libogg, as was > > needed for some dependents, but really we could/should propagate > > libtheora, lz4, and double-conversion for the same reasons it seems. > > > > Let me know what you think! > > > > Thanks, > > Ludo=E2=80=99. > > > > > -- > Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andy= tai1010 > Year 2021 =E6=B0=91=E5=9C=8B110=E5=B9=B4 > =E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B=E6=98=AF=E4=BF=A1= =E4=BB=B0=E8=88=87=E8=A6=BA=E6=82=9F > =E8=87=AA=E5=8B=95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E= =E5=8B=95=E8=88=87=E6=8A=80=E8=83=BD --=20 Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andyta= i1010 Year 2021 =E6=B0=91=E5=9C=8B110=E5=B9=B4 =E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B=E6=98=AF=E4=BF=A1=E4= =BB=B0=E8=88=87=E8=A6=BA=E6=82=9F =E8=87=AA=E5=8B=95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E=E5= =8B=95=E8=88=87=E6=8A=80=E8=83=BD