From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CF9ZF8cC12ZkdQEAqHPOHw:P1 (envelope-from ) for ; Tue, 03 Sep 2024 12:36:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id CF9ZF8cC12ZkdQEAqHPOHw (envelope-from ) for ; Tue, 03 Sep 2024 14:36:23 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="VPMp/1A6"; dkim=fail ("headers rsa verify failed") header.d=gmail-com.20230601.gappssmtp.com header.s=20230601 header.b="jWTI40/Q"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725366983; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Sob3UWdHZB5wzMSHZqbvmmY6/B4GiZM2L2kRvbPNczQ=; b=lZ7vwqtjqpCbtTeflLlSyhQ+zwK6bkmlofUR5IQ/Oxwil/YRQu3DFZf/CxVctSEpl8I2tD Mxu7wYHOLXZXwOR2jZY53KwEVT5YN11ec/UXUIuLeya2UYQ5sSw+FAZKJS8Yuxel1PCxb+ JKk2DJ3ZVf2xY7utf1Lkej4ty2ovWxYaAHdZUMqlnci17Cuxic/tWcRKYqVAc4UvacZutB FFJ+aqrxeGYNZkfv2LxNBcVoidnJeLNrj8cWF65LJ+gFLojSQM0R7e0p32wUl+2+aauFxo oT9rGwMpqIoq3Z8thkY52XNv9AQvai6KI04oquKow6o1HaTH73nxiXxDdDvAEg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725366983; a=rsa-sha256; cv=none; b=mfH+ravnu5z2zr9PBpw3H5yuPOws/ExseDmjZoSZZm/ajr9ptErKv5X9EQT24j7rsKt3X7 nQnCA8gunpWw3lynYg3x0I5PKUm3D+ee8ggydZHZFl0wkugcKp5Rwqty9b54EslgKnTq/O mjBCx4oxitNlxPPc7RUwmCnrQppxfuI+tEwZODR/DjVjPqELp16BpmQOlOn67QspDEMkiD u6l3mi7yUZ0Biy2FTWW9uBo9CZV1TrGjHhx4+g4lZTMex4T6W4xVi42uuPnpytwWqKAa99 yB/cHnzABuRIuzL30dXj1R4VED7ozgJGMAev2h0PEUSQmR+txAa5oJHMIrPOuw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="VPMp/1A6"; dkim=fail ("headers rsa verify failed") header.d=gmail-com.20230601.gappssmtp.com header.s=20230601 header.b="jWTI40/Q"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B7DF569E90 for ; Tue, 3 Sep 2024 14:36:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slSlO-0008PG-IP; Tue, 03 Sep 2024 08:36:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slSlM-0008Ot-NS for guix-patches@gnu.org; Tue, 03 Sep 2024 08:36:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1slSlM-0006k0-CP for guix-patches@gnu.org; Tue, 03 Sep 2024 08:36:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=Sob3UWdHZB5wzMSHZqbvmmY6/B4GiZM2L2kRvbPNczQ=; b=VPMp/1A6VXA8jRT0zO+2J5n0ATBPjdzAXldGIGS7Y+Hg6nTQsLONDA1Kmmki5C+Nn17+pBO9osR36uC4M1FJr4LYCztRh/87TPXvnmm3x/XAytAV0AUBq3FAcv2XJPUSYtbzUS5pkya02pzCGec4dYNBGVUGTNgN06odtYMgG7T+4NdNxl37ErT0lwuexJiXrAuYUN1eEU91i2LeayrrFMX0fMoG9PhgYg6ar2I0CRIPmVPEBqEfq53ieJLbGUR91MCNcS8PSsHj44DDiaztnzqjLJasdLYiDHugpRLpTwnPzWSZwowIL58YnOdCj2j3X2Zy/gw6oh5JbRpimt/Cig==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1slSmM-0002Om-Hx for guix-patches@gnu.org; Tue, 03 Sep 2024 08:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72885] [PATCH v2] gnu: screen: Update to 5.0.0 Resent-From: Andy Tai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Sep 2024 12:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72885 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 72885@debbugs.gnu.org Received: via spool by 72885-submit@debbugs.gnu.org id=B72885.17253669649131 (code B ref 72885); Tue, 03 Sep 2024 12:37:02 +0000 Received: (at 72885) by debbugs.gnu.org; 3 Sep 2024 12:36:04 +0000 Received: from localhost ([127.0.0.1]:59352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slSlQ-0002NC-69 for submit@debbugs.gnu.org; Tue, 03 Sep 2024 08:36:04 -0400 Received: from mail-vs1-f49.google.com ([209.85.217.49]:52375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slSlO-0002Me-9F for 72885@debbugs.gnu.org; Tue, 03 Sep 2024 08:36:03 -0400 Received: by mail-vs1-f49.google.com with SMTP id ada2fe7eead31-498c8a6220fso1799398137.0 for <72885@debbugs.gnu.org>; Tue, 03 Sep 2024 05:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail-com.20230601.gappssmtp.com; s=20230601; t=1725366834; x=1725971634; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Sob3UWdHZB5wzMSHZqbvmmY6/B4GiZM2L2kRvbPNczQ=; b=jWTI40/Qe8IoJSbiRCCdNdDV5qJKm9BF7SN2Y7rMR2NWBe1FmibYh+SWmRq60ribv7 jgyJaUfQLdBFRDllhq3OoLx7Ve1Y+aktY9qTPIXETnK2b3eE7/eW0dTIX498CGGnh5ie vC7kYekhrHml93RBmq/om8x86V4wZTeeVh8NQ2Nq0LMvsXeRk67OisoypDKdBr3cFLwO to4PdVh4wJn5gS79Bdt99R+C8FdkERjfQs3Ne3lmQGXrVE0V/ti0lE4PxFGCSKTCT1cq Nzfwlf1BSDT7nptMXTOwHGlC14nWaSkpcyxQeQZAooZ7gPTD65zw2Df+b8dJegRTVGVH 3zXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725366834; x=1725971634; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sob3UWdHZB5wzMSHZqbvmmY6/B4GiZM2L2kRvbPNczQ=; b=kmSaDzFEnJWfp4hfIclpv8b5POOTrPPQhZqcXIbsb+YvXhw5SMJPVAKnZZkRNjXpNg qeeJfzCFDK1H4SrZDBqWohKX/wVgFFfmIF61QOorL7Te5ag3X2g06HCX2mBdl5PTdMyZ TYijuk5huRmBqgnWkxWc/r7WAvXNHDHj+Dc2FkYcyXzUXzytA5CVETBvnb2BoHjG9/dB q0Rq2ooY7c1NN/7nQPDmoqQxkOyhVFggEOCNF9SuhN5gPxXV7hzzFBGRgt9TLu1HiKe0 uOqSZcowtGTupe47vKTgGxt6yGU1xn41ltZcE3qW5dUSu4JEMdMC7FW2nCZYCE0qM//0 SRNg== X-Gm-Message-State: AOJu0Ywl3/F7PrKsBjFMfaKtDUZJhNnEImxAU9d8WCR3pDqpQZ5RIBJg iy4ElfL2E45Uu1pa3MNwpfLXi+XHyLVAMObRjW8MSvRSRVTXXjlNWm/0prQF7USYYJO4vEJ7NSQ hS2W8RWlFZ21mcwgbek1cfjs8XXCylg== X-Google-Smtp-Source: AGHT+IG87LzZwDemDts4ZSURmcxCj3MWKjqRb+eJn+EUAZA5b1QLN51bMzqigkqjKxk/A5QfrH2UZ1C5bDKvKPJQT60= X-Received: by 2002:a05:6102:41a6:b0:493:b006:e1a with SMTP id ada2fe7eead31-49a774f4ac5mr13783973137.7.1725366834355; Tue, 03 Sep 2024 05:33:54 -0700 (PDT) MIME-Version: 1.0 References: <3094ea0169f5d37b90a1fccb4d495bdaa6ab6158.1725174170.git.atai@atai.org> <877cbtgdpg.fsf@gnu.org> In-Reply-To: <877cbtgdpg.fsf@gnu.org> From: Andy Tai Date: Tue, 3 Sep 2024 05:33:17 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: B7DF569E90 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.02 X-Spam-Score: -9.02 X-TUID: TwEugVDxze5L Updated patch sent, CFLAGS updated, Hurd cross compiling OK. On Tue, Sep 3, 2024 at 4:48=E2=80=AFAM Ludovic Court=C3=A8s = wrote: > > Hello, > > Andy Tai skribis: > > > * gnu/packages/patches/screen-hurd-path-max.patch: Update for screen 5.= 0.0. > > * gnu/packages/screen.scm (screen): Update to 5.0.0. > > [arguments]<#:configure-flags: Add "CFLAGS=3D-D_GNU_SOURCE=3D1". > > [inputs]: Add linux-pam. > > > > Change-Id: Iebc5eff0128ff7f4d27a22cca1bd4a025aca3244 > > [...] > > > -+ * Define PATH_MAX to 4096 if it's not defined, like on GNU/Hurd > > Did you confirm that it still builds for GNU/Hurd? > > You can test by cross-compiling with =E2=80=98--target=3Di586-pc-gnu=E2= =80=99 or by > compiling natively, if you have configured the =E2=80=98hurd-vm=E2=80=99 = service, with > =E2=80=98--system=3Di586-gnu=E2=80=99. > > > (arguments > > `(#:configure-flags > > + ;; GNU_SOURCE must be defined for mallocmock_reset() to be de= fined > > + '("CFLAGS=3D-D_GNU_SOURCE=3D1" > > This very likely removes the default flags, =E2=80=9C-O2 -g=E2=80=9D, whi= ch is something > we should not do (we=E2=80=99d get an unoptimized build and =E2=80=98--wi= th-debug-info=E2=80=99 > wouldn=E2=80=99t have the intended effect). I think you need to have: > > "CFLAGS=3D-O2 -g -D_GNU_SOURCE=3D1" > > instead. Please check the build log to make sure it has the intended > effect. > > Could you send an updated patch? > > Thanks, > Ludo=E2=80=99.