unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andy Tai <atai@atai.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 35922@debbugs.gnu.org
Subject: [bug#35922] [PATCH] gnu: add terminator
Date: Wed, 29 May 2019 22:58:03 -0700	[thread overview]
Message-ID: <CAJsg1E9Q0TDnZeHD=uOGcCEXqg1tpSxXCjuUsaN4XHAeGkegxw@mail.gmail.com> (raw)
In-Reply-To: <874l5dt1au.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

On Wed, May 29, 2019 at 2:10 PM Ludovic Courtès <ludo@gnu.org> wrote:

> Hello,
>
> atai@atai.org skribis:
>
> > From: Andy Tai <atai@atai.org>
> >
> > * gnu/packages/gnome.scm (terminator): Add at 1.91
>
> [...]
>
> > +    (arguments
> > +     `(#:python ,python-2))
>
> Python 2.x is reaching EOL real soon.  Can it run on Python 3?
>

hi, no, not the current upstream... I tried with python-3 and won't run

>
> > +    (description
> > +     "A tool to allow running multiple GNOME terminals in a grid and
> > +     tabs and support for drag and drop re-ordering of terminals")
>
> Could you make a full sentence and remove the trailing spaces?  See
> <
> https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html
> >.
>
> will update


> > +    (license license:gpl2)))
>
> This means “version 2 only”.  Is there an explicit “version 2 only”
> statement, for example in source file headers?  If not, it should be
> ‘gpl2+’.
>
> source clearly labeled gpl "Version 2 Only"

> Could you send an updated patch?
>
> will do

> Thank you,
> Ludo’.
>


-- 
Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat:
andytai1010
Year 2019 民國108年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能

[-- Attachment #2: Type: text/html, Size: 3398 bytes --]

  reply	other threads:[~2019-05-30  5:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  7:46 [bug#35922] [PATCH] gnu: add terminator atai
2019-05-29 21:10 ` Ludovic Courtès
2019-05-30  5:58   ` Andy Tai [this message]
2019-05-30  9:54   ` Ricardo Wurmus
2019-05-31  4:58     ` Andy Tai
2019-05-31  7:52       ` Ricardo Wurmus
2019-05-31 15:44         ` Andy Tai
2019-05-30  6:02 ` atai
2019-06-01 12:48   ` Ludovic Courtès
2019-06-01 17:42     ` Andy Tai
2019-06-01 17:41 ` atai
2019-06-01 21:56   ` bug#35922: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJsg1E9Q0TDnZeHD=uOGcCEXqg1tpSxXCjuUsaN4XHAeGkegxw@mail.gmail.com' \
    --to=atai@atai.org \
    --cc=35922@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).