From: Andy Tai <atai@atai.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 70563@debbugs.gnu.org, control@debbugs.gnu.org,
Nicolas Graves <ngraves@ngraves.fr>
Subject: [bug#70563] QA review for 70563
Date: Mon, 13 May 2024 07:09:54 -0700 [thread overview]
Message-ID: <CAJsg1E9HceszayvyC568zkgTzFsvdZxMq2BxNQKS2w2VdzVAqg@mail.gmail.com> (raw)
In-Reply-To: <875xvhc2le.fsf@gnu.org>
OK I did not see that reply in email but I will send v2 patch
addressing the comment
On Mon, May 13, 2024 at 5:34 AM Ludovic Courtès <ludo@gnu.org> wrote:
>
> Hi Andy,
>
> Did you receive Nicolas’ message below?
>
> Nicolas Graves <ngraves@ngraves.fr> skribis:
>
> > user guix
> > usertag 70563 + reviewed-looks-good
> > thanks
> >
> > Guix QA review form submission:
> > The description probably needs a little bit more precision. In particular, it would be good to include the statement "PKCS#11 is the de-facto standard to access cryptographic devices." or something like that.
> >
> > Otherwise LGTM.
>
> Note that despite being marked as “reviewed-looks-good”, Nicolas makes
> a suggestion that I think is worth addressing in a second version.
>
> Thanks,
> Ludo’.
--
Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2024 民國113年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能
next prev parent reply other threads:[~2024-05-13 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 9:22 [bug#70563] [PATCH] gnu: Add pkcs11-helper Andy Tai
[not found] ` <handler.70563.B.171403701115514.ack@debbugs.gnu.org>
2024-04-30 19:21 ` [bug#70563] Acknowledgement ([PATCH] gnu: Add pkcs11-helper.) Andy Tai
2024-05-02 21:21 ` [bug#70563] Andy Tai
2024-05-13 7:01 ` [bug#70563] QA review for 70563 Nicolas Graves via Guix-patches via
2024-05-13 12:34 ` Ludovic Courtès
2024-05-13 14:09 ` Andy Tai [this message]
2024-05-16 5:42 ` [bug#70563] [PATCH v2] gnu: Add pkcs11-helper Andy Tai
2024-05-22 5:34 ` Z572
2024-05-22 6:16 ` Andy Tai
2024-05-22 17:31 ` [bug#70563] [PATCH v3] " Andy Tai
2024-05-23 5:34 ` bug#70563: " Zheng Junjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJsg1E9HceszayvyC568zkgTzFsvdZxMq2BxNQKS2w2VdzVAqg@mail.gmail.com \
--to=atai@atai.org \
--cc=70563@debbugs.gnu.org \
--cc=control@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=ngraves@ngraves.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).