From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wHMaApprrWS7iAAASxT56A (envelope-from ) for ; Tue, 11 Jul 2023 16:47:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EOfaAJprrWR5zgAAG6o9tA (envelope-from ) for ; Tue, 11 Jul 2023 16:47:54 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A3228414DD for ; Tue, 11 Jul 2023 16:47:53 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=atai-org.20221208.gappssmtp.com header.s=20221208 header.b=M2g7RxX0; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689086873; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ZRXiDPjDQ2TmcV1NgBKlexAwqBeaG/6Z95vUml8HGYo=; b=pdjk6woLQ0hHrGJ1oJIBzI2NIPLUr0kNmSzYZhgdKLL5y08EI6g8NWF53IGRZCr7Zlc1L7 mynr9OHwSan5fzUDFo0FpZVWq8xlW8RoSpdggtBI14ud/sWeptHM+/ExeBxyOchi2RSGg+ aRzoofZP9WaFbcmaiaPgnXWrvWf/E62B9u6T8sMl3NwjQl/AdqkfjQF8zXR5fi0dLqKzsW Mp1O4sjUUH3ViiduVnbX1vmAm3vJf8R0+yiGVVfJPLLd0yXwAbdaWt8u4KdqJGO2u9PjuW /KeieUh6RYfG8wy/YdHzMtWLda7nyXIxlz7eq92hcEL/w3wXJUtlyUSOI62gyg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=atai-org.20221208.gappssmtp.com header.s=20221208 header.b=M2g7RxX0; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689086873; a=rsa-sha256; cv=none; b=uwGK2QB1zPbhAQWpBAz+oHYu6zpzGNR9IlWhbNo+vC2siH8h56BlOIh4GlGFcva0Orcf/+ HVvJuSXVlDImMVE52d3GQuOwRiweyFZbpOrR60SPCaIv6afa5HFNSiBraO6VohYGCDsHca fJSnTzKnZFHFP5YjZEhBqZIWtxIK5XaoASXaB5vU6xZOT7YN+SheKva3bAHCWnKe7dO7TX yRcUTPG9iTgbJGG7gXvb+eU6+wQjv/VIfxoscDEU7g+7JGGe2p3D5kKNNUZllp6h/bVvGy Vkh7MwMPy76PFan+/PQK22yED7pFL7KIaaAk7fNH0CYz2Glvs6LDDdSHJRejqQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJE97-0001TW-JK; Tue, 11 Jul 2023 10:15:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJE8s-0001Sb-HR for guix-patches@gnu.org; Tue, 11 Jul 2023 10:15:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJE8s-0003II-98 for guix-patches@gnu.org; Tue, 11 Jul 2023 10:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJE8s-0006JB-4Q for guix-patches@gnu.org; Tue, 11 Jul 2023 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64261] [PATCH] gnu: Add xrdp Resent-From: Andy Tai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 Jul 2023 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64261 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 64261@debbugs.gnu.org Received: via spool by 64261-submit@debbugs.gnu.org id=B64261.168908484824143 (code B ref 64261); Tue, 11 Jul 2023 14:15:02 +0000 Received: (at 64261) by debbugs.gnu.org; 11 Jul 2023 14:14:08 +0000 Received: from localhost ([127.0.0.1]:50861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJE7z-0006HK-Mc for submit@debbugs.gnu.org; Tue, 11 Jul 2023 10:14:08 -0400 Received: from mail-ua1-f41.google.com ([209.85.222.41]:58419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJE7t-0006GO-Lm for 64261@debbugs.gnu.org; Tue, 11 Jul 2023 10:14:05 -0400 Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-78a5384a5daso1550489241.0 for <64261@debbugs.gnu.org>; Tue, 11 Jul 2023 07:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20221208.gappssmtp.com; s=20221208; t=1689084836; x=1691676836; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZRXiDPjDQ2TmcV1NgBKlexAwqBeaG/6Z95vUml8HGYo=; b=M2g7RxX0os5o4NKAZCMlHt8B8NYYUxUMQhRnsuuRE/IVmfi8ffDIuMUzw38H+vvDOl 3ucWD6B25fDCB6GSTAu8S+91zS2dBHgIqcGbWM9R4HTHQ+6ZD8r73jPob8+dKqjWprd9 dY7qMZxCB3iCbA45cQBoZAxW68jPRlEuGMB2q79LNR5IF2fuAmN5NazTnhsZCSw7qV2i aSpZJAEapagfm8H6M+cwEEXFbslOxHWD/W85WTPPmzYx7J0+Gn0vSISd0GoT/x9ge1Q1 vohjDxUOpgWOPvtuRf+UZj6AtE25xpLz926WGszU7zTAqvbZsiypABiWNhHFVWRPULgt TKnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689084836; x=1691676836; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZRXiDPjDQ2TmcV1NgBKlexAwqBeaG/6Z95vUml8HGYo=; b=alN1G3P8RsyO0JZ29+jCLwF+cotMFviwkFdEW6yo8sOMH+3XNtQjqVzuKUywrdP0cI nyeDcn5iKkXFM8ZjdZ0ehSj6Ipweknpj9FFGjkIdEmY1wRAiKTnNwzu2/TdK3un9panT SPCheEYn+w8OumO8D8wxuLsM0vcFD4HRkoANegxx+VR8XlG38TEaJtbBfPHjmXe5he2O J6uH6v5XkdF9MrZs3EU7ndtZtj3P4xOGN58vhs/H+0F5pK8lBd3GjSRuvnDgqdjDAzMC tekMswo8rGvPmaACdDQ5W6nBkLuvIMMazdtRW0kKZOTcBf+zQ2IzfLkWtKekMnM3QayA uOxg== X-Gm-Message-State: ABy/qLb/QoUDlxYyFkVR7rq2EOvZd7P8HwyF+nGelMM95S6JT/E+HNF6 TVuYdqAclsLeCq05/iNsnN0UwUdf6Jtig3pXd9U= X-Google-Smtp-Source: APBJJlGkvwlJci4SbIrut30QCGHIkf75qKf/i5WESAg610EJHI6d4vKMjnklswgXHKe1WTrvCtb8xqnopOcK7F5Qtrg= X-Received: by 2002:a67:bc1a:0:b0:440:cbbf:cd72 with SMTP id t26-20020a67bc1a000000b00440cbbfcd72mr4906409vsn.4.1689084835649; Tue, 11 Jul 2023 07:13:55 -0700 (PDT) MIME-Version: 1.0 References: <6175dfd2c421fadf757a66ebd96ed1085c168c6b.1687592180.git.atai@atai.org> <87zg4235cf.fsf_-_@gnu.org> In-Reply-To: <87zg4235cf.fsf_-_@gnu.org> From: Andy Tai Date: Tue, 11 Jul 2023 07:13:18 -0700 Message-ID: Content-Type: multipart/alternative; boundary="0000000000009fdce2060036b52e" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.30 X-Spam-Score: -2.30 X-Migadu-Queue-Id: A3228414DD X-Migadu-Scanner: mx1.migadu.com X-TUID: 2/m7k0fqwSmZ --0000000000009fdce2060036b52e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable will do On Tue, Jul 11, 2023 at 7:12=E2=80=AFAM Ludovic Court=C3=A8s = wrote: > Hi Andy, > > Andy Tai skribis: > > > * gnu/packages/rdesktop.scm (xrdp): New variabble > > (xorgxrdp): New variable > > Could you send a v2 with one patch per package, as is customary? > > > + (home-page "https://www.xrdp.org") > > + (synopsis "Open source RDP server ") > > Please remote the trailing slash as well as =E2=80=9Copen source=E2=80=9D= : everything is > free software in here, so no need to specify it! :-) However, please > spell out =E2=80=9CRemote Desktop Protocol (RDP)=E2=80=9D. > > > + (description > > + "Xrdp provides a graphical login to remote machines using > > +Microsoft Remote Desktop Protocol (RDP). Xrdp accepts connections fro= m > a > > +variety of RDP clients: > > +* FreeRDP > > +* rdesktop > > Please use @itemize. > > See > < > https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.= html > >. > > > +(define-public xorgxrdp > > + (package > > + (name "xorgxrdp") > > + (version "0.9.19") > > + (source (origin > > + (method url-fetch) > > + (uri (string-append > > + " > https://github.com/neutrinolabs/xorgxrdp/releases/download/v" > > + version "/xorgxrdp-" version ".tar.gz")) > > + (sha256 > > + (base32 > > + > "0m8lvdnhfvwwqrr56difgy3mblplp23x6iy12kl4r8i87ic4rky1")))) > > Should it inherit from =E2=80=98xrdp=E2=80=99? I fail to see what the di= fference is. > > > + (arguments > > + (list #:configure-flags #~(list "--enable-strict-locations=3Dyes" > > + (string-append "XRDP_CFLAGS=3D-I" > > + (assoc-ref > %build-inputs > > + "xrdp") > > + "/common")))) > > Rather than (assoc-ref =E2=80=A6), write #$(this-package-input "xrdp'). > > Also, xrdp should not have .h files under /common; it should be under > /include or /include/common or similar. Could you check that? > > > + (home-page "https://github.com/neutrinolabs/xorgxrdp") > > + (synopsis "Xorg drivers for xrdp") > > + (description > > + "xorgxrdp is a collection of modules to be used with a > pre-existing X.Org > > +install to make the X server act like X11rdp") > > Please add a period at the end of the sentence and expound a bit so one > can better understand what this is about. > > Thanks in advance! > > Ludo=E2=80=99. > --=20 Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010 Year 2023 =E6=B0=91=E5=9C=8B112=E5=B9=B4 =E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B=E6=98=AF=E4=BF=A1=E4= =BB=B0=E8=88=87=E8=A6=BA=E6=82=9F =E8=87=AA=E5=8B=95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E=E5= =8B=95=E8=88=87=E6=8A=80=E8=83=BD --0000000000009fdce2060036b52e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
will do

<= div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jul 11, 2023 at 7:12=E2=80=AFA= M Ludovic Court=C3=A8s <ludo@gnu.org= > wrote:
Hi A= ndy,

Andy Tai <atai@atai.o= rg> skribis:

> * gnu/packages/rdesktop.scm (xrdp): New variabble
>=C2=A0 =C2=A0(xorgxrdp): New variable

Could you send a v2 with one patch per package, as is customary?

> +=C2=A0 =C2=A0 (home-page "https://www.xrdp.org")
> +=C2=A0 =C2=A0 (synopsis "Open source RDP server ")

Please remote the trailing slash as well as =E2=80=9Copen source=E2=80=9D: = everything is
free software in here, so no need to specify it! :-) However, please
spell out =E2=80=9CRemote Desktop Protocol (RDP)=E2=80=9D.

> +=C2=A0 =C2=A0 (description
> +=C2=A0 =C2=A0 =C2=A0"Xrdp provides a graphical login to remote m= achines using
> +Microsoft Remote Desktop Protocol (RDP).=C2=A0 Xrdp accepts connectio= ns from a
> +variety of RDP clients:
> +* FreeRDP
> +* rdesktop

Please use @itemize.

See
<https://guix.gnu.or= g/manual/devel/en/html_node/Synopses-and-Descriptions.html>.

> +(define-public xorgxrdp
> +=C2=A0 (package
> +=C2=A0 =C2=A0 (name "xorgxrdp")
> +=C2=A0 =C2=A0 (version "0.9.19")
> +=C2=A0 =C2=A0 (source (origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (method url-fetch) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uri (string-append<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= "https://github.com/neutrinolabs/x= orgxrdp/releases/download/v"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= version "/xorgxrdp-" version ".tar.gz"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(base32
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "0m8lvdn= hfvwwqrr56difgy3mblplp23x6iy12kl4r8i87ic4rky1"))))

Should it inherit from =E2=80=98xrdp=E2=80=99?=C2=A0 I fail to see what the= difference is.

> +=C2=A0 =C2=A0 (arguments
> +=C2=A0 =C2=A0 =C2=A0(list #:configure-flags #~(list "--enable-st= rict-locations=3Dyes"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(string-appe= nd "XRDP_CFLAGS=3D-I"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (assoc-ref %build-inputs
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0"xrdp")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "/common"))))

Rather than (assoc-ref =E2=80=A6), write #$(this-package-input "xrdp&#= 39;).

Also, xrdp should not have .h files under /common; it should be under
/include or /include/common or similar.=C2=A0 Could you check that?

> +=C2=A0 =C2=A0 (home-page "https://github.com/neut= rinolabs/xorgxrdp")
> +=C2=A0 =C2=A0 (synopsis "Xorg drivers for xrdp")
> +=C2=A0 =C2=A0 (description
> +=C2=A0 =C2=A0 =C2=A0"xorgxrdp is a collection of modules to be u= sed with a pre-existing X.Org
> +install to make the X server act like X11rdp")

Please add a period at the end of the sentence and expound a bit so one
can better understand what this is about.

Thanks in advance!

Ludo=E2=80=99.


--
=
Andy Tai, atai@atai.org, Skype: li= cheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2023 =E6=B0=91=E5=9C= =8B112=E5=B9=B4
=E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B= =E6=98=AF=E4=BF=A1=E4=BB=B0=E8=88=87=E8=A6=BA=E6=82=9F
=E8=87=AA=E5=8B= =95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E=E5=8B=95=E8=88=87= =E6=8A=80=E8=83=BD
--0000000000009fdce2060036b52e--