[bug#68997] QA review for 68997

[bug#68997] QA review for 68997

[Andy Tai]

I just take a look of QA, it seems to pass but a downstream package
GNU smalltalk which uses ligntning fails to build.  That has always
failed to build for many years on x86-64 so not a new problem.

On Fri, Feb 9, 2024 at 9:35 AM Andy Tai <atai@atai.org> wrote:
>
> Thanks.  On my (Guix x86-64 machine), all tests did pass
>
> On Fri, Feb 9, 2024 at 7:29 AM Tanguy LE CARROUR <tanguy@bioneland.org> wrote:
>>
>> Hi Andy,
>>
>> Thanks for the patch.
>> For what it’s worth, it LGTM, but… it fails to pass the tests on my machine.
>> It’s still in WIP on QA, so… it could only be my machine.
>>
>> ```
>> ===============================================
>>    GNU lightning 2.2.3: check/test-suite.log
>> ===============================================
>>
>> # TOTAL: 135
>> # PASS:  133
>> # SKIP:  0
>> # XFAIL: 0
>> # FAIL:  2
>> # XPASS: 0
>> # ERROR: 0
>>
>>
>> .. contents:: :depth: 2
>>
>> FAIL: bit
>> =========
>>
>> 1d0
>> &lt; ok
>> FAIL bit (exit status: 1)
>>
>> FAIL: bit.nodata
>> ================
>>
>> 1d0
>> &lt; ok
>> FAIL bit.nodata (exit status: 1)
>> ```
>>
>> Regards
>>
>> --
>> Tanguy
>>
>> Items marked as checked: Commit messages
>
>
>
> --
> Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
> Year 2023 民國112年
> 自動的精神力是信仰與覺悟
> 自動的行為力是勞動與技能



-- 
Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2023 民國112年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能

[bug#68997] QA review for 68997

[Tanguy LE CARROUR]

Hi,


Quoting Andy Tai (2024-02-10 05:14:43)
> I just take a look of QA, it seems to pass but a downstream package
> GNU smalltalk which uses ligntning fails to build.  That has always
> failed to build for many years on x86-64 so not a new problem.

It does build on my computer at work! And CI looks OK, except for the
problem with smalltalk on x86_64 that you mentioned.

Tobias did the last update and commit for this package. This might be
the right person to ping if no committer picks up your patch.

Regards,

-- 
Tanguy

[bug#68997] [PATCH] gnu: lightning: Update to 2.2.3

[Andy Tai]

* gnu/packages/assembly.scm (lightning): Update to 2.2.3

Change-Id: Iddd550f1521b447acf4f119ddc9c2567a091427d
---
 gnu/packages/assembly.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/assembly.scm b/gnu/packages/assembly.scm
index 3bfe0bd3e0..9fcfba2f6c 100644
--- a/gnu/packages/assembly.scm
+++ b/gnu/packages/assembly.scm
@@ -196,14 +196,14 @@ (define-public yasm
 (define-public lightning
   (package
     (name "lightning")
-    (version "2.2.2")
+    (version "2.2.3")
     (source (origin
              (method url-fetch)
              (uri (string-append "mirror://gnu/lightning/lightning-"
                                  version ".tar.gz"))
              (sha256
               (base32
-               "1qmkfg7br543kqy82hhpr1n8bsm9wrwb1z5w2whxc5xdvr185jha"))))
+               "0ab89k0xn1mdgabrbfk2993jx6835i8glrhhn7zgpbq07aiwfif0"))))
     (build-system gnu-build-system)
     (native-inputs (list zlib))
     (arguments

base-commit: 570ef13a87bb54d3410c431700ba78316a2641e2
-- 
2.41.0

[bug#68997] QA review for 68997

[John Kehayias via Guix-patches via]

Hello,

On Mon, Feb 12, 2024 at 04:04 PM, Tanguy LE CARROUR wrote:

> Hi,
>
>
> Quoting Andy Tai (2024-02-10 05:14:43)
>> I just take a look of QA, it seems to pass but a downstream package
>> GNU smalltalk which uses ligntning fails to build.  That has always
>> failed to build for many years on x86-64 so not a new problem.
>

For smalltalk (on master, x86_64): I do see it failing on Berlin
(ci.guix.gnu.org) but there is a substitute from Bordeaux.

> It does build on my computer at work! And CI looks OK, except for the
> problem with smalltalk on x86_64 that you mentioned.
>

This patch for lightning builds for me locally as well. But smalltalk
then fails.

So it would be good to see why (fails tests) and if that can be fixed.
I'm not familiar at all with smalltalk so I didn't take a look, maybe
someone that knows the package can be CC'ed.

> Tobias did the last update and commit for this package. This might be
> the right person to ping if no committer picks up your patch.
>
> Regards,

John