[bug#70563] [PATCH] gnu: Add pkcs11-helper.

[bug#70563] [PATCH] gnu: Add pkcs11-helper.

[Andy Tai]

* gnu/packages/security-token.scm (pkcs11-helper): New variable.

Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
---
 gnu/packages/security-token.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 00a7f97582..5e20424001 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -394,6 +394,30 @@ (define-public opensc
 #15 standard and the PKCS #11 API.")
     (license license:lgpl2.1+)))
 
+
+(define-public pkcs11-helper
+  (package
+    (name "pkcs11-helper")
+    (version "1.30.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
+             version "/pkcs11-helper-" version ".tar.bz2"))
+       (sha256
+        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
+    (build-system gnu-build-system)
+    (inputs (list openssl-1.1 pcsc-lite))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/OpenSC/pkcs11-helper")
+    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
+    (description
+     "Pkcs11-helper is a library that simplifies the interaction with
+PKCS#11 providers for end-user applications")
+    (license (list license:gpl2 license:bsd-3))))
+
+
 (define-public yubico-piv-tool
   (package
     (name "yubico-piv-tool")

base-commit: 4514239971895fc7ad47c7752e30d98a0c44a154
-- 
2.41.0

[bug#70563] Acknowledgement ([PATCH] gnu: Add pkcs11-helper.)

[Andy Tai]

patch passed QA
https://qa.guix.gnu.org/issue/70563

[bug#70563]

[Andy Tai]

patch passed QA

https://qa.guix.gnu.org/issue/70563

[bug#70563] QA review for 70563

[Nicolas Graves via Guix-patches via]

user guix
usertag 70563 + reviewed-looks-good
thanks

Guix QA review form submission:
The description probably needs a little bit more precision. In particular, it would be good to include the statement "PKCS#11 is the de-facto standard to access cryptographic devices." or something like that. 

Otherwise LGTM.

Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests

-- 
Best regards,
Nicolas Graves

[bug#70563] QA review for 70563

[Ludovic Courtès]

Hi Andy,

Did you receive Nicolas’ message below?

Nicolas Graves <ngraves@ngraves.fr> skribis:

> user guix
> usertag 70563 + reviewed-looks-good
> thanks
>
> Guix QA review form submission:
> The description probably needs a little bit more precision. In particular, it would be good to include the statement &quot;PKCS#11 is the de-facto standard to access cryptographic devices.&quot; or something like that. 
>
> Otherwise LGTM.

Note that despite being marked as “reviewed-looks-good”, Nicolas makes
a suggestion that I think is worth addressing in a second version.

Thanks,
Ludo’.

[bug#70563] QA review for 70563

[Andy Tai]

OK I did not see that reply in email but I will send v2 patch
addressing the comment

On Mon, May 13, 2024 at 5:34 AM Ludovic Courtès <ludo@gnu.org> wrote:
>
> Hi Andy,
>
> Did you receive Nicolas’ message below?
>
> Nicolas Graves <ngraves@ngraves.fr> skribis:
>
> > user guix
> > usertag 70563 + reviewed-looks-good
> > thanks
> >
> > Guix QA review form submission:
> > The description probably needs a little bit more precision. In particular, it would be good to include the statement &quot;PKCS#11 is the de-facto standard to access cryptographic devices.&quot; or something like that.
> >
> > Otherwise LGTM.
>
> Note that despite being marked as “reviewed-looks-good”, Nicolas makes
> a suggestion that I think is worth addressing in a second version.
>
> Thanks,
> Ludo’.



-- 
Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2024 民國113年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能

[bug#70563] [PATCH v2] gnu: Add pkcs11-helper.

[Andy Tai]

* gnu/packages/security-token.scm (pkcs11-helper): New variable.

Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
---
 gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 35a8d4e216..78ddf5456b 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -394,6 +394,31 @@ (define-public opensc
 #15 standard and the PKCS #11 API.")
     (license license:lgpl2.1+)))
 
+
+(define-public pkcs11-helper
+  (package
+    (name "pkcs11-helper")
+    (version "1.30.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
+             version "/pkcs11-helper-" version ".tar.bz2"))
+       (sha256
+        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
+    (build-system gnu-build-system)
+    (inputs (list openssl-1.1 pcsc-lite))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/OpenSC/pkcs11-helper")
+    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
+    (description
+     "Pkcs11-helper is a library that simplifies the interaction with
+PKCS#11 providers for end-user applications. PKCS#11 is published standard.
+PKCS#11 is the de-facto standard to access cryptographic devices")
+    (license (list license:gpl2 license:bsd-3))))
+
+
 (define-public yubico-piv-tool
   (package
     (name "yubico-piv-tool")

base-commit: 5a624adfd7b14c3717237d137bd0766c77f0f570
-- 
2.41.0

[bug#70563] [PATCH v2] gnu: Add pkcs11-helper.

[Z572]

[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]

Andy Tai <atai@atai.org> writes:

> * gnu/packages/security-token.scm (pkcs11-helper): New variable.
>
> Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
> ---
>  gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
> index 35a8d4e216..78ddf5456b 100644
> --- a/gnu/packages/security-token.scm
> +++ b/gnu/packages/security-token.scm
> @@ -394,6 +394,31 @@ (define-public opensc
>  #15 standard and the PKCS #11 API.")
>      (license license:lgpl2.1+)))
>  
> +
> +(define-public pkcs11-helper
> +  (package
> +    (name "pkcs11-helper")
> +    (version "1.30.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
> +             version "/pkcs11-helper-" version ".tar.bz2"))
> +       (sha256
> +        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
> +    (build-system gnu-build-system)
> +    (inputs (list openssl-1.1 pcsc-lite))

Can this package use openssl-3.0? As i known, openssl 1.1 is EOL,
see https://www.openssl.org/blog/blog/2023/03/28/1.1.1-EOL/index.html.
It is best not to add more openssl-1.1 dependencies.  other LGTM.

> +    (native-inputs (list pkg-config))
> +    (home-page "https://github.com/OpenSC/pkcs11-helper")
> +    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
> +    (description
> +     "Pkcs11-helper is a library that simplifies the interaction with
> +PKCS#11 providers for end-user applications. PKCS#11 is published standard.
> +PKCS#11 is the de-facto standard to access cryptographic devices")
> +    (license (list license:gpl2 license:bsd-3))))
> +
> +
>  (define-public yubico-piv-tool
>    (package
>      (name "yubico-piv-tool")
>
> base-commit: 5a624adfd7b14c3717237d137bd0766c77f0f570

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#70563] [PATCH v2] gnu: Add pkcs11-helper.

[Andy Tai]

will check and possible update patch

[bug#70563] [PATCH v3] gnu: Add pkcs11-helper.

[Andy Tai]

* gnu/packages/security-token.scm (pkcs11-helper): New variable.

Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
---
 gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 35a8d4e216..939febd4e3 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -394,6 +394,31 @@ (define-public opensc
 #15 standard and the PKCS #11 API.")
     (license license:lgpl2.1+)))
 
+
+(define-public pkcs11-helper
+  (package
+    (name "pkcs11-helper")
+    (version "1.30.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
+             version "/pkcs11-helper-" version ".tar.bz2"))
+       (sha256
+        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
+    (build-system gnu-build-system)
+    (inputs (list openssl pcsc-lite))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/OpenSC/pkcs11-helper")
+    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
+    (description
+     "Pkcs11-helper is a library that simplifies the interaction with
+PKCS#11 providers for end-user applications. PKCS#11 is published standard.
+PKCS#11 is the de-facto standard to access cryptographic devices")
+    (license (list license:gpl2 license:bsd-3))))
+
+
 (define-public yubico-piv-tool
   (package
     (name "yubico-piv-tool")

base-commit: f1a573067c7157a30e8d5e5b3443fee7fcb8af42
-- 
2.34.1

bug#70563: [PATCH v3] gnu: Add pkcs11-helper.

[Zheng Junjie]

[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]

Andy Tai <atai@atai.org> writes:

> * gnu/packages/security-token.scm (pkcs11-helper): New variable.
>
> Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
> ---
>  gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
> index 35a8d4e216..939febd4e3 100644
> --- a/gnu/packages/security-token.scm
> +++ b/gnu/packages/security-token.scm
> @@ -394,6 +394,31 @@ (define-public opensc
>  #15 standard and the PKCS #11 API.")
>      (license license:lgpl2.1+)))
>  
> +
> +(define-public pkcs11-helper
> +  (package
> +    (name "pkcs11-helper")
> +    (version "1.30.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
> +             version "/pkcs11-helper-" version ".tar.bz2"))
> +       (sha256
> +        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
> +    (build-system gnu-build-system)
> +    (inputs (list openssl pcsc-lite))
> +    (native-inputs (list pkg-config))
> +    (home-page "https://github.com/OpenSC/pkcs11-helper")
> +    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
> +    (description
> +     "Pkcs11-helper is a library that simplifies the interaction with
> +PKCS#11 providers for end-user applications. PKCS#11 is published standard.
> +PKCS#11 is the de-facto standard to access cryptographic devices")
> +    (license (list license:gpl2 license:bsd-3))))
> +
> +
>  (define-public yubico-piv-tool
>    (package
>      (name "yubico-piv-tool")
>
> base-commit: f1a573067c7157a30e8d5e5b3443fee7fcb8af42

push, see https://git.savannah.gnu.org/cgit/guix.git/commit/?id=d4118a34e34554592a777000497f2c3d33fc6f5b

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]