From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id gNBoNwg8L2TFDAAASxT56A (envelope-from ) for ; Thu, 06 Apr 2023 23:39:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yKZzNgg8L2T6ZQAAG6o9tA (envelope-from ) for ; Thu, 06 Apr 2023 23:39:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0ECE889EA for ; Thu, 6 Apr 2023 23:39:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkXJx-00009W-GU; Thu, 06 Apr 2023 17:39:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkXJu-00009E-J3 for guix-patches@gnu.org; Thu, 06 Apr 2023 17:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkXJu-0004KZ-B6 for guix-patches@gnu.org; Thu, 06 Apr 2023 17:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkXJu-0008KK-3z for guix-patches@gnu.org; Thu, 06 Apr 2023 17:39:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#61586] [PATCH RFC 2/2] gnu: Add binaryen. Resent-From: "Thompson, David" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 Apr 2023 21:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61586 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 61586@debbugs.gnu.org Received: via spool by 61586-submit@debbugs.gnu.org id=B61586.168081712231980 (code B ref 61586); Thu, 06 Apr 2023 21:39:02 +0000 Received: (at 61586) by debbugs.gnu.org; 6 Apr 2023 21:38:42 +0000 Received: from localhost ([127.0.0.1]:55343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkXJa-0008Jk-1C for submit@debbugs.gnu.org; Thu, 06 Apr 2023 17:38:42 -0400 Received: from mail-qt1-f177.google.com ([209.85.160.177]:42788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkXJX-0008JV-HV for 61586@debbugs.gnu.org; Thu, 06 Apr 2023 17:38:40 -0400 Received: by mail-qt1-f177.google.com with SMTP id g19so39285219qts.9 for <61586@debbugs.gnu.org>; Thu, 06 Apr 2023 14:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; t=1680817114; x=1683409114; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oXjwFvlQtgL7Tax+xle6X80vEDRnKbQy2nVZtCZCNUA=; b=Jnh53iqkCA/2ByhOiO0D1FQjNBoiJ2wzA92WOWvvmJHAITUMDecdh4ENkLtqE8NBf8 h5AdGYeB3MLHX0lpy4gOHgwermGqX4UnV9dg4GKrntjhS8K59x7XT3m7Na0508aqHLm4 FFR7zRRWoBiQUgk1bzMPpKxGHRuBrF5LGhxhSij7EdidO5hPONU2Z46BlSnmVx1STHRu 5LQp23ppLotOklJlU59r51fIueH59y2cPYDGRmGH9EVUBX67lz4PoKoxo3GjWBRcborA pEg8HQMRhisDB6lBdeRKkUXR5dZV3hwSnAqnUythGKLdMPygt7YD8pPXCOQXRSaXiatC ryzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680817114; x=1683409114; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oXjwFvlQtgL7Tax+xle6X80vEDRnKbQy2nVZtCZCNUA=; b=0D9lNhObVfmBx1AwQvz8qq/87yycPUDXLJGJW/IO/f2itvfkVTU2HaTEec1BNeI3tA kzlFUdGeAgpQOj6Y3JPd0c6ai1M8HBBYT5z4A4AlKZd3NpJBcYZpVs5f+Dwp4d1JW5At eJpkSubkNkwsjsNCgbOPAoqK95vSAl/Ta1fVfkR2CnUqjTJ2k7Egtzkl9zm0cFp2PM34 C+vS5zgsZPFL/UQzPUxxW/LHfDINRf3JLZtbIGCLzOCUkq5qNkj2qrPbtJAhE6/GhU1G /6o/xuox1jqfvBNL0727bjRsIDZGaoY4aZji+3HzMS8IlwPRrUxS/hy9VPCmmDJ5bg27 mtgQ== X-Gm-Message-State: AAQBX9ci/f+2My/v+e0gd+nD7hnmWmSwUPOFz26YqGVAdNoZ+fzHYtsg Vt7NhsMgbxtf+UujPe6TXeMISPFJkQV2DntpHvF22g== X-Google-Smtp-Source: AKy350au5Ot52nQsACxbUy3VwvbkFWBdT05gbT4dYnF/P4ePAsQ3DILURDrtnj/7hvch6VfKH4rjhC+SooHIwY89pWs= X-Received: by 2002:ac8:5c0f:0:b0:3e6:71d6:5d42 with SMTP id i15-20020ac85c0f000000b003e671d65d42mr111432qti.1.1680817113820; Thu, 06 Apr 2023 14:38:33 -0700 (PDT) MIME-Version: 1.0 References: <2cc4a1091e54c0fec082de4ce2789dfc42470e54.camel@gmail.com> <5be345282b038321a7f3c1f5fb2df8560ceb653c.camel@gmail.com> In-Reply-To: <5be345282b038321a7f3c1f5fb2df8560ceb653c.camel@gmail.com> From: "Thompson, David" Date: Thu, 6 Apr 2023 17:38:23 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680817160; a=rsa-sha256; cv=none; b=IGEvZvFUcGTeX3OS+RJs7+Ox2+i0qttwIMVXocVWFLl8xK0M51CTszhJN2D6j9Oxx2potY MsMqha0QPVTFDxa+Gdjq6W/wTjXjmvKFFlOIookeM0M8M50ERZ6wgbHUqciu2MaPFsV94l Kt/yzIhnugp9PAlqyNzfMOj/u3N3QR+BV0KOxN9wpxD1+6fRfVSwjJmc/PqiNaZFccXTUP hKpM9gv9ETJbjM+BVeJqo0gZHXplMI48znEDi1/d+vL8vbPxGouWW0j04x9kbKjOkhS2+/ PHaP6uByXhgDg83eWUnCi+OCrnIlXOwraYa1eN950TbcyrDHd5TTo8oiV9xO0g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=Jnh53iqk; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680817160; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oXjwFvlQtgL7Tax+xle6X80vEDRnKbQy2nVZtCZCNUA=; b=rJH7MpAVFoWVjUidxMNck8OZOsOHgQKhrHsmZN/WuRHKjnq9HKU2Fy2tKt3mqSmj6PBIsS nYeOsGkXKfmBarGEH6pYkbINGoWQFmq/P27gXl/m4DZ1ghgA/nbJTaXZP48WCjcxi4mryd BW8myOtJQi6a+VD1igD/IXFvpC95mp1k5IEGwWJDl6fQ5lNz4chssBByPullUxzKr2Oa+3 XqZydDQXOMA/tvL3tkvqZ2XPmL+jgjNemQ64IvZwsPuTCnXcXHl5h7JGdCyAApB/C8hs3S 6obEmD5I8Ka2ADdQRm3Wut7XFY9obyXwzpz6rzeNY9yCjwTimTLD5oFcTSuBFA== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=Jnh53iqk; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.12 X-Spam-Score: -3.12 X-Migadu-Queue-Id: 0ECE889EA X-TUID: 5KKX/YLoSNTU Hi Liliana, On Fri, Feb 17, 2023 at 6:00=E2=80=AFPM Liliana Marie Prikler wrote: > > * gnu/packages/web.scm (binaryen): New variable. > --- > gnu/packages/web.scm | 45 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm > index 7e49f798ea..0b509fa34c 100644 > --- a/gnu/packages/web.scm > +++ b/gnu/packages/web.scm > @@ -1558,6 +1558,51 @@ (define-public wabt > other systems that want to manipulate WebAssembly files.") > (license license:asl2.0))) > > +(define-public binaryen > + (package > + (name "binaryen") > + (version "112") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/WebAssembly/binaryen") > + (commit (string-append "version_" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0970iz22yjxgi27d67kwmrx4zq7hig3i6b92vmlp4c4bd1bacny5")) > + (modules '((guix build utils))) > + (snippet #~(begin > + (substitute* "CMakeLists.txt" > + (("add_subdirectory\\(third_party\\)") > + "find_package(GTest)")) > + (substitute* "test/gtest/CMakeLists.txt" > + (("include_directory\\(.*third_pary.*\\)") ""= )) > + (delete-file-recursively "third_party"))))) > + (build-system cmake-build-system) > + (arguments > + (list #:out-of-source? #f ; for tests > + #:configure-flags #~(list "-DBUILD_LLVM_DWARF=3DOFF") > + #:phases > + #~(modify-phases %standard-phases > + (add-before 'check 'delete-failing-tests > + (lambda _ > + ;; DWARF support relies on bundling LLVM, so don't > + (for-each delete-file > + (find-files "test/passes" > + ".*dwarf.*\\.(bin\\.txt\|wasm)")= ) > + (delete-file "test/unit/test_dwarf.py"))) > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (invoke "python" "check.py")))))) > + (native-inputs (list googletest node-lts python-wrapper > + python-lit python-filecheck)) > + (home-page "https://github.com/WebAssembly/binaryen") > + (synopsis "WebAssembly compiler") > + (description "Binaryen is a compiler and toolchain infrastructure lib= rary > +written in C++, with a single-header C API as well as a Javascript API."= ) > + (license license:asl2.0))) > + > (define-public wasm3 > (package > (name "wasm3") > -- > 2.39.1 This looks good to me! We are currently using a hackier package recipe with tests disabled in the Guile Hoot (Guile -> WASM compiler) project: https://gitlab.com/spritely/guile-hoot-updates/-/blob/main/example= s/manifest.scm#L18 Nice job getting the tests working! - Dave