unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Thompson, David" <dthompson2@worcester.edu>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Cc: 30380@debbugs.gnu.org
Subject: [bug#30380] gnu: Add dolphin-emulator.
Date: Wed, 7 Feb 2018 15:53:03 -0500	[thread overview]
Message-ID: <CAJ=RwfbOySqzLGMqiSVa7PKw1+5E2967Q-e_g8TV4fdwyQB=bQ@mail.gmail.com> (raw)
In-Reply-To: <20180207214353.36366a2c@alma-ubu>

Hello,

On Wed, Feb 7, 2018 at 3:43 PM, Björn Höfling
<bjoern.hoefling@bjoernhoefling.de> wrote:
> On Wed, 7 Feb 2018 11:58:02 -0500
> "Thompson, David" <dthompson2@worcester.edu> wrote:
>
>> Here a couple of patches that add the Dolphin emulator.  I used a Git
>> snapshot because the project goes *years* between releasing official
>> source tarballs while at the same time directing users to use binaries
>> built from the latest commit in their Git repo, so I think packaging
>> the Git source aligns best with what a Dolphin user would expect.
>>
>> - Dave
>
> Hi Dave,
>
> I haven't done a full review, here are some things I noticed:
>
> * License is GPLv2+, not only v2.
> * dolphin/Data/Sys/GC/font_*.bin: Licensed under ASL2.0.
> * The homepage states this package is only available for x86_64.
>   If that is true, add a line like this to your package:
>   (supported-systems '("x86_64-linux"))
> * dolphin/Installer/dxredist/ contains (Windows) binaries. Remove with
>   a snippet.
> * Remove dolphin/Externals in a snippet. Or at least those that you
>   have added as dependencies.
> * There are binaries in the distribution:
>   dolphin/Data/Sys/GC/dsp_coef.bin and dsp_rom.bin
>   The commit message says something like "based off of observed
> effects on the virtual machine", but still this is binaray. Or is there
>   some way of building this from commented assembly? Here is the full
>   commit message:
>   https://github.com/dolphin-emu/dolphin/commit/e3531d17d700339828d7bab192c66fba5fcbac86
>
> * Finally, doesn't this encourage people to use non-free software, i.e.
>   the original manufacturers game discs? Or is there any free software
>   implementation running on this emulator?
>
> Björn

Nevermind. I am dropping this patch set.

Sorry,

- Dave

  reply	other threads:[~2018-02-07 20:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 16:58 [bug#30380] gnu: Add dolphin-emulator Thompson, David
2018-02-07 20:43 ` Björn Höfling
2018-02-07 20:53   ` Thompson, David [this message]
2018-02-09 10:21     ` Ludovic Courtès
2018-02-09 14:11       ` Thompson, David
2018-02-09 15:52         ` Manolis Ragkousis
2018-02-09 16:10           ` Thompson, David
2018-02-16  9:20 ` [bug#30380] gnu: Add dolphin-emu Rutger Helling
2018-02-20 22:52   ` Björn Höfling
2018-02-21  9:48     ` Rutger Helling
2018-02-21 15:19       ` Marius Bakke
2018-02-21 15:55         ` Rutger Helling
2018-02-21 16:37     ` Leo Famulari
2018-02-21 21:55       ` Björn Höfling
2018-02-22  8:46         ` bug#30380: " Rutger Helling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ=RwfbOySqzLGMqiSVa7PKw1+5E2967Q-e_g8TV4fdwyQB=bQ@mail.gmail.com' \
    --to=dthompson2@worcester.edu \
    --cc=30380@debbugs.gnu.org \
    --cc=bjoern.hoefling@bjoernhoefling.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).