From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wBtENXfuwWNzMwEAbAwnHQ (envelope-from ) for ; Sat, 14 Jan 2023 00:51:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0BM3NXfuwWO77wAA9RJhRA (envelope-from ) for ; Sat, 14 Jan 2023 00:51:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1D22CEE48 for ; Sat, 14 Jan 2023 00:51:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGTpC-0004Kv-6c; Fri, 13 Jan 2023 18:51:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGTp9-0004KC-6K for guix-patches@gnu.org; Fri, 13 Jan 2023 18:51:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGTp8-0005EU-Rp for guix-patches@gnu.org; Fri, 13 Jan 2023 18:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pGTp8-0000Wk-JM for guix-patches@gnu.org; Fri, 13 Jan 2023 18:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60791] [PATCH] gnu: services: Add joycond-service. Resent-From: "Thompson, David" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 13 Jan 2023 23:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60791 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: mirai@makinata.eu Cc: 60791@debbugs.gnu.org Received: via spool by 60791-submit@debbugs.gnu.org id=B60791.16736538491994 (code B ref 60791); Fri, 13 Jan 2023 23:51:02 +0000 Received: (at 60791) by debbugs.gnu.org; 13 Jan 2023 23:50:49 +0000 Received: from localhost ([127.0.0.1]:52746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGTou-0000W5-Op for submit@debbugs.gnu.org; Fri, 13 Jan 2023 18:50:49 -0500 Received: from mail-qk1-f180.google.com ([209.85.222.180]:41641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGTos-0000Vk-4R for 60791@debbugs.gnu.org; Fri, 13 Jan 2023 18:50:46 -0500 Received: by mail-qk1-f180.google.com with SMTP id h8so11617917qkk.8 for <60791@debbugs.gnu.org>; Fri, 13 Jan 2023 15:50:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6quylZXyD80zfkRpdEfxUSw3iSQH/9Cw8cm0lsiVM6w=; b=Xuhzrd0dRd2MSu2zvcC72x5XsqHMRg0IVIH7fTOkmA0W2SaNDLna/oKuI+/q0G5IBQ KIGxQKueECkXZ1fC0bIab7/rQJqy9bFJBCid3qwRjb9s/jTq4TIl32O0wUMwwvG7Xk+Z bCrAEvRhcmDSzQMmR7UzC1fpXjRnm4SHxE3maDDjr1BvTNzVQWcx8cAQfBI587Ni8/V4 rBYQMdKRtwufcCMkfinWpUHKRQ924AAEQUlERMFgpu00F3i3xpQf3xlICmUY01Lmkswr //YR+jb857R+2B3Gs/50jnRhqbLuytUl+7LPFwY2ZfelpIBS3t7SsyG5cIqxyDtmZ+GX GfaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6quylZXyD80zfkRpdEfxUSw3iSQH/9Cw8cm0lsiVM6w=; b=J/wlIg/rkHrArxfLWM8uYvYbjCHM4+8elJgQEAL3uteausQ9Iiz6ifpFVph5wDSdoW q1ZLRs/jMkOl6mNKsBTCWUeoZuOuBqgNOvOkQ8Bxgm6sI3JLElLs8JXSlDw2HOFHDGyV JG1WbfMLi6wmnvchTAl3o/O1sZ3B5CFrzGkP+aCebcVYWVJdshE51SO9FGt/P4b7130l Y9VF9GXMo99NXpD2KfCrStR+zNy9J9OvADDhX7nFmLHjO7yIkvEfWPq5JKzy96Ctivhm QevnqgWTD6E38m9V4fc/Wfy9SzSXgPq7KeoFYpbnpo2QB111pbmKs8NGqnqF4DY2bVW1 rw+A== X-Gm-Message-State: AFqh2kpvsWBtIit0/Xh8k27ZEQJlTkxByTgLSsbuhXC3KLzDU7i56ssj VhxttWN1jx5w/FgKkohNDS9US2W8sm8AzRVOJBdF0A== X-Google-Smtp-Source: AMrXdXtOtXTa0cLUi57+UwWyT44LBCL/fr8OwmKvzDpa/ECtK1yhBZ+iGmyGjQEFQlimQbRzDp1QhNwbhm6yPfNWKSY= X-Received: by 2002:a05:620a:21c2:b0:6fe:d745:5ee8 with SMTP id h2-20020a05620a21c200b006fed7455ee8mr5509480qka.387.1673653840410; Fri, 13 Jan 2023 15:50:40 -0800 (PST) MIME-Version: 1.0 References: <5eaac013-2a20-c322-24a9-ab389ec974c5@makinata.eu> In-Reply-To: <5eaac013-2a20-c322-24a9-ab389ec974c5@makinata.eu> From: "Thompson, David" Date: Fri, 13 Jan 2023 18:50:28 -0500 Message-ID: Content-Type: multipart/mixed; boundary="000000000000a31e7c05f22de62b" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673653879; a=rsa-sha256; cv=none; b=jydRvqbzAKZ4qf7sk+c3P5lNYfaS5FqlrYiaOko0tV10ar6rKSYCBuYHIyOhiYUBRsubQX ka5kd0xu5Bfl2OJ+28P244LhHdDdbPRc74FjS63ywu3tC51QtP/ysfhJRXTldvP+0UnS39 YsqZdTlT0j8LALi2R+Qj1la8OoVS7e2NL9/mSpKPtOC35APHMNKRSAREzOCkagWuTZ/dc9 qMBJzjPdvYdhLRESGCwXsO4hZJPQqGFct1kit9PqqwiXI1Y6eO5iXNkVSvljkq0lo0nHnt c9WcvzaGJN4tTB6NqJtz3O/JlnvOeXmwfmlOmOvUEsh8QWD60PEnm1ndCKHgWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=Xuhzrd0d; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673653879; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=6quylZXyD80zfkRpdEfxUSw3iSQH/9Cw8cm0lsiVM6w=; b=KKLP75Y94uhHRu+olBmZ8uYOw4r83WehmLPIHP/TxfMWEskT10ldazy/ergmybAJQ22S11 2jZwz0xerTu6ZFGBS301Y2gakBt8spIfIyDhWQOCRoNofejXhjJE+RR/1dtzkUjpPkiape G4O33EA16Poi4i4qbAS3PEpfi/cylqECpkygiyx5BJHB8ZbXiacB5KW0cRhNResELL0ahv 3fPKK4XJi7JnhFy6rHmHyqzyqOKlhEYg6JHl6SFJ51pCN2bUMqINy/LuXW7RUcJITCZ5gM J6FAGGiLYwGXqQl8srTCg3gbE5/Zqc65MzvPu+3JqHQBEfCqQbFU6NrzCMbiWg== X-Migadu-Spam-Score: -0.50 X-Spam-Score: -0.50 X-Migadu-Queue-Id: 1D22CEE48 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=Xuhzrd0d; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: xBDhb0ofx399 --000000000000a31e7c05f22de62b Content-Type: text/plain; charset="UTF-8" Hi Bruno, Thanks for the review! On Fri, Jan 13, 2023 at 5:46 PM Bruno Victal wrote: > > Hi, > > --8<---------------cut here---------------start------------->8--- > +@defvar {Scheme Variable} joycond-service-type > +Service type for the joycond service. > +@end defvar > --8<---------------cut here---------------end--------------->8--- > > Should be `@defvar joycond-service-type'. Oh, okay. Guess I missed that change in convention. There's lots of '@defvar {Scheme Variable}' in the manual. > --8<---------------cut here---------------start------------->8--- > +(define-record-type* > + joycond-configuration make-joycond-configuration > + joycond-configuration? > + (joycond joycond-configuration-joycond (default joycond))) > --8<---------------cut here---------------end--------------->8--- > > This could be replaced with define-configuration/no-serialization since > the only field here is a package / file-like object. (see [1], [2] for examples) > I'd prefer the field be called 'package' here. Ahhhh unhygienic macros! Not a fan but I see that this macro is the preferred thing these days so okay, changed! I also prefer the field to be called 'package' so I've changed it! When I looked around at some other services they used the package name as the field name so I followed their lead. > --8<---------------cut here---------------start------------->8--- > +(define (joycond-shepherd-service config) > + (let ((joycond (joycond-configuration-joycond config))) > + (list (shepherd-service > + (documentation "Run joycond.") > + (provision '(joycond)) > + (requirement '(bluetooth)) > + (start #~(make-forkexec-constructor > + (list #$(file-append joycond "/bin/joycond")))) > + (stop #~(make-kill-destructor)))))) > --8<---------------cut here---------------end--------------->8--- > > You might prefer match-record here but this is okay as well. If I was destructuring many record fields I'd use it. Updated patch attached. Thanks! - Dave --000000000000a31e7c05f22de62b Content-Type: application/x-patch; name="0001-gnu-services-Add-joycond-service.patch" Content-Disposition: attachment; filename="0001-gnu-services-Add-joycond-service.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lcv66odt0 RnJvbSBlOTg3YjU1YmQyYWFmZWQ1MjM3OWEwZDE3ZTMzZGU4OGI1MWY0YWQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBUaG9tcHNvbiA8ZHRob21wc29uMkB3b3JjZXN0ZXIu ZWR1PgpEYXRlOiBGcmksIDEzIEphbiAyMDIzIDE3OjA0OjIxIC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gZ251OiBzZXJ2aWNlczogQWRkIGpveWNvbmQtc2VydmljZS4KCiogZ251L3NlcnZpY2VzL2dh bWVzLnNjbSAoPGpveWNvbmQtY29uZmlndXJhdGlvbj4pOiBOZXcgcmVjb3JkIHR5cGUuCihqb3lj b25kLWNvbmZpZ3VyYXRpb24sIGpveWNvbmQtY29uZmlndXJhdGlvbj8sIGpveWNvbmQtY29uZmln dXJhdGlvbi1qb3ljb25kLApqb3ljb25kLXNoZXBoZXJkLXNlcnZpY2UpOiBOZXcgcHJvY2VkdXJl cy4KKGpveWNvbmQtc2VydmljZS10eXBlKTogTmV3IHZhcmlhYmxlLgoqIGRvYy9ndWl4LnRleGkg KEdhbWUgU2VydmljZXMpOiBEb2N1bWVudCBpdC4KLS0tCiBkb2MvZ3VpeC50ZXhpICAgICAgICAg IHwgMTkgKysrKysrKysrKysrKysrKysrKwogZ251L3NlcnZpY2VzL2dhbWVzLnNjbSB8IDM3ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgNTUg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RvYy9ndWl4LnRleGkg Yi9kb2MvZ3VpeC50ZXhpCmluZGV4IDc1MWQwOTU3ZDguLmZmZTg3ZjJlNzUgMTAwNjQ0Ci0tLSBh L2RvYy9ndWl4LnRleGkKKysrIGIvZG9jL2d1aXgudGV4aQpAQCAtMzYyNzcsNiArMzYyNzcsMjUg QEAgbGlrZSB0byBzZXJ2ZS4KIEBub2RlIEdhbWUgU2VydmljZXMKIEBzdWJzZWN0aW9uIEdhbWUg U2VydmljZXMKIAorQHN1YnN1YmhlYWRpbmcgSm95Y29uZCBzZXJ2aWNlCitAY2luZGV4IGpveWNv bmQKK1RoZSBqb3ljb25kIHNlcnZpY2UgYWxsb3dzIHRoZSBwYWlyaW5nIG9mIE5pbnRlbmRvIGpv eWNvbiBnYW1lCitjb250cm9sbGVycyBvdmVyIEJsdWV0b290aC4gKEBweHJlZntEZXNrdG9wIFNl cnZpY2VzfSBmb3Igc2V0dGluZyB1cAorQmx1ZXRvb3RoLikKKworQGRlZnRwIHtEYXRhIFR5cGV9 IGpveWNvbmQtY29uZmlndXJhdGlvbgorRGF0YSB0eXBlIHJlcHJlc2VudGluZyB0aGUgY29uZmln dXJhdGlvbiBvZiBAY29tbWFuZHtqb3ljb25kfS4KKworQHRhYmxlIEBhc2lzCitAaXRlbSBAY29k ZXtqb3ljb25kfSAoZGVmYXVsdDogQGNvZGV7am95Y29uZH0pCitUaGUgam95Y29uZCBwYWNrYWdl IHRvIHVzZS4KK0BlbmQgdGFibGUKK0BlbmQgZGVmdHAKKworQGRlZnZhciBqb3ljb25kLXNlcnZp Y2UtdHlwZQorU2VydmljZSB0eXBlIGZvciB0aGUgam95Y29uZCBzZXJ2aWNlLgorQGVuZCBkZWZ2 YXIKKwogQHN1YnN1YmhlYWRpbmcgVGhlIEJhdHRsZSBmb3IgV2Vzbm90aCBTZXJ2aWNlCiBAY2lu ZGV4IHdlc25vdGhkCiBAdXJlZntodHRwczovL3dlc25vdGgub3JnLCBUaGUgQmF0dGxlIGZvciBX ZXNub3RofSBpcyBhIGZhbnRhc3ksIHR1cm4KZGlmZiAtLWdpdCBhL2dudS9zZXJ2aWNlcy9nYW1l cy5zY20gYi9nbnUvc2VydmljZXMvZ2FtZXMuc2NtCmluZGV4IDZjMmFmNDRiNDkuLmU5MjViMjFj YjQgMTAwNjQ0Ci0tLSBhL2dudS9zZXJ2aWNlcy9nYW1lcy5zY20KKysrIGIvZ251L3NlcnZpY2Vz L2dhbWVzLnNjbQpAQCAtMTksNiArMTksNyBAQAogCiAoZGVmaW5lLW1vZHVsZSAoZ251IHNlcnZp Y2VzIGdhbWVzKQogICAjOnVzZS1tb2R1bGUgKGdudSBzZXJ2aWNlcykKKyAgIzp1c2UtbW9kdWxl IChnbnUgc2VydmljZXMgY29uZmlndXJhdGlvbikKICAgIzp1c2UtbW9kdWxlIChnbnUgc2Vydmlj ZXMgc2hlcGhlcmQpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGFkbWluKQogICAjOnVz ZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBnYW1lcykKQEAgLTI4LDEyICsyOSw0NiBAQCAoZGVmaW5l LW1vZHVsZSAoZ251IHNlcnZpY2VzIGdhbWVzKQogICAjOmF1dG9sb2FkICAgKGd1aXggbGVhc3Qt YXV0aG9yaXR5KSAobGVhc3QtYXV0aG9yaXR5LXdyYXBwZXIpCiAgICM6dXNlLW1vZHVsZSAoZ3Vp eCBnZXhwKQogICAjOnVzZS1tb2R1bGUgKGd1aXggbW9kdWxlcykKKyAgIzp1c2UtbW9kdWxlIChn dWl4IHBhY2thZ2VzKQogICAjOnVzZS1tb2R1bGUgKGd1aXggcmVjb3JkcykKICAgIzp1c2UtbW9k dWxlIChpY2UtOSBtYXRjaCkKLSAgIzpleHBvcnQgKHdlc25vdGhkLWNvbmZpZ3VyYXRpb24KKyAg IzpleHBvcnQgKGpveWNvbmQtY29uZmlndXJhdGlvbgorICAgICAgICAgICAgam95Y29uZC1jb25m aWd1cmF0aW9uPworICAgICAgICAgICAgam95Y29uZC1jb25maWd1cmF0aW9uLWpveWNvbmQKKyAg ICAgICAgICAgIGpveWNvbmQtc2VydmljZS10eXBlCisKKyAgICAgICAgICAgIHdlc25vdGhkLWNv bmZpZ3VyYXRpb24KICAgICAgICAgICAgIHdlc25vdGhkLWNvbmZpZ3VyYXRpb24/CiAgICAgICAg ICAgICB3ZXNub3RoZC1zZXJ2aWNlLXR5cGUpKQogCis7OzsKKzs7OyBKb3ljb25kCis7OzsKKwor KGRlZmluZS1jb25maWd1cmF0aW9uL25vLXNlcmlhbGl6YXRpb24gam95Y29uZC1jb25maWd1cmF0 aW9uCisgIChwYWNrYWdlIChwYWNrYWdlIGpveWNvbmQpICJUaGUgam95Y29uZCBwYWNrYWdlIHRv IHVzZSIpKQorCisoZGVmaW5lIChqb3ljb25kLXNoZXBoZXJkLXNlcnZpY2UgY29uZmlnKQorICAo bGV0ICgoam95Y29uZCAoam95Y29uZC1jb25maWd1cmF0aW9uLXBhY2thZ2UgY29uZmlnKSkpCisg ICAgKGxpc3QgKHNoZXBoZXJkLXNlcnZpY2UKKyAgICAgICAgICAgKGRvY3VtZW50YXRpb24gIlJ1 biBqb3ljb25kLiIpCisgICAgICAgICAgIChwcm92aXNpb24gJyhqb3ljb25kKSkKKyAgICAgICAg ICAgKHJlcXVpcmVtZW50ICcoYmx1ZXRvb3RoKSkKKyAgICAgICAgICAgKHN0YXJ0ICN+KG1ha2Ut Zm9ya2V4ZWMtY29uc3RydWN0b3IKKyAgICAgICAgICAgICAgICAgICAgIChsaXN0ICMkKGZpbGUt YXBwZW5kIGpveWNvbmQgIi9iaW4vam95Y29uZCIpKSkpCisgICAgICAgICAgIChzdG9wICN+KG1h a2Uta2lsbC1kZXN0cnVjdG9yKSkpKSkpCisKKyhkZWZpbmUgam95Y29uZC1zZXJ2aWNlLXR5cGUK KyAgKHNlcnZpY2UtdHlwZQorICAgKG5hbWUgJ2pveWNvbmQpCisgICAoZGVzY3JpcHRpb24KKyAg ICAiUnVuIEBjb21tYW5ke2pveWNvbmR9IGZvciBwYWlyaW5nIE5pbnRlbmRvIGpveWNvbnMgdmlh IEJsdWV0b290aC4iKQorICAgKGV4dGVuc2lvbnMKKyAgICAobGlzdCAoc2VydmljZS1leHRlbnNp b24gc2hlcGhlcmQtcm9vdC1zZXJ2aWNlLXR5cGUKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgam95Y29uZC1zaGVwaGVyZC1zZXJ2aWNlKSkpCisgICAoZGVmYXVsdC12YWx1ZSAoam95Y29u ZC1jb25maWd1cmF0aW9uKSkpKQorCisMCiA7OzsKIDs7OyBUaGUgQmF0dGxlIGZvciBXZXNub3Ro IHNlcnZlcgogOzs7Ci0tIAoyLjM4LjEKCg== --000000000000a31e7c05f22de62b--