From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAhLF-0006i0-Oz for guix-patches@gnu.org; Tue, 16 May 2017 14:37:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAhLC-00044e-Ky for guix-patches@gnu.org; Tue, 16 May 2017 14:37:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46344) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dAhLC-00044Y-FM for guix-patches@gnu.org; Tue, 16 May 2017 14:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dAhLB-0007Gh-R7 for guix-patches@gnu.org; Tue, 16 May 2017 14:37:01 -0400 Subject: bug#26401: [PATCH] python-tryton (with no modules) Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: References: <285e9165.AEMAKF1MYlQAAAAAAAAAAAO8YckAAAACwQwAAAAAAAW9WABZEIIR@mailjet.com> From: Catonano Date: Tue, 16 May 2017 20:36:22 +0200 Message-ID: Content-Type: multipart/alternative; boundary="f403045c283ed19668054fa87277" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 26401@debbugs.gnu.org --f403045c283ed19668054fa87277 Content-Type: text/plain; charset="UTF-8" 2017-05-16 19:12 GMT+02:00 Arun Isaac : > > Sure! > > tryton, and tryton related packages (especially the server side modules, > GNU Health, etc.) are numerous and complicated enough to deserve their > own separate file. You can put them in gnu/packages/tryton.scm. > Note taken. I will. For all practical purposes, I think it's best to assume that there is no > python3 genshi package. Instead, we should simply package > python2-genshi, and let the authors fix their python3 package. In any > case, tryton needs only python2-genshi. So, there is no urgent need for > the python3 genshi package. I guess, this also means that there will be > no python3 relatorio package. > I'm afraid you're right. Sigh. I devolved way too much effort in packaging Genshi :-/ > >> > + (arguments > >> > + `(#:phases > >> > + (modify-phases %standard-phases > >> > + (add-before 'check 'preparations > >> > + (lambda* _ > > Since you're not using any of `lambda*' features, you can just use > `lambda' here. > note taken Actually, this is not a big deal. We'll leave it as it is. If necessary, > I'll fix it before pushing. > Thanks > > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > > index 57a67de41..f1ef53e1a 100644 > > --- a/gnu/packages/python.scm > > +++ b/gnu/packages/python.scm > > @@ -14622,3 +14622,25 @@ substitute for redis.") > > > > (define-public python2-fakeredis > > (package-with-python2 python-fakeredis)) > > + > > +(define-public python-sql > > + (package > > + (name "python-sql") > > + (version "0.8") > > + (source > > + (origin > > + (method url-fetch) > > ... > > > + (uri (pypi-uri > > + "python-sql" > > + version)) > > Could you put these on the same line? > [...] > > + (propagated-inputs > > + `(("lxml" ,python2-lxml) > > + ("genshi" ,python2-genshi))) > > Use full names here, including the python version in the package name. I > mean the full name of "lxml" is "python2-lxml", not "python-lxml". Make > similar changes wherever applicable. > Ouch ! I owe you an apology, here I mistakenly sent you the same patch file as before I'm sorry :-/ > > Also, in several places, there was a typo saying "pyton" instead of > "python". Please fix those. > Gosh. My keyboard si defective. I've been pleading with my technician for months now. I try to pay attention but more errors slip than I'd like Sorry :-/ > > > * gnu/packages/python.scm (python-trytond, python2-trytond): New > variables. > > Change this commit message replacing python-trytond with trytond as > discussed earlier. Make a similar change for the commit message > involving python-tryton (the client). > Give me me some time to mourn my Genshi package. I will send a new series (really, this time) soonish Thanks --f403045c283ed19668054fa87277 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2017-05-16 19:12 GMT+02:00 Arun Isaac <arunisaac@systemreboot= .net>:
Sure!

tryton, and tryton related packages (especially the server side modules, GNU Health, etc.) are numerous and complicated enough to deserve their
own separate file. You can put them in gnu/packages/tryton.scm.

Note taken. I will.

For all practical purposes, I think it's best to assume that the= re is no
python3 genshi package. Instead, we should simply package
python2-genshi, and let the authors fix their python3 package. In any
case, tryton needs only python2-genshi. So, there is no urgent need for
the python3 genshi package. I guess, this also means that there will be
no python3 relatorio package.

I'm a= fraid you're right.
Sigh. I devolved way too much effort= in packaging Genshi :-/
=C2=A0


>> > +=C2=A0 =C2=A0 (arguments
>> > +=C2=A0 =C2=A0 =C2=A0`(#:phases
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0(modify-phases %standard-phases >> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(add-before 'check = 9;preparations
>> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(lambda* _

Since you're not using any of `lambda*' features, you can ju= st use `lambda' here.

note taken=C2=A0
=C2=A0

Actually, this is not a big deal. We'll leave i= t as it is. If necessary,
I'll fix it before pushing.

Thanks<= br>=C2=A0

> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 57a67de41..f1ef53e1a 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -14622,3 +14622,25 @@ substitute for redis.")
>
>=C2=A0 (define-public python2-fakeredis
>=C2=A0 =C2=A0 (package-with-python2 python-fakeredis))
> +
> +(define-public python-sql
> +=C2=A0 (package
> +=C2=A0 =C2=A0 (name "python-sql")
> +=C2=A0 =C2=A0 (version "0.8")
> +=C2=A0 =C2=A0 (source
> +=C2=A0 =C2=A0 =C2=A0(origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(method url-fetch)

...

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (pypi-uri
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"python-sql"= ;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0version))

Could you put these on the same line?

[...]=


> +=C2=A0 =C2=A0 (propagated-inputs
> +=C2=A0 =C2=A0 =C2=A0`(("lxml" ,python2-lxml)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("genshi" ,python2-genshi)))

Use full names here, including the python version in the package nam= e. I
mean the full name of "lxml" is "python2-lxml", not &qu= ot;python-lxml". Make
similar changes wherever applicable.

Ouch ! <= br>I owe you an apology, here

I mistakenly sent you the s= ame patch file as before

I'm sorry :-/

= =C2=A0

Also, in several places, there was a typo saying "pyton" instead = of
"python". Please fix those.

G= osh.
My keyboard si defective. I've been pleading with my technicia= n for months now.
I try to pay attention but more errors slip= than I'd like
Sorry :-/
=C2=A0

> * gnu/packages/python.scm (python-trytond, python2-trytond): New v= ariables.

Change this commit message replacing python-trytond with trytond as
discussed earlier. Make a similar change for the commit message
involving python-tryton (the client).

Give me me some tim= e to mourn my Genshi package.
I will se= nd a new series (really, this time) soonish

Thanks
--f403045c283ed19668054fa87277--