* bug#25836: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell [not found] ` <alpine.DEB.2.11.1703261253200.2667@intel.home> @ 2017-03-27 8:26 ` Ludovic Courtès 2017-05-03 16:49 ` Catonano 0 siblings, 1 reply; 12+ messages in thread From: Ludovic Courtès @ 2017-03-27 8:26 UTC (permalink / raw) To: Kevin Atkinson; +Cc: 25836, aspell-devel Hi Kevin, From your reply it seems the second part of my message got lost; you can see it at <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25836#14>. Kevin Atkinson <kevina@gnu.org> skribis: > It would be better to change the compiled in defaults. I believe > the --enable-dict-dir configure option should change the default for dict-dir. The problem is that dict-dir is typically “$HOME/.guix-profile/lib/aspell”, so we can’t choose it at configure time (unless Aspell expands “$HOME”?). Even if we did, we’d like to offer users the ability to choose dictionaries located in a different place. How would you achieve that? Thanks for your reply, Ludo’. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25836: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell 2017-03-27 8:26 ` bug#25836: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell Ludovic Courtès @ 2017-05-03 16:49 ` Catonano 2017-05-03 18:14 ` Kevin Atkinson 0 siblings, 1 reply; 12+ messages in thread From: Catonano @ 2017-05-03 16:49 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 25836, Kevin Atkinson, aspell-devel [-- Attachment #1: Type: text/plain, Size: 840 bytes --] 2017-03-27 10:26 GMT+02:00 Ludovic Courtès <ludo@gnu.org>: > Hi Kevin, > > From your reply it seems the second part of my message got lost; you can > see it at <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25836#14>. > > Kevin Atkinson <kevina@gnu.org> skribis: > > > It would be better to change the compiled in defaults. I believe > > the --enable-dict-dir configure option should change the default for > dict-dir. > > The problem is that dict-dir is typically > “$HOME/.guix-profile/lib/aspell”, so we can’t choose it at configure > time (unless Aspell expands “$HOME”?). > > Even if we did, we’d like to offer users the ability to choose > dictionaries located in a different place. > > How would you achieve that? > > Thanks for your reply, > Ludo’. > ehm, are there any news on this ? [-- Attachment #2: Type: text/html, Size: 1388 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25836: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell 2017-05-03 16:49 ` Catonano @ 2017-05-03 18:14 ` Kevin Atkinson 2017-05-17 14:21 ` Ludovic Courtès 0 siblings, 1 reply; 12+ messages in thread From: Kevin Atkinson @ 2017-05-03 18:14 UTC (permalink / raw) To: Catonano, Ludovic Courtès; +Cc: 25836, aspell-devel [-- Attachment #1: Type: text/plain, Size: 1799 bytes --] Sorry, For compiled in defaults there is some support for expansion, see Config::get_default() in common/config.cpp. In particular the following should work: "<$HOME|.>/.guix-profile/lib/aspell. Due to the way the code is written an alternative must always be given, in particular "<$HOME>/.guix-profile/lib/aspell" is unlikely to work. You could also use: "<home-dir>/.guix-profile/lib/aspell". Note that the expansion is only for compiled in defaults, if the value is manually set, then there is no expansion. When you do "aspell --config" it will print the defaults and then also what it expands to. On 05/03/2017 12:49 PM, Catonano wrote: > 2017-03-27 10:26 GMT+02:00 Ludovic Courtès <ludo@gnu.org > <mailto:ludo@gnu.org>>: > > Hi Kevin, > > From your reply it seems the second part of my message got lost; > you can > see it at <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25836#14 > <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25836#14>>. > > Kevin Atkinson <kevina@gnu.org <mailto:kevina@gnu.org>> skribis: > > > It would be better to change the compiled in defaults. I believe > > the --enable-dict-dir configure option should change the default > for dict-dir. > > The problem is that dict-dir is typically > “$HOME/.guix-profile/lib/aspell”, so we can’t choose it at configure > time (unless Aspell expands “$HOME”?). > > Even if we did, we’d like to offer users the ability to choose > dictionaries located in a different place. > > How would you achieve that? > > Thanks for your reply, > Ludo’. > > > > ehm, are there any news on this ? > > > _______________________________________________ > Aspell-devel mailing list > Aspell-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/aspell-devel [-- Attachment #2: Type: text/html, Size: 3588 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25836: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell 2017-05-03 18:14 ` Kevin Atkinson @ 2017-05-17 14:21 ` Ludovic Courtès 2017-05-17 18:14 ` Kevin Atkinson 0 siblings, 1 reply; 12+ messages in thread From: Ludovic Courtès @ 2017-05-17 14:21 UTC (permalink / raw) To: Kevin Atkinson; +Cc: 25836, aspell-devel Hi Kevin, Kevin Atkinson <kevina@gnu.org> skribis: > For compiled in defaults there is some support for expansion, see > Config::get_default() in common/config.cpp. In particular the > following should work: "<$HOME|.>/.guix-profile/lib/aspell. Due to the > way the code is written an alternative must always be given, in > particular "<$HOME>/.guix-profile/lib/aspell" is unlikely to work. > You could also use: "<home-dir>/.guix-profile/lib/aspell". Note that > the expansion is only for compiled in defaults, if the value is > manually set, then there is no expansion. > > When you do "aspell --config" it will print the defaults and then also > what it expands to. Thanks for the tips. I ended up using something similar to what you suggest: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6d35b1c99c15f87a30fdf1a38c88db844b3e8303 Ludo’. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25836: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell 2017-05-17 14:21 ` Ludovic Courtès @ 2017-05-17 18:14 ` Kevin Atkinson 0 siblings, 0 replies; 12+ messages in thread From: Kevin Atkinson @ 2017-05-17 18:14 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 25836, aspell-devel On Wed, 17 May 2017 16:21:40 +0200 ludo@gnu.org (Ludovic Courtès) wrote: > Hi Kevin, > > Kevin Atkinson <kevina@gnu.org> skribis: > > > For compiled in defaults there is some support for expansion, see > > Config::get_default() in common/config.cpp. In particular the > > following should work: "<$HOME|.>/.guix-profile/lib/aspell. Due to > > the way the code is written an alternative must always be given, in > > particular "<$HOME>/.guix-profile/lib/aspell" is unlikely to work. > > You could also use: "<home-dir>/.guix-profile/lib/aspell". Note > > that the expansion is only for compiled in defaults, if the value is > > manually set, then there is no expansion. > > > > When you do "aspell --config" it will print the defaults and then > > also what it expands to. > > Thanks for the tips. I ended up using something similar to what you > suggest: > > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6d35b1c99c15f87a30fdf1a38c88db844b3e8303 If you tested it both with $ASPELL_DICT_DIR defined and without then it looks good. Kevin ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25836: [PATCH] gnu: Add gspell [not found] ` <87wpbx9z7b.fsf@gnu.org> [not found] ` <87vaqwp2l8.fsf_-_@gnu.org> @ 2017-03-30 11:57 ` Thomas Danckaert 2017-03-30 12:08 ` Catonano 2017-05-17 14:24 ` Ludovic Courtès 1 sibling, 2 replies; 12+ messages in thread From: Thomas Danckaert @ 2017-03-30 11:57 UTC (permalink / raw) To: 25836 ludo@gnu.org (Ludovic Courtès) writes: > Thanks for the patch. I’ve modified the package like this: > > [...] > (inputs > `(("enchant" ,enchant) > ("iso-codes" ,iso-codes) > ("gtk+" ,gtk+) > ("glib" ,glib))) > (native-inputs > `(("glib" ,glib "bin") > ("pkg-config" ,pkg-config) > ("xmllint" ,libxml2) > > ;; For tests. > ("xorg-server" ,xorg-server) > ("aspell-dict-en" ,aspell-dict-en))) Just for reference, for when we solve the dictionary issue: While experimenting with this package and (unsuccessfully) trying to get it to find aspell dictionaries, I also noticed we could add the following native inputs: + ("docbook-xsl" ,docbook-xsl) + ("gobject-introspection" ,gobject-introspection) + ("gtk-doc" ,gtk-doc) + ("vala" ,vala) ("glib" ,glib "bin") ("pkg-config" ,pkg-config) ("xmllint" ,libxml2) ("xorg-server" ,xorg-server))) and the following configure flag to build docs: + #:configure-flags '("--enable-gtk-doc") I'm not really familiar with the gobject system, but I suppose generating the bindings is useful? :) Thomas ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25836: [PATCH] gnu: Add gspell 2017-03-30 11:57 ` bug#25836: [PATCH] gnu: Add gspell Thomas Danckaert @ 2017-03-30 12:08 ` Catonano 2017-05-17 14:24 ` Ludovic Courtès 1 sibling, 0 replies; 12+ messages in thread From: Catonano @ 2017-03-30 12:08 UTC (permalink / raw) To: Thomas Danckaert; +Cc: 25836 [-- Attachment #1: Type: text/plain, Size: 1570 bytes --] I believe it's worthwhile to make this known to the guix reviewers community https://lists.gnu.org/archive/html/aspell-devel/2017-03/msg00003.html Hope this helps Ciao ! :-) 2017-03-30 13:57 GMT+02:00 Thomas Danckaert <post@thomasdanckaert.be>: > ludo@gnu.org (Ludovic Courtès) writes: > > > Thanks for the patch. I’ve modified the package like this: > > > > [...] > > (inputs > > `(("enchant" ,enchant) > > ("iso-codes" ,iso-codes) > > ("gtk+" ,gtk+) > > ("glib" ,glib))) > > (native-inputs > > `(("glib" ,glib "bin") > > ("pkg-config" ,pkg-config) > > ("xmllint" ,libxml2) > > > > ;; For tests. > > ("xorg-server" ,xorg-server) > > ("aspell-dict-en" ,aspell-dict-en))) > > Just for reference, for when we solve the dictionary issue: > > While experimenting with this package and (unsuccessfully) trying to get > it to find aspell dictionaries, I also noticed we could add the > following native inputs: > > + ("docbook-xsl" ,docbook-xsl) > + ("gobject-introspection" ,gobject-introspection) > + ("gtk-doc" ,gtk-doc) > + ("vala" ,vala) > ("glib" ,glib "bin") > ("pkg-config" ,pkg-config) > ("xmllint" ,libxml2) > ("xorg-server" ,xorg-server))) > > and the following configure flag to build docs: > > + #:configure-flags '("--enable-gtk-doc") > > I'm not really familiar with the gobject system, but I suppose > generating the bindings is useful? :) > > Thomas > > > > [-- Attachment #2: Type: text/html, Size: 2582 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25836: [PATCH] gnu: Add gspell 2017-03-30 11:57 ` bug#25836: [PATCH] gnu: Add gspell Thomas Danckaert 2017-03-30 12:08 ` Catonano @ 2017-05-17 14:24 ` Ludovic Courtès 2017-05-17 15:16 ` Thomas Danckaert 2017-05-17 17:22 ` Catonano 1 sibling, 2 replies; 12+ messages in thread From: Ludovic Courtès @ 2017-05-17 14:24 UTC (permalink / raw) To: Thomas Danckaert, Catonano; +Cc: 25836-done Hi, I just pushed gspell as 411ba511893feca223656122059cb12378b95c91, finally! \o/ Thomas Danckaert <post@thomasdanckaert.be> skribis: > Just for reference, for when we solve the dictionary issue: > > While experimenting with this package and (unsuccessfully) trying to get > it to find aspell dictionaries, I also noticed we could add the > following native inputs: > > + ("docbook-xsl" ,docbook-xsl) > + ("gobject-introspection" ,gobject-introspection) > + ("gtk-doc" ,gtk-doc) > + ("vala" ,vala) > ("glib" ,glib "bin") > ("pkg-config" ,pkg-config) > ("xmllint" ,libxml2) > ("xorg-server" ,xorg-server))) > > and the following configure flag to build docs: > > + #:configure-flags '("--enable-gtk-doc") > > I'm not really familiar with the gobject system, but I suppose > generating the bindings is useful? :) For now we don’t have any users of gspell at all, let alone users of its Vala bindings, so perhaps we can leave it as is? Building the docs to a separate “doc” output could be marginally useful, I think. WDYT? Thanks, Ludo’. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25836: [PATCH] gnu: Add gspell 2017-05-17 14:24 ` Ludovic Courtès @ 2017-05-17 15:16 ` Thomas Danckaert 2017-05-17 19:56 ` Ludovic Courtès 2017-05-17 17:22 ` Catonano 1 sibling, 1 reply; 12+ messages in thread From: Thomas Danckaert @ 2017-05-17 15:16 UTC (permalink / raw) To: ludo; +Cc: 25836 From: ludo@gnu.org (Ludovic Courtès) Subject: Re: bug#25836: [PATCH] gnu: Add gspell Date: Wed, 17 May 2017 16:24:18 +0200 >> I'm not really familiar with the gobject system, but I suppose >> generating the bindings is useful? :) > > For now we don’t have any users of gspell at all, let alone users > of its > Vala bindings, so perhaps we can leave it as is? > > Building the docs to a separate “doc” output could be marginally > useful, > I think. For me, it's me as it is. I have no use for those bindings or the documentation myself. I just stumbled upon them while trying to debug the package, and thought I'd mention it just in case. When I submit a package, I usually try to enable as many options as I can, even though I don't use them myself, just in case someone might need them. Maybe this is overkill? Is there a general recommendation for Guix? Thomas ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25836: [PATCH] gnu: Add gspell 2017-05-17 15:16 ` Thomas Danckaert @ 2017-05-17 19:56 ` Ludovic Courtès 0 siblings, 0 replies; 12+ messages in thread From: Ludovic Courtès @ 2017-05-17 19:56 UTC (permalink / raw) To: Thomas Danckaert; +Cc: 25836 Thomas Danckaert <post@thomasdanckaert.be> skribis: > From: ludo@gnu.org (Ludovic Courtès) > Subject: Re: bug#25836: [PATCH] gnu: Add gspell > Date: Wed, 17 May 2017 16:24:18 +0200 > >>> I'm not really familiar with the gobject system, but I suppose >>> generating the bindings is useful? :) >> >> For now we don’t have any users of gspell at all, let alone users of >> its >> Vala bindings, so perhaps we can leave it as is? >> >> Building the docs to a separate “doc” output could be marginally >> useful, >> I think. > > For me, it's me as it is. Hi! Is it you? :-) > I have no use for those bindings or the documentation myself. I just > stumbled upon them while trying to debug the package, and thought I'd > mention it just in case. > > When I submit a package, I usually try to enable as many options as I > can, even though I don't use them myself, just in case someone might > need them. Maybe this is overkill? Is there a general recommendation > for Guix? It depends! The recommendation is to check what ‘guix size’ says and weigh the usefulness/size ratio of the added dependency: https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html Ludo’. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25836: [PATCH] gnu: Add gspell 2017-05-17 14:24 ` Ludovic Courtès 2017-05-17 15:16 ` Thomas Danckaert @ 2017-05-17 17:22 ` Catonano 2017-05-17 17:24 ` Catonano 1 sibling, 1 reply; 12+ messages in thread From: Catonano @ 2017-05-17 17:22 UTC (permalink / raw) To: Ludovic Courtès; +Cc: Thomas Danckaert, 25836-done [-- Attachment #1: Type: text/plain, Size: 1399 bytes --] 2017-05-17 16:24 GMT+02:00 Ludovic Courtès <ludo@gnu.org>: > Hi, > > I just pushed gspell as 411ba511893feca223656122059cb12378b95c91, > finally! \o/ > > Thomas Danckaert <post@thomasdanckaert.be> skribis: > > > Just for reference, for when we solve the dictionary issue: > > > > While experimenting with this package and (unsuccessfully) trying to get > > it to find aspell dictionaries, I also noticed we could add the > > following native inputs: > > > > + ("docbook-xsl" ,docbook-xsl) > > + ("gobject-introspection" ,gobject-introspection) > > + ("gtk-doc" ,gtk-doc) > > + ("vala" ,vala) > > ("glib" ,glib "bin") > > ("pkg-config" ,pkg-config) > > ("xmllint" ,libxml2) > > ("xorg-server" ,xorg-server))) > > > > and the following configure flag to build docs: > > > > + #:configure-flags '("--enable-gtk-doc") > > > > I'm not really familiar with the gobject system, but I suppose > > generating the bindings is useful? :) > > For now we don’t have any users of gspell at all, let alone users of its > Vala bindings, so perhaps we can leave it as is? > Originally, I wanted gspell because I understood that it's a dependency of Polari, the Gnome chat client. Once this aspell path thing is solved, should any bindings be necessary for Polari, they could be added later, couldn't they ? [-- Attachment #2: Type: text/html, Size: 2104 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25836: [PATCH] gnu: Add gspell 2017-05-17 17:22 ` Catonano @ 2017-05-17 17:24 ` Catonano 0 siblings, 0 replies; 12+ messages in thread From: Catonano @ 2017-05-17 17:24 UTC (permalink / raw) To: Ludovic Courtès; +Cc: Thomas Danckaert, 25836-done [-- Attachment #1: Type: text/plain, Size: 1560 bytes --] 2017-05-17 19:22 GMT+02:00 Catonano <catonano@gmail.com>: > > > 2017-05-17 16:24 GMT+02:00 Ludovic Courtès <ludo@gnu.org>: > >> Hi, >> >> I just pushed gspell as 411ba511893feca223656122059cb12378b95c91, >> finally! \o/ >> >> Thomas Danckaert <post@thomasdanckaert.be> skribis: >> >> > Just for reference, for when we solve the dictionary issue: >> > >> > While experimenting with this package and (unsuccessfully) trying to get >> > it to find aspell dictionaries, I also noticed we could add the >> > following native inputs: >> > >> > + ("docbook-xsl" ,docbook-xsl) >> > + ("gobject-introspection" ,gobject-introspection) >> > + ("gtk-doc" ,gtk-doc) >> > + ("vala" ,vala) >> > ("glib" ,glib "bin") >> > ("pkg-config" ,pkg-config) >> > ("xmllint" ,libxml2) >> > ("xorg-server" ,xorg-server))) >> > >> > and the following configure flag to build docs: >> > >> > + #:configure-flags '("--enable-gtk-doc") >> > >> > I'm not really familiar with the gobject system, but I suppose >> > generating the bindings is useful? :) >> >> For now we don’t have any users of gspell at all, let alone users of its >> Vala bindings, so perhaps we can leave it as is? >> > > Originally, I wanted gspell because I understood that it's a dependency of > Polari, the Gnome chat client. > > Once this aspell path thing is solved, should any bindings be necessary > for Polari, they could be added later, couldn't they ? > > > Thank you so much or this, Ludo ! 🤗 [-- Attachment #2: Type: text/html, Size: 2556 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-05-17 19:58 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <CAJ98PDyRmcJEZTC6dOuuwXeH+j6ZtwYnMmtmD-0bj9N9yWfZMg@mail.gmail.com> [not found] ` <87wpbx9z7b.fsf@gnu.org> [not found] ` <87vaqwp2l8.fsf_-_@gnu.org> [not found] ` <alpine.DEB.2.11.1703261253200.2667@intel.home> 2017-03-27 8:26 ` bug#25836: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell Ludovic Courtès 2017-05-03 16:49 ` Catonano 2017-05-03 18:14 ` Kevin Atkinson 2017-05-17 14:21 ` Ludovic Courtès 2017-05-17 18:14 ` Kevin Atkinson 2017-03-30 11:57 ` bug#25836: [PATCH] gnu: Add gspell Thomas Danckaert 2017-03-30 12:08 ` Catonano 2017-05-17 14:24 ` Ludovic Courtès 2017-05-17 15:16 ` Thomas Danckaert 2017-05-17 19:56 ` Ludovic Courtès 2017-05-17 17:22 ` Catonano 2017-05-17 17:24 ` Catonano
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).