unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 38678@debbugs.gnu.org
Subject: [bug#38678] Command line option in addition to GUIX_PACKAGE_PATH - Reason?
Date: Fri, 17 Jan 2020 19:14:15 +0100	[thread overview]
Message-ID: <CAJ3okZ3xqX=E8=i9Yhw01HYzx5Ry8irLOT2z=j2ryonnoL=h4Q@mail.gmail.com> (raw)
In-Reply-To: <87y2u6yqat.fsf@ambrevar.xyz>

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

What mess did you do Pierre? :-)

Why are you the author of ee9a735bc8 [1]?
Why there are lines modified in guix.texi 21f4fbdd84 [2] which are not
in the original patch [3]?

[1] https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ee9a735bc8f544cf8eedc6c6a7e4ed2962663013
[2] https://git.savannah.gnu.org/cgit/guix.git/commit/?id=21f4fbdd8453e489fb89825c4226a0a0bda2bc17
[3] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38678#65

Or why I have missed?

Attached the change fix your early push of the 'refresh' patch. :-)

Cheers,
simon

[-- Attachment #2: 0001-refresh-Fix-internal-variable-name.patch --]
[-- Type: text/x-patch, Size: 1602 bytes --]

From 8dfcf205f023b609117f3da9007e830df406357b Mon Sep 17 00:00:00 2001
From: zimoun <zimon.toutoune@gmail.com>
Date: Fri, 17 Jan 2020 18:30:00 +0100
Subject: [PATCH 1/1] refresh: Fix internal variable name.

* guix/scripts/refresh.scm (%option): Fix internal variable name.
---
 guix/scripts/refresh.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index bc8e906054..efada1df5a 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -120,16 +120,16 @@
 
         ;; The short option -L is already used by --list-updaters, therefore
         ;; it needs to be removed from %standard-build-options.
-        (let ((%load-path-option (find (lambda (option)
+        (let ((load-path-option (find (lambda (option)
                                          (member "load-path"
                                                  (option-names option)))
                                        %standard-build-options)))
           (option
            (filter (lambda (name) (not (equal? #\L name)))
-                   (option-names %load-path-option))
-           (option-required-arg? %load-path-option)
-           (option-optional-arg? %load-path-option)
-           (option-processor     %load-path-option)))
+                   (option-names load-path-option))
+           (option-required-arg? load-path-option)
+           (option-optional-arg? load-path-option)
+           (option-processor     load-path-option)))
 
         (option '(#\h "help") #f #f
                 (lambda args
-- 
2.23.0


  reply	other threads:[~2020-01-17 18:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87pnglj2ka.fsf@ambrevar.xyz>
     [not found] ` <CAJ3okZ3X5DZ3DVDXY5_WHEOzL01=nJGkJeBHZxL-1eLS3x8c8g@mail.gmail.com>
     [not found]   ` <87sglgsiey.fsf@lassieur.org>
     [not found]     ` <878sn8inru.fsf@ambrevar.xyz>
     [not found]       ` <87o8w4mewg.fsf@gnu.org>
     [not found]         ` <87tv5wfdrm.fsf@ambrevar.xyz>
     [not found]           ` <CAJ3okZ0_5AB57FgNyagAA-KCOW=o7AgDrr4v5p8n4XvEmJH7=g@mail.gmail.com>
     [not found]             ` <87lfr8fd9u.fsf@ambrevar.xyz>
     [not found]               ` <20191226213108.753f8ab7@scratchpost.org>
     [not found]                 ` <CAJ3okZ2HSh_WbiWEz65-A_LZLgN91Dc-rAQe_7PbA09YQid64Q@mail.gmail.com>
     [not found]                   ` <87blr3eao0.fsf@ambrevar.xyz>
     [not found]                     ` <CAJ3okZ3G5YteTpMJdsfUHHp=LrzZ593OrZAaupk=x7bp3CZ-3Q@mail.gmail.com>
     [not found]                       ` <87ftge13h5.fsf@ambrevar.xyz>
2020-01-17 16:19                         ` [bug#38678] Command line option in addition to GUIX_PACKAGE_PATH - Reason? zimoun
2020-01-17 16:56                           ` Pierre Neidhardt
2020-01-17 18:14                             ` zimoun [this message]
2020-01-17 18:38                               ` Pierre Neidhardt
2020-01-18 12:01                               ` Pierre Neidhardt
2020-01-18 12:09                                 ` Pierre Neidhardt
2020-01-20 16:21                                 ` zimoun
2020-01-20 18:12                                   ` Pierre Neidhardt
2020-01-20 18:35                                     ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ3okZ3xqX=E8=i9Yhw01HYzx5Ry8irLOT2z=j2ryonnoL=h4Q@mail.gmail.com' \
    --to=zimon.toutoune@gmail.com \
    --cc=38678@debbugs.gnu.org \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).