From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eGaRHFX6QWHLtQAAgWs5BA (envelope-from ) for ; Wed, 15 Sep 2021 15:51:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iI4XGFX6QWEYaAAAbx9fmQ (envelope-from ) for ; Wed, 15 Sep 2021 13:51:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9144417FA for ; Wed, 15 Sep 2021 15:51:16 +0200 (CEST) Received: from localhost ([::1]:33776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQVJj-0000ua-Ik for larch@yhetil.org; Wed, 15 Sep 2021 09:51:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQVJV-0000fJ-W7 for guix-patches@gnu.org; Wed, 15 Sep 2021 09:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQVJV-0004DF-Nr for guix-patches@gnu.org; Wed, 15 Sep 2021 09:51:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQVJV-0004lr-JM for guix-patches@gnu.org; Wed, 15 Sep 2021 09:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50588] [PATCH] import: cabal: Treat identifier names correctly. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 Sep 2021 13:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50588 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 50588@debbugs.gnu.org Received: via spool by 50588-submit@debbugs.gnu.org id=B50588.163171380618267 (code B ref 50588); Wed, 15 Sep 2021 13:51:01 +0000 Received: (at 50588) by debbugs.gnu.org; 15 Sep 2021 13:50:06 +0000 Received: from localhost ([127.0.0.1]:51318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQVIZ-0004kX-Uq for submit@debbugs.gnu.org; Wed, 15 Sep 2021 09:50:06 -0400 Received: from mail-qk1-f170.google.com ([209.85.222.170]:38451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQVIJ-0004jd-K3 for 50588@debbugs.gnu.org; Wed, 15 Sep 2021 09:50:02 -0400 Received: by mail-qk1-f170.google.com with SMTP id f22so3450468qkm.5 for <50588@debbugs.gnu.org>; Wed, 15 Sep 2021 06:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XWiUQxxJg4R65Sn2UHaFIP3ToSLCs1Ik0jo0cWNWsYE=; b=M669HPU7RIMOfDl9X0ce5AdVpp6TfsbuRuzwO7LEc8A7jRrGJQnBcq6QF732uoQ+eI 7pZSNJ5gES8lqcvPbHV0lnEYHW4Z4w6jmVYLcHFZaSF5lL7qp5yRzIiUnsQPOudFMRLK 4b0LMrle+C/OvsYV0ipLqt2dG10lE2mLfCxAVnzJWnZSVXJjsbS/jWtTFkeVTjvwHNZJ CcWGxT82BFxnsCiLv+B6zvidfk8i3WNSGjcz+UokpBp3n55qQ18Wmgxpm4bBnC6BX80v OOYGLVP6f0V8WRe18vjMrZ7N9+rz0DbmYb/HEjI+WMGFXEdYcoXFenVVqS7lflJxNfnw mngQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XWiUQxxJg4R65Sn2UHaFIP3ToSLCs1Ik0jo0cWNWsYE=; b=PrnxM64Q2S7fQ//AasXSuVZ21Li/22/KnDDI9nF1MTAHZfbjFhsqI4KHp1/5q4MlAz /hvvocPwl6JXT9KFpiPIRZuaRY0u4BJUdY1/VqdfvW4V/DBPAZWSqex9SFQ+K5OdBPEE 9iSDsH/u28zh8VM+mJ2SN3BX+F/05ireT2uXC0ne2/YbMn/gls6IMgUrjqYsdG3hwdMx HG+ogWf5iWr7aa8FwuKRICYQkGr37J0BxE9yf7NqF8LbfE7SFOzTa4x+CVzSbYPXgu3x XhckVg5PLvitNt7xvWzDkbM8+qcwQGfe2dijApHkW3kU2HBGzOhY1ygXnYWXoZ62Qxj5 kcNg== X-Gm-Message-State: AOAM533CDa5LOw3GmJVF8L7oMpIU1SVDzk4WtdL4pEaXUtmD48mSrH+r X6xvI3i0ikImcYd5wMBEFy2VqeY7yE9sGLqhNZ9QPZvCUU0+4A== X-Google-Smtp-Source: ABdhPJydXl4fvs3dzjN59QdPirVa5BEgwCCAfalJSnZrtQ8vTthUr5ILOSbgKcxS43wZ/Kfap3HNobUC9NiNNDfCVQM= X-Received: by 2002:a05:620a:1035:: with SMTP id a21mr16453qkk.422.1631713781870; Wed, 15 Sep 2021 06:49:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: zimoun Date: Wed, 15 Sep 2021 09:55:57 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631713876; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XWiUQxxJg4R65Sn2UHaFIP3ToSLCs1Ik0jo0cWNWsYE=; b=nPQuQ2ITaaaE8ONEB1E98hBEwuu2+PriosidFv3vt3lFGE+c7oQppnA4tS0jLD5lrEuOX+ ExTB21pbBAWJ8jxD5genB0v1VgBpdfFeQ8xG4DR4iXSQz0EMFQIr8fKM3Bvqj07p1FtdXX q5SpuWdCuhQvIXp8wi2RFfa8IbQyhW/QkbfnR1XinQyz00V0y9IZI3O62ZCEHjpGECG1Uf djx1ieOWGXK6Al1TFFqR4Pln3jZh/VOqh+IgddbzysrXpyIJTmgX7/gnpAbrOl7kbX/rj3 yPsQJzP1yCRoXxSeKWy0pa5Z4CBnHEwiQhopWwjiH3i5PvSEk5ASdtnSptAsCg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631713876; a=rsa-sha256; cv=none; b=UHWg18ReCLoRr7u4WDRlPDAe6ogXx/xD+RKvgjeio/NaNqDa7eLGyqGb333aTP2wLod7C1 Tmk70zj11WNSJxDm/lB7Mh5bUrg3ld/nQ0DwaCld9tTcWPSBXkizqihRMglLifiYMU+NGB wBvuCHUxRBZDD3JAM6ZqC7syotHerq6LUhIbOOtw5AjF1PN4w5rIscQf0dddSikI9zz4LY IwVZgwcKbkZtDz7LbJs72CykANNlmLk2M9eNuo8j4LQcVIaknJ0np5OxNZg7TqwtysvaKg 40b3OMJccXvL5o3n9a6Szakg4DhKE55LufL2VT7pfrbXgNxgWXfav05baLUFfA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=M669HPU7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=M669HPU7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9144417FA X-Spam-Score: 0.20 X-Migadu-Scanner: scn1.migadu.com X-TUID: UY87KN0d5AE1 Hi, On Tue, 14 Sept 2021 at 20:43, Xinglu Chen wrote: > * guix/import/cabal.scm (is-id): Accept the location as an argument. Don= =E2=80=99t > check if the identifier name is a reserved keyword unless it is the first= word > on the line. > (lex-word): Adjust accordingly. > * tests/hackage ("hackage->guix-package tests flag executable"): Expect i= t to > pass. > > Fixes: Oh awesome! Thanks! Yesterday, I was reviewing old bugs and dig the cabal parser was too intimidating. :-) Cheers, simon