From: zimoun <zimon.toutoune@gmail.com>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 50588@debbugs.gnu.org
Subject: [bug#50588] [PATCH] import: cabal: Treat identifier names correctly.
Date: Wed, 15 Sep 2021 09:55:57 +0200 [thread overview]
Message-ID: <CAJ3okZ3QfQe8OZLgZEe7LN9XAWQV10aokmSnHxNtFXhL-TncBA@mail.gmail.com> (raw)
In-Reply-To: <e59de83e96791b6c861dab2946ffc09ab988927b.1631644779.git.public@yoctocell.xyz>
Hi,
On Tue, 14 Sept 2021 at 20:43, Xinglu Chen <public@yoctocell.xyz> wrote:
> * guix/import/cabal.scm (is-id): Accept the location as an argument. Don’t
> check if the identifier name is a reserved keyword unless it is the first word
> on the line.
> (lex-word): Adjust accordingly.
> * tests/hackage ("hackage->guix-package tests flag executable"): Expect it to
> pass.
>
> Fixes: <https://issues.guix.gnu.org/25138>
Oh awesome! Thanks! Yesterday, I was reviewing old bugs and dig the
cabal parser was too intimidating. :-)
Cheers,
simon
next prev parent reply other threads:[~2021-09-15 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 18:42 [bug#50588] [PATCH] import: cabal: Treat identifier names correctly Xinglu Chen
2021-09-15 7:55 ` zimoun [this message]
2021-09-15 12:32 ` bug#50588: " Lars-Dominik Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3okZ3QfQe8OZLgZEe7LN9XAWQV10aokmSnHxNtFXhL-TncBA@mail.gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=50588@debbugs.gnu.org \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).