From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2BC6JdO2gmEavgAAgWs5BA (envelope-from ) for ; Wed, 03 Nov 2021 17:20:35 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qKxmIdO2gmH1BQAAB5/wlQ (envelope-from ) for ; Wed, 03 Nov 2021 16:20:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 33D621D166 for ; Wed, 3 Nov 2021 17:20:35 +0100 (CET) Received: from localhost ([::1]:49274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miJ06-0005ar-6Z for larch@yhetil.org; Wed, 03 Nov 2021 12:20:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miIzb-0005Zr-CP for guix-patches@gnu.org; Wed, 03 Nov 2021 12:20:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miIza-00053O-Tc for guix-patches@gnu.org; Wed, 03 Nov 2021 12:20:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miIza-0005vi-I0 for guix-patches@gnu.org; Wed, 03 Nov 2021 12:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47754] [PATCH] gnu: transformations: fix with-latest option for git source package. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Nov 2021 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47754 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Z572 <873216071@qq.com> Cc: 47754@debbugs.gnu.org Received: via spool by 47754-submit@debbugs.gnu.org id=B47754.163595634322706 (code B ref 47754); Wed, 03 Nov 2021 16:20:02 +0000 Received: (at 47754) by debbugs.gnu.org; 3 Nov 2021 16:19:03 +0000 Received: from localhost ([127.0.0.1]:40977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miIyc-0005uA-RQ for submit@debbugs.gnu.org; Wed, 03 Nov 2021 12:19:03 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:40539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miIyX-0005tV-BM for 47754@debbugs.gnu.org; Wed, 03 Nov 2021 12:19:01 -0400 Received: by mail-qk1-f173.google.com with SMTP id ay20so2812238qkb.7 for <47754@debbugs.gnu.org>; Wed, 03 Nov 2021 09:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u9wQCXREZ4q5bcG2UlrBFoSRMQmJeOgpLrp84sxg5SY=; b=ghG4bdlNEG6TgCu4f0klAdUmTwh249I2eyvZCMkPK5tOsa5uY6pPuiLeQgsDXm9RPg EZY0r2QYe8km94WxsJooKK4FvSdkAhd3YTiCU/U6XvRqWGNI3jIxCxfG6JJearQEnf6J SNYyKLO6jqQ74KlJavkEnOhCXeAGNqFS/qqDq+0vglpf2pBpCj+5e3oLexH9/yWi0Qvq XuTI31ughwue0JBzmrI5eqNVHRxMS26PpOWxL5cPMUZlKcKAhj4EYG8siRqR/s6HJXyZ oD1ykLbICBXr5b8cjkeQPtn/E8QxKy8i9WrIH+YxNsu1LaHh96vX0CXuY1rhbEb9tYGD 0Gcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u9wQCXREZ4q5bcG2UlrBFoSRMQmJeOgpLrp84sxg5SY=; b=vnBc8k8+Sd/JxmPRUgy8Z70sWx9ILrjiAYBOkGwnFJgu0qhoUVpQ+N3rDYPup6o8JZ 6aKvoR/P3CVSFQ2K8T7A355X468fuSpBRFNluAsq8LQHEnispsbWTqELAYoY1wu1qv/g uIUB340h6+sPoxJXge/yP6G3PzT4LqhLbbHtq8Mmt83Tw5xDdg8bJSQPw0NtKU6bcOvO 7c6jtArIgll70sPxJdXC2PL4sxE6r9hpSFAh7WufrmePkXoiFbvGFAcDBo+1dawDklHu CYLZYZZnK7TrFQDw3fjjjP1SEIPxmk258ru2PUrpCutOenrE4ju3nCXE0S07pwa4Kigo tbMg== X-Gm-Message-State: AOAM532LRW+GhXDSCXcoglLmc5nI9NAfm231j9rLCkOcOclcjdsr0dod LyVW2xjzy8AhXxguN5km64jffjbWNTcwa6f3H4A= X-Google-Smtp-Source: ABdhPJyZDn+/O2NftG8sEKy+uO/2zd2Fw6zqq1GiGNynDvGrkOF7m9/06nWp5xFoC8/PYOn8NflqppUvIV3KcdnVKF4= X-Received: by 2002:a05:620a:843:: with SMTP id u3mr12892013qku.463.1635956331772; Wed, 03 Nov 2021 09:18:51 -0700 (PDT) MIME-Version: 1.0 References: <87y265sfsr.fsf@gmail.com> In-Reply-To: From: zimoun Date: Wed, 3 Nov 2021 17:18:40 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635956435; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=u9wQCXREZ4q5bcG2UlrBFoSRMQmJeOgpLrp84sxg5SY=; b=hDWMyKPnt20dmxaDjYB3lcVfhtQEO/W+uGeBJu5Nyo9QF/Dbj1xskPCPvIacV5fjFxgJ6H EQV2QhKZKPX8jymzw8CvtrjEEfTfsUvN5+A1cRy3rLjZUZ/gnhpjQy2ayhu7Re6MVxtMm2 o7xgEv45Aet/PGGC0MFP89/uy6kg9hxR5jCmvMJ3mHcDIqPXQU4R03CuM2yansSR1pwaqQ 7HakgTkXAItpLwfZiAn0GZ6Zxbt6oY+tmywAYt5pp/zeHUF2DFlXXk0HH+g9r9DjHl0pcw EVjadRyHnt1N1Wg06XA3h+KXCY4lImeNrlgnFuH220pdpvtm7mWtYjTB1GZvhw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635956435; a=rsa-sha256; cv=none; b=MQA2QQLy4dVHxj+O2Rz8on5BLtLk8iS+pgdxGF3DaI8sfA1M8r2SpwIqsBXn6V400RQNdn 5M9WkySCV0Mqkq1m9xtRFQgUFqREBNCIQqlpoL7YuWXGpZg7v6wJGROw9MIzPIkR+NEC3T yDoIYGn5ciPf7Ks/umafYLH5RVaMXpe11X3bn9qgrknfYaqLH1e4z3zBF/ITQlcK5brMa+ 7oh8kmzHYmMz6vwX5pXejo48mO6TUmEhrinmV5QqKQXR7YfKaMSP1DWUqSFCuOXtb/ZKFf g9xEblO/0mS/1k7veIRjxhrx4L/Gn5JOywUBtVsxLxaK+n9KqtxWv5NQs9FZFA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ghG4bdlN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ghG4bdlN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 33D621D166 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: Ppy2WrSMjxJO Hi, On Wed, 3 Nov 2021 at 16:34, Z572 <873216071@qq.com> wrote: > $ file `guix build fbreader --with-latest=fbreader -S` > /gnu/store/rdqkmjpiig9gddzsxj4mdyw8lvn944xg-FBReader: HTML document, UTF-8 Unicode text, with very long lines > If a package is a git source package, after use "with-latest" option, it's url > will become to it's source. and build will fail. > > This patch just fix this. I see. However, I am not convinced your example is correct, because for instance, --8<---------------cut here---------------start------------->8--- $ file $(guix build r-soupx -S) /gnu/store/1z0j6i4a9xwwd8d3955m7vq3f1x4p3aq-r-soupx-0.3.1-1.a3354be-checkout: directory --8<---------------cut here---------------end--------------->8--- What you are seeing is: Git upstream source is modified by Guix (for instance, patches are applied or files are removed; in the field 'origin') and "guix build -S" returns what Guix actually builds, not what upstream provides. Therefore, in this case, the modified source is returned as compressed archive. However, when using the transformation 'with-latest', in this case, "guix build -S --with-latest" returns what upstream provides, thus a directory (or something else as a file). Maybe I miss something, but from me, the inconsistency comes from the behavior of "guix build -S", not about the behaviour of 'with-latest' transformation. And I also miss why the build would fail. Cheers, simon