unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#43342] [PATCH 0/3] Fix #43303 GCC package name
@ 2020-09-11 16:06 zimoun
  2020-09-11 16:07 ` [bug#43342] [PATCH 1/3] gnu: libgccjit: Reword synopsis and description zimoun
  2020-09-13 21:12 ` bug#43342: [PATCH 0/3] Fix #43303 GCC package name Ludovic Courtès
  0 siblings, 2 replies; 6+ messages in thread
From: zimoun @ 2020-09-11 16:06 UTC (permalink / raw)
  To: 43342; +Cc: zimoun

Dear,

As described in #43303 [1], the package gcc-toolchain providing the complete
GCC compilation toolchain is not easy to reach; even the manual has a
dedicated section [2].

Commit f17e1802ec325e5cc86d4908f05ac69aafdf39da fixes:

  guix install gcc

which will install instead gcc-toolchain, the expected compilation package.


However, there are still discoverability issues, e.g.,

  guix search gcc | recsel -C -P name | head

reports first the package libgccjit and second gccgo, which have both too
general synopsis and description.  The 2 first patches try to improve the
situation.

Then, because the file gnu/packages/gcc.scm exists and the relevance scoring
function weights the filename too, the query "guix search gcc" artificially
ranks first libgccjit and gccgo.  Therefore the third patch fixes this
corner-case.

[1] http://issues.guix.gnu.org/issue/43303
[2] https://guix.gnu.org/manual/devel/en/guix.html#The-GCC-toolchain

All the best,
simon

zimoun (3):
  gnu: libgccjit: Reword synopsis and description.
  gnu: gccgo: Reword synopsis and description.
  gnu: gcc-toolchain: Reword description.

 gnu/packages/commencement.scm |  3 ++-
 gnu/packages/gcc.scm          | 20 ++++++++++++++++++--
 2 files changed, 20 insertions(+), 3 deletions(-)


base-commit: 1c87536287837c19b6a7d0b5df43fdcab7e5a26e
-- 
2.28.0





^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#43342] [PATCH 1/3] gnu: libgccjit: Reword synopsis and description.
  2020-09-11 16:06 [bug#43342] [PATCH 0/3] Fix #43303 GCC package name zimoun
@ 2020-09-11 16:07 ` zimoun
  2020-09-11 16:07   ` [bug#43342] [PATCH 2/3] gnu: gccgo: " zimoun
  2020-09-11 16:08   ` [bug#43342] [PATCH 3/3] gnu: gcc-toolchain: Reword description zimoun
  2020-09-13 21:12 ` bug#43342: [PATCH 0/3] Fix #43303 GCC package name Ludovic Courtès
  1 sibling, 2 replies; 6+ messages in thread
From: zimoun @ 2020-09-11 16:07 UTC (permalink / raw)
  To: 43342; +Cc: zimoun

Fixes <https://bugs.gnu.org/43303>.
Reported by Jeffrey Walton <noloader@gmail.com>.

* gnu/packages/gcc.scm: (libgccjit)[synopsis,description]: Reword.
---
 gnu/packages/gcc.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm
index a39ac3b84c..c74477aed9 100644
--- a/gnu/packages/gcc.scm
+++ b/gnu/packages/gcc.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2018, 2020 Marius Bakke <mbakke@fastmail.com>
 ;;; Copyright © 2020 Joseph LaFreniere <joseph@lafreniere.xyz>
 ;;; Copyright © 2020 Guy Fleury Iteriteka <gfleury@disroot.org>
+;;; Copyright © 2020 Simon Tournier <zimon.toutoune@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -759,7 +760,16 @@ as the 'native-search-paths' field."
                (for-each delete-file
                          (find-files (string-append (assoc-ref outputs "out") "/bin")
                                      ".*(c\\+\\+|cpp|g\\+\\+|gcov|gcc|gcc-.*)"))
-               #t))))))))
+               #t))))))
+    (synopsis "GCC library generating machine code on-the-fly at runtime")
+    (description
+     "This package is part of the GNU Compiler Collection and provides an
+embeddable library for generating machine code on-the-fly at runtime.  This
+shared library can then be dynamically-linked into bytecode interpreters and
+other such programs that want to generate machine code on-the-fly at run-time.
+It can also be used for ahead-of-time code generation for building standalone
+compilers.  The just-in-time (jit) part of the name is now something of a
+misnomer.")))
 
 
 (define-public gccgo-4.9
-- 
2.28.0





^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#43342] [PATCH 2/3] gnu: gccgo: Reword synopsis and description.
  2020-09-11 16:07 ` [bug#43342] [PATCH 1/3] gnu: libgccjit: Reword synopsis and description zimoun
@ 2020-09-11 16:07   ` zimoun
  2020-09-11 16:08   ` [bug#43342] [PATCH 3/3] gnu: gcc-toolchain: Reword description zimoun
  1 sibling, 0 replies; 6+ messages in thread
From: zimoun @ 2020-09-11 16:07 UTC (permalink / raw)
  To: 43342; +Cc: zimoun

Fixes <https://bugs.gnu.org/43303>.
Reported by Jeffrey Walton <noloader@gmail.com>.

* gnu/packages/gcc.scm: (gccgo-4.9): Add synopsis and description
---
 gnu/packages/gcc.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm
index c74477aed9..4d5aaa7070 100644
--- a/gnu/packages/gcc.scm
+++ b/gnu/packages/gcc.scm
@@ -773,7 +773,13 @@ misnomer.")))
 
 
 (define-public gccgo-4.9
-  (custom-gcc gcc-4.9 "gccgo" '("go")
+  (custom-gcc (package
+                (inherit gcc-4.9)
+                (synopsis "Go frontend to GCC")
+                (description
+                 "This package is part of the GNU Compiler Collection and
+provides the GNU compiler for the Go programming language."))
+              "gccgo" '("go")
               %generic-search-paths
               ;; Suppress the separate "lib" output, because otherwise the
               ;; "lib" and "out" outputs would refer to each other, creating
-- 
2.28.0





^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#43342] [PATCH 3/3] gnu: gcc-toolchain: Reword description.
  2020-09-11 16:07 ` [bug#43342] [PATCH 1/3] gnu: libgccjit: Reword synopsis and description zimoun
  2020-09-11 16:07   ` [bug#43342] [PATCH 2/3] gnu: gccgo: " zimoun
@ 2020-09-11 16:08   ` zimoun
  1 sibling, 0 replies; 6+ messages in thread
From: zimoun @ 2020-09-11 16:08 UTC (permalink / raw)
  To: 43342; +Cc: zimoun

* gnu/packages/commencement.scm (make-gcc-toolchain)[description]: Reword.
---
 gnu/packages/commencement.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
index cc86d06c65..565799c611 100644
--- a/gnu/packages/commencement.scm
+++ b/gnu/packages/commencement.scm
@@ -3861,7 +3861,8 @@ COREUTILS-FINAL vs. COREUTILS, etc."
       (description
        "This package provides a complete GCC tool chain for C/C++ development to
 be installed in user profiles.  This includes GCC, as well as libc (headers and
-binaries, plus debugging symbols in the @code{debug} output), and Binutils.")
+binaries, plus debugging symbols in the @code{debug} output), and Binutils.  GCC
+is the GNU Compiler Collection.")
       (home-page "https://gcc.gnu.org/")
       (outputs '("out" "debug" "static"))
 
-- 
2.28.0





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#43342: [PATCH 0/3] Fix #43303 GCC package name
  2020-09-11 16:06 [bug#43342] [PATCH 0/3] Fix #43303 GCC package name zimoun
  2020-09-11 16:07 ` [bug#43342] [PATCH 1/3] gnu: libgccjit: Reword synopsis and description zimoun
@ 2020-09-13 21:12 ` Ludovic Courtès
  2020-09-14 10:40   ` [bug#43342] " zimoun
  1 sibling, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2020-09-13 21:12 UTC (permalink / raw)
  To: zimoun; +Cc: 43342-done

Hi zimoun,

zimoun <zimon.toutoune@gmail.com> skribis:

>   gnu: libgccjit: Reword synopsis and description.
>   gnu: gccgo: Reword synopsis and description.
>   gnu: gcc-toolchain: Reword description.

Applied all 3 patches.  We’re doing SEO!  :-)

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#43342] [PATCH 0/3] Fix #43303 GCC package name
  2020-09-13 21:12 ` bug#43342: [PATCH 0/3] Fix #43303 GCC package name Ludovic Courtès
@ 2020-09-14 10:40   ` zimoun
  0 siblings, 0 replies; 6+ messages in thread
From: zimoun @ 2020-09-14 10:40 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 43342-done

Hi,

Thank you for the quick review. :-)

On Sun, 13 Sep 2020 at 23:12, Ludovic Courtès <ludo@gnu.org> wrote:

> Applied all 3 patches.  We’re doing SEO!  :-)

Yeah! :-)
Waiting for improvement of 'relevance'... my long overdue.

Cheers,
simon




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-09-14 10:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 16:06 [bug#43342] [PATCH 0/3] Fix #43303 GCC package name zimoun
2020-09-11 16:07 ` [bug#43342] [PATCH 1/3] gnu: libgccjit: Reword synopsis and description zimoun
2020-09-11 16:07   ` [bug#43342] [PATCH 2/3] gnu: gccgo: " zimoun
2020-09-11 16:08   ` [bug#43342] [PATCH 3/3] gnu: gcc-toolchain: Reword description zimoun
2020-09-13 21:12 ` bug#43342: [PATCH 0/3] Fix #43303 GCC package name Ludovic Courtès
2020-09-14 10:40   ` [bug#43342] " zimoun

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git