From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:60729) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAhlk-0003Qu-AV for guix-patches@gnu.org; Sat, 07 Mar 2020 17:18:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAhli-0006ly-Qp for guix-patches@gnu.org; Sat, 07 Mar 2020 17:18:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41743) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jAhli-0006lm-NS for guix-patches@gnu.org; Sat, 07 Mar 2020 17:18:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jAhli-0004ln-Iv for guix-patches@gnu.org; Sat, 07 Mar 2020 17:18:02 -0500 Subject: [bug#39547] [PATCH v3] sources.json: array instead of list Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: <87o8t9oigf.fsf@gnu.org> References: <20200210170418.32076-1-zimon.toutoune@gmail.com> <87o8t9oigf.fsf@gnu.org> From: zimoun Date: Sat, 7 Mar 2020 23:17:48 +0100 Message-ID: Content-Type: multipart/alternative; boundary="000000000000f39a5b05a04b23e1" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: "39547@debbugs.gnu.org" <39547@debbugs.gnu.org> --000000000000f39a5b05a04b23e1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ludo, Yes please push. Cheers, simon PS: i am typing with my smartphone because i am sleeping in a hospital (Purpan, Toulouse). I lose part of sensitivity and mobility of my right arm after a shock to my neck during a basket ball party with some friends. Everything is on the process but I cannot say when i will have access to my laptop next ; maybe Tomorrow, maybe one week later. So please go ahead (-: On Friday, 6 March 2020, Ludovic Court=C3=A8s wr= ote: > Hi! > > zimoun skribis: > > > Attached, the tiny modification to output the list (array) of URLs > > instead of the first one. > > The version number is still '1' because I do not know yet if lewo would > bump it. > > Note also that "transformer" is not useful any more because > > 'packages-json-builder' and 'sources-json-builder' returns both > > vectors now. > > Cool. > > > From 57a444f6f215fb6327719161a6e6ad4ad229273f Mon Sep 17 00:00:00 2001 > > From: zimoun > > Date: Mon, 10 Feb 2020 17:52:13 +0100 > > Subject: [PATCH v3 1/2] website: Refactor and resolve mirror:// of JSON > > package list. > > > > * website/apps/packages/builder.scm (origin->json): New procedure. > > LGTM! > > > From 73557bc00760b4404bfe17ecb3aca983c6dcc11e Mon Sep 17 00:00:00 2001 > > From: zimoun > > Date: Tue, 18 Feb 2020 13:25:14 +0100 > > Subject: [PATCH v3 2/2] website: Provide JSON sources list used by > Software > > Heritage. > > > > Format discussed here . > > > > * website/apps/packages/builder.scm (origin->json): Add list modifier. > > * website/apps/packages/builder.scm (sources-json-builder): New > procedure. > > Nitpick: no need to repeat the file name here. > > Also: please mention the addition to the =E2=80=98builder=E2=80=99 proced= ure. > > > +(define* (origin->json origin #:optional (transformer list->vector)) > > You can remove this parameter, as you wrote. > > I can make these changes and push it on your behalf if you want, let me > know! > > Thanks, > Ludo=E2=80=99. > --000000000000f39a5b05a04b23e1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ludo,

Yes please push.

Cheer= s,
simon

PS: i am typing with my smartph= one because i am sleeping in a hospital (Purpan, Toulouse). I lose part of = sensitivity and mobility of my right arm after a shock to my neck during a = basket ball party with some friends. Everything is on the process but I can= not say when i will have access to my laptop next ; maybe Tomorrow, maybe o= ne week later. So please go ahead (-:

On Friday, 6 March 2020, Ludov= ic Court=C3=A8s <ludovic.cou= rtes@inria.fr> wrote:
Hi!

zimoun <zimon.toutoune@gmail= .com> skribis:

> Attached, the tiny modification to output the list (array) of URLs
> instead of the first one.
> The version number is still '1' because I do not know yet if l= ewo would bump it.
> Note also that "transformer" is not useful any more because<= br> > 'packages-json-builder' and 'sources-json-builder' ret= urns both
> vectors now.

Cool.

> From 57a444f6f215fb6327719161a6e6ad4ad229273f Mon Sep 17 00:00:00= 2001
> From: zimoun <zimon.tou= toune@gmail.com>
> Date: Mon, 10 Feb 2020 17:52:13 +0100
> Subject: [PATCH v3 1/2] website: Refactor and resolve mirror:// of JSO= N
>=C2=A0 package list.
>
> * website/apps/packages/builder.scm (origin->json): New proced= ure.

LGTM!

> From 73557bc00760b4404bfe17ecb3aca983c6dcc11e Mon Sep 17 00:00:00= 2001
> From: zimoun <zimon.tou= toune@gmail.com>
> Date: Tue, 18 Feb 2020 13:25:14 +0100
> Subject: [PATCH v3 2/2] website: Provide JSON sources list used by Sof= tware
>=C2=A0 Heritage.
>
> Format discussed here <https://forge.softwareheritage.org/D2= 025#51269>.
>
> * website/apps/packages/builder.scm (origin->json): Add list m= odifier.
> * website/apps/packages/builder.scm (sources-json-builder): New p= rocedure.

Nitpick: no need to repeat the file name here.

Also: please mention the addition to the =E2=80=98builder=E2=80=99 procedur= e.

> +(define* (origin->json origin #:optional (transformer list->vec= tor))

You can remove this parameter, as you wrote.

I can make these changes and push it on your behalf if you want, let me
know!

Thanks,
Ludo=E2=80=99.
--000000000000f39a5b05a04b23e1--