unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Aniket Patil <aniket112.patil@gmail.com>, 44033@debbugs.gnu.org
Subject: [bug#44033] [PATCH 1/3] gnu: Add r-decon.
Date: Thu, 22 Oct 2020 09:59:28 +0200	[thread overview]
Message-ID: <CAJ3okZ2XLywW3Cmd6nL0OSGsiLewEHS=ytfvnXRi2Ebz=0wHWA@mail.gmail.com> (raw)
In-Reply-To: <CAF-xJgsF_M7R7nrPtP4iXL7yxqz6r09G-cNpJ0+VDsDYqTj6Zg@mail.gmail.com>

Hi,

Please keep CC 44033@debbugs.gnu.org. :-)

On Thu, 22 Oct 2020 at 08:22, Aniket Patil <aniket112.patil@gmail.com> wrote:

> Also what do you mean by
> >  The file gnu/packages/cran.scm has changed between so your patches do
> > not apply anymore.  Could you rebase on the top?  Please.
> Do you mean that those packages are included? Or do you mean the packages aren't indented correctly?

I mean that the file gnu/packages/cran.scm has changed (new packages
that are not yours have been added) so the patches you sent do not
apply (which means that "git am" fails).

Your packages are *not* included, yet.  Because they are not compliant
enough with the standard.  The indentation is one the minor tweaks you
have to do.

To summary:

  1. please re-read
<https://lists.gnu.org/archive/html/help-guix/2020-10/msg00047.html>
and you can experiment with <https://git-send-email.io/#step-4> (see
the other steps too) and train with for example
<https://git-rebase.io/>.
  2. do the changes (git rebase -i)
  3. rebase your branch (if any) on the top of master
  4. git format-patch -v2 --base=<last-master-commit-before-your-changes>
  5. git send-email --to=44033@debbugs.gnu.org ...

Does it make sense?  If you are failing, do not hesitate to ask help
on #guix over IRC.


All the best,
simon




      parent reply	other threads:[~2020-10-22  8:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 13:13 [bug#44033] [PATCH 1/3] gnu: Add r-decon Aniket Patil
2020-10-16 13:13 ` [bug#44033] [PATCH 2/3] gnu: Add r-locpol Aniket Patil
2020-10-16 13:13 ` [bug#44033] [PATCH 3/3] gnu: Add r-lpme Aniket Patil
2020-10-19 12:09 ` [bug#44033] [PATCH 1/3] gnu: Add r-decon zimoun
2020-10-19 12:27   ` Aniket Patil
     [not found]     ` <CAF-xJgsF_M7R7nrPtP4iXL7yxqz6r09G-cNpJ0+VDsDYqTj6Zg@mail.gmail.com>
2020-10-22  7:59       ` zimoun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ3okZ2XLywW3Cmd6nL0OSGsiLewEHS=ytfvnXRi2Ebz=0wHWA@mail.gmail.com' \
    --to=zimon.toutoune@gmail.com \
    --cc=44033@debbugs.gnu.org \
    --cc=aniket112.patil@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).