From: zimoun <zimon.toutoune@gmail.com>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 51888@debbugs.gnu.org
Subject: [bug#51888] [PATCH 0/1] import: opam: Warn instead of leave when fetching fails.
Date: Tue, 16 Nov 2021 16:33:28 +0100 [thread overview]
Message-ID: <CAJ3okZ2Ldj_x3DLM85zP1+jKp8YnSGCa5EvpVC-VDRMNzpZynQ@mail.gmail.com> (raw)
In-Reply-To: <20211116140248.1dcf61e5@tachikoma.lepiller.eu>
Hi,
On Tue, 16 Nov 2021 at 14:03, Julien Lepiller <julien@lepiller.eu> wrote:
> I already had a patch for that, which is a bit more complex, at
Sorry, I missed it.
> https://issues.guix.gnu.org/51091. WDYT?
Your patch LGTM. I am not convinced that all the complexity is worth;
compared to the proposed trivial change. ;-)
From my opinion, the way is a common error for the all importers and
raise it; all the catch happening in 'guix/scripts/'. That's another
story. :-)
One minor comment, in 'latest-release' I would write "opam: package
'~a' not found~%" otherwise the message "guix lint: warning: package
'example' not found" looks odd (at least to me :-)).
Feel free to close this issue and the other once you pushed a fix.
Cheers,
simon
next prev parent reply other threads:[~2021-11-16 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 10:10 [bug#51888] [PATCH 0/1] import: opam: Warn instead of leave when fetching fails zimoun
2021-11-16 10:12 ` [bug#51888] [PATCH 1/1] " zimoun
2021-11-16 13:02 ` [bug#51888] [PATCH 0/1] " Julien Lepiller
2021-11-16 15:33 ` zimoun [this message]
2021-11-19 11:59 ` Julien Lepiller
2021-11-19 12:00 ` bug#51888: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3okZ2Ldj_x3DLM85zP1+jKp8YnSGCa5EvpVC-VDRMNzpZynQ@mail.gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=51888@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).