unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Pierre Langlois <pierre.langlois@gmx.com>
Cc: 43276-done@debbugs.gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>,
	43276@debbugs.gnu.org
Subject: [bug#43276] [PATCH] gnu: emacs-org-contrib: Fix origin hash.
Date: Wed, 9 Sep 2020 15:49:00 +0200	[thread overview]
Message-ID: <CAJ3okZ1cmBvAhBeBVVLxirezwojM6jOhgXg22548+yigR2SRow@mail.gmail.com> (raw)
In-Reply-To: <87pn6vdr96.fsf@gmx.com>

On Wed, 9 Sep 2020 at 15:17, Pierre Langlois <pierre.langlois@gmx.com> wrote:
>
>
> zimoun writes:
>
> > Hi,
> >
> > On Wed, 9 Sep 2020 at 14:46, Pierre Langlois <pierre.langlois@gmx.com> wrote:
> >>
> >>
> >> Fixed with 057d584b981d9a3293be03ee863d40a61c8aae74
> >
> > Not for me.
>
> Actually, yeah it didn't fix it for me either, I was too quick closing
> this bug. But, the next commit does fix it I think.

Yes.  But as Tobias raised up:

   I think it's good not to normalize them by at least briefly describing
   the upstream changes in the commit message. ‘Fix’ is borderline
   misleading IMO.

i.e., something along:

--8<---------------cut here---------------start------------->8---
gnu: emacs-org-contrib: Update source hash.

The previous tarball was modified in-place; see????????

* gnu/packages/emacs-xyz.scm (emacs-org-contrib)[source](sha256): Update.
--8<---------------cut here---------------end--------------->8---
(tweaked from harfbuzz replacement a8bb8fccd8)

Anyway.

 > @Tobias, the hash that's now upstream is the only one I've seen locally,
> and I assume it's the same case for simon. Do you happen to still have
> the tar ball with the previous hash? I'm curious what changed upstream,
> if it's unstable we might be better off using a git repo instead of
> elpa, as in code.orgmode.org/bzg/worg/src/master/org-contrib. Although
> then I don't know which commit corresponds to what's on elpa :-/.

I agree.  If Tobias still has the tarball, then it could be on Berlin
as substitute.  Otherwise "guix time-machine" will be broken for a
couple of commits (the 35 ones of the 2 last days, if I count
correctly).
Going to something content-addressed is a good idea, IMHO.  But I do
not know either how from where this "org-plus-contrib" comes?
The future disassemble and SWH backend should fix this kind of issues, I guess.


All the best,
simon




      parent reply	other threads:[~2020-09-09 13:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08 12:07 [bug#43276] [PATCH] gnu: emacs-org-contrib: Fix origin hash Pierre Langlois
2020-09-09 12:45 ` bug#43276: " Pierre Langlois
2020-09-09 13:01   ` [bug#43276] " zimoun
2020-09-09 13:16     ` Pierre Langlois
2020-09-09 13:20       ` Pierre Langlois
2020-09-09 13:49       ` zimoun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ3okZ1cmBvAhBeBVVLxirezwojM6jOhgXg22548+yigR2SRow@mail.gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=43276-done@debbugs.gnu.org \
    --cc=43276@debbugs.gnu.org \
    --cc=me@tobias.gr \
    --cc=pierre.langlois@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).