From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WIJuEddogmGXCwAAgWs5BA (envelope-from ) for ; Wed, 03 Nov 2021 11:47:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id +KcvDddogmFLKAAAB5/wlQ (envelope-from ) for ; Wed, 03 Nov 2021 10:47:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8DF0914044 for ; Wed, 3 Nov 2021 11:47:49 +0100 (CET) Received: from localhost ([::1]:58806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miDo3-0001Az-J3 for larch@yhetil.org; Wed, 03 Nov 2021 06:47:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miDmM-0008Cl-9X for guix-patches@gnu.org; Wed, 03 Nov 2021 06:46:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miDmM-0006B8-0Z for guix-patches@gnu.org; Wed, 03 Nov 2021 06:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miDmL-0001xV-UA for guix-patches@gnu.org; Wed, 03 Nov 2021 06:46:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Nov 2021 10:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51427 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 51427@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Liliana Marie Prikler Received: via spool by 51427-submit@debbugs.gnu.org id=B51427.16359363577513 (code B ref 51427); Wed, 03 Nov 2021 10:46:01 +0000 Received: (at 51427) by debbugs.gnu.org; 3 Nov 2021 10:45:57 +0000 Received: from localhost ([127.0.0.1]:39162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miDmH-0001x7-Gv for submit@debbugs.gnu.org; Wed, 03 Nov 2021 06:45:57 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]:39935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miDmF-0001wu-IB for 51427@debbugs.gnu.org; Wed, 03 Nov 2021 06:45:55 -0400 Received: by mail-qt1-f174.google.com with SMTP id x10so65538qta.6 for <51427@debbugs.gnu.org>; Wed, 03 Nov 2021 03:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pbolAUOeDapWsysQBp2EKyUNiY/24M0/tTBAMTPTsYs=; b=J1kppa/DVhbUVBLVMIblWces6LQI7etfz78EpPYeN+6gzUjW+KVK0inWialfss70bg gHq85ffPgdN2zp0/kf5HV+hkeNXsZK+2pdsX/D/4lI6V4xF1X4YetJlzvGqhEQFQfRqW YsqSkTcMSWJYN6j9kw42xs+75ON9F/Xd70Iib9jTuf/yeRnN4B+4KtznpaepWo0ktHck mONdHIIvVxchsEWL9aAxksmF2GDYRfWhjbfQjbW/mXO64Mibz0qp7rZTVNKSYR1RvoPL 04d8F5Sn4td9hDS1rbf1WayHBduB5ynKQdrk1ND/rJLbG+D3/Sia9KqZK5BESEeQ0sx8 x10A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pbolAUOeDapWsysQBp2EKyUNiY/24M0/tTBAMTPTsYs=; b=ueiSvj4MRrMN0SDZORJDVx6hAk2IWEBdYF0oDFBj3hL2o8IpryXMF4J1VY+DpMkEDz gKDzz1bio9dVsEs1i8MP2v+6WPvKIpwbIXPucHDYPE0ilMZX2gvJ0KxdxVoeA8kG5W4T sp7/s0pbOj4xHmCyIKs9m5bBXUfzwJ22FdEX0RRUFEBZVLzYQjTmVrpPOFZkl7I/6LAk RGSiGbB6qTiNX/8jqZmbUQ+KzFe8CHadbD8NeI1Yan3AZVyQ0i9e4vQNkNAiZIGmyEym S5AlECerScHIkl/i/30ufHfAl9I/CGnGklPCinPm5U1BnE+qbO+Frdt3SRCno6eBk1xI XS8w== X-Gm-Message-State: AOAM533Porl6V1KLWZTC1z1disexZzABPofTuOPy6sPuTalVbxW802O6 EL4SRj7v5nzxPCl15MadFfH/tzYbNVtuZR7gntE= X-Google-Smtp-Source: ABdhPJy6npCzdgT+H20xxwZkoFxJp5LhysiXgaOvEWq5DbeiAIGPlqPQOyBMzeGKWLLGpfmIwII8JzBQdUchUOpC+8s= X-Received: by 2002:a05:622a:58e:: with SMTP id c14mr41100617qtb.225.1635936349983; Wed, 03 Nov 2021 03:45:49 -0700 (PDT) MIME-Version: 1.0 References: <20211027034918.4591-1-maxim.cournoyer@gmail.com> <87o8795j61.fsf@gnu.org> <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@gmail.com> <87h7cxp9tl.fsf@gnu.org> <87sfwg7w9z.fsf@gmail.com> In-Reply-To: <87sfwg7w9z.fsf@gmail.com> From: zimoun Date: Wed, 3 Nov 2021 11:45:39 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635936471; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pbolAUOeDapWsysQBp2EKyUNiY/24M0/tTBAMTPTsYs=; b=sBOeDfQZIofY+K0zHyscZtyJjnhpWvtu/Q6BAEaIdupxhY2GMEv35sEeNYo5JuiTYOnNtb T06Noc+4KMH9HzB6K/zQanwJf61d8rNrLvHg/NSc0y6STLS73ZibTne3GklRHCderFS8pW HUlls2GTFmqI8QAMIla8dkfKQnkoeSt45A2TPye/I5ZmImjRkoq5vOJJeYO0Awt0IboD3+ pNsKtMMfnUPVujodAFSXArgC9gtVZtJD5H2cl5e1PxfFJD4dS9qPBzNxe75TScYVKaklcG yX8CtEUJ1J38/C3rmvOXMiH1QIB9NwsnhxDvwOoKWVhO8GpTuC81uEx8mIY8PA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635936471; a=rsa-sha256; cv=none; b=BU2p68YHR5EkeTlNU86dwDvugvPoe6NfQwcG1/HeXfu1QAJXl9EBvfuZVmNvsnsUJWRud/ evPlLuCCV0Av8ZUpm53J78IXVs8jgw4Fnly2ZkxMDcYtb20+TueiqG3yN0ZT4jKZaR8oNs b0/EMZ6iKjCqnEDK0NDW4rnsPxZ5PpAbchFIAyyK/zirwBDapXUFzqMlP9S2VXZ5Ab5c74 Im8Hnw9nuAtEx/7w7BKEsrh5c9VkfdVgCKb1kAjDVWD8c6OKH3FUyj2o8sg4qYk8mu+DfL QIpAsh7Osgl3b8xotKb77c87VA2E/3nET53C9z2bwnCIbMeo2NPGVIlnphaJ1w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="J1kppa/D"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="J1kppa/D"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8DF0914044 X-Spam-Score: 0.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: IodWc2HA4XCr Hi, On Sun, 31 Oct 2021 at 21:53, Maxim Cournoyer w= rote: > > My proposal would be either the status quo, or removing just the one > > link that matters from /gnu/store/.links upon =E2=80=98-D=E2=80=99. > > The second proposal makes sense. I didn't care about freeing space, as > my use case was getting around corrupting an item in my store due to > https://issues.guix.gnu.org/51400, which the patch proposed here allowed > me to do without wasting hours of cleaning up links (nearly 1 GiB of > store on spinning drives). I often use "guix gc -D" for being able to launch again a command and then check against SWH or other upstream. Because the "deleting links" is too much long, I am doing ^C at this step. Therefore, be able to skip this step when running "guix gc -D" appears to me the thing to do. Well, if "guix gc -D" is not doing it, then I am forcing it by interrupting it; which appears to me worse than status quo. BTW, if I need space, then I do not use "guix gc -D" on few items but instead I use the options -F or -d or -C; here I am fine it takes the time it takes. :-) Well, =C2=AB"deleting unused links" GC phase is too slow=C2=BB is not new because it is bug#24937 [1]. Therefore, status quo is really annoying and I would prefer to skip this GC phase when using option -D although it is not optimal. Or remove just the one link that matters. 1: Cheers, simon