From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sPo8NitG3mTrewEASxT56A (envelope-from ) for ; Thu, 17 Aug 2023 18:09:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wJQVNitG3mRWRQEAauVa8A (envelope-from ) for ; Thu, 17 Aug 2023 18:09:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9626840244 for ; Thu, 17 Aug 2023 18:09:15 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=SwZsAyyz; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692288555; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=HjO11gvKcp5CGFhetkz9p/9OiMR6HRwXQFEhO6aTmI8=; b=QKVuHZKEtZTJR3DngQdpW4GZfkII9p+Ul2kHbtsiNWfyJ4x4TsML+qBj0px1EJ5YT7NjBw pOph6YeeREbZ62jMNkCvW7WQO//5Fkbt6j43mHJWcVSaf+4Ek6BfFz+qiR477TLHg8p0CU wB1qWX1zAK72tJpjWr2FSle0Fyf3cSw9YKc7Sqo5zlAC94UCvvlEEbDY0C5vHaVAzaJCxA ZmSfkZdW16N+7wjn4DftQYFEBnYzpSSthNHAXm0VpoJHyqlVc3tAlz8gq8C4u+GFk9MHMF Iyt4jIvufmbydlnPv6n4NTiLt8JzCVIwZl8O93Y2T2oNYM8trr0HI+IJM7BK3Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692288555; a=rsa-sha256; cv=none; b=nRMsXIl6zOJKnbCrS729sFAGQ29OymlDu+blC77bmiL/oe55eXZAT5aDdIY0uktlLbyQT/ 8AVLhPYgCahkVEFUe2j1Fd+SGvs49HlOoZFakHdH4/aMsAj+T9OTGIu76Hog1PSgtzY36y oj9r56MXUwX0N13TV5ZJAq2k8+MVr325t8356/l11CwyNVgWTT/9FKt+PV1M9lFjGIHmB2 5AXRV8VQV2nFcdBX/O1wDXO7fKtS9u2JRdasID+6tPo62hbbUolgwU+5A3+ndyMSutSSxb t+ADxOB8yUqrMJHqKebfRzW+TgJ07btld6pYDyj1UyK6DGsQhZlfD7AirlILaA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=SwZsAyyz; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWfYY-0000oe-Qj; Thu, 17 Aug 2023 12:09:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWfYW-0000li-Hn for guix-patches@gnu.org; Thu, 17 Aug 2023 12:09:05 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWfYU-0006cn-LH for guix-patches@gnu.org; Thu, 17 Aug 2023 12:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWfYU-0004zA-AH for guix-patches@gnu.org; Thu, 17 Aug 2023 12:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65352] Fix time-machine and network Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 17 Aug 2023 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 65352@debbugs.gnu.org Received: via spool by 65352-submit@debbugs.gnu.org id=B65352.169228853919155 (code B ref 65352); Thu, 17 Aug 2023 16:09:02 +0000 Received: (at 65352) by debbugs.gnu.org; 17 Aug 2023 16:08:59 +0000 Received: from localhost ([127.0.0.1]:45403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWfYR-0004ys-3O for submit@debbugs.gnu.org; Thu, 17 Aug 2023 12:08:59 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:37929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWfYO-0004yd-32 for 65352@debbugs.gnu.org; Thu, 17 Aug 2023 12:08:58 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b9cb0bb04bso21716631fa.0 for <65352@debbugs.gnu.org>; Thu, 17 Aug 2023 09:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692288530; x=1692893330; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HjO11gvKcp5CGFhetkz9p/9OiMR6HRwXQFEhO6aTmI8=; b=SwZsAyyzFVoPoRXRahaeZRTuE33bW6WxgTQDE3mO7h/rDQPgvz4WmT3gOB9gYv7UK0 qzV0h4kNcu31jWBaQlvnwqKv7Qpc9mfBuLkwFveb+HToG+hegqoicXYI/wksuKcJESuh ofNjlvWsNTFOvhMfM/APJTulE4kJ9tfX9uaGa9RmpUUfDNX9ldwqHieeCFbvGYGP1w9Y UrPZFwGB2MVlyTgoweUGndipZn5D5nXo+h6cZYrwQZx2iXjF7NvRIwyal6x30PuZ2ETT Yse8Dm6R4V4h5YGLV4AshFms/9roOiW33Ou8EgRP3+ZxzczyweMabO9wKCqmFne0EUmX CZRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692288530; x=1692893330; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HjO11gvKcp5CGFhetkz9p/9OiMR6HRwXQFEhO6aTmI8=; b=F2jGb8PFPWKeghBZy6Ez7EgfgvpPt071ziweZFzse6fnFB0Oul0qQglbWY2vJmnDKO VS4iPsHxFJjuUpZik1bY525JV21b+ILVIDfnIqdt0SNR6NPIlqIthjGN7nrAFv9xH6Ya L67+j+YTLpdCL9ss4krgQ88rM/fqia2Rjd2tHpePoPhdJ9ubmhwLACG1AsqYAn0sds0o ITJqcLxkYC+R4U+FouOQNPeqACRwsOAvCy5O1MoXX0OcgVk17oZDMUfxxIHpQM8+qtL1 9yoQ/y563dbNf/TZM9Cpgp5+7CUxEYGyfU3fp7CoaOIxvGnXxncnUMmG3xbIKHNJu9gQ IsnA== X-Gm-Message-State: AOJu0YzzUPfiSE2MXmgHfXPlLQbcPlzAWvVcB9cuVHAAJv2+5oDeMGv8 CdmKTYR8IgkqtaMaV2sla1iTJ2HPUGDLQ7Q+oz8= X-Google-Smtp-Source: AGHT+IHFvzHpoVXkU5gso6STIaJwCOk94LzQQ9haUrnEb4PgYOTDypkHxq3pjqjaPd1LoNM2Vm4c9VJZoEhr+bKyy6c= X-Received: by 2002:a05:651c:1506:b0:2b9:a156:6239 with SMTP id e6-20020a05651c150600b002b9a1566239mr5529732ljf.1.1692288529628; Thu, 17 Aug 2023 09:08:49 -0700 (PDT) MIME-Version: 1.0 References: <444e7e32d49b56ba6cb0a132e97d63560d8de437.1692281315.git.zimon.toutoune@gmail.com> <87o7j5fzg8.fsf_-_@gmail.com> In-Reply-To: <87o7j5fzg8.fsf_-_@gmail.com> From: Simon Tournier Date: Thu, 17 Aug 2023 18:08:38 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 2.81 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: 9626840244 X-Spam-Score: 2.81 X-TUID: cQx0FX77Gdj7 Hi Maxim, On Thu, 17 Aug 2023 at 17:42, Maxim Cournoyer wrote: > > (match ref > > - ((or ('commit . commit) > > - ('tag-or-commit . commit)) > > + (('tag-or-commit . commit) > Not that channel-list is a public API, so this is effectively changing > the contract, no? Well, the contract is not clearly defined. ;-) The REF is defined by the docstring of update-cached-checkout, REF is pair whose key is [branch | commit | tag | tag-or-commit ] and value the associated data: [ | | | ]. If REF is the empty list, the remote HEAD is used. Therefore, if we want to be compliant with the public API, we also need to add 'tag' to the 'or' match case; as I suggested when commenting your patch tweaking this part. :-) Well, from my point of view, the alternative is: a) (match ref (('tag-or-commit . commit) (channel (inherit c) (url url) (commit commit) (branch #f))) (('branch . branch) (channel (inherit c) (url url) (commit #f) (branch branch))) (#f (channel (inherit c) (url url)))) or b) (match ref ((or ('commit . commit) ('tag-or-commit . commit) ('tag . commit)) (channel (inherit c) (url url) (commit commit) (branch #f))) (('branch . branch) (channel (inherit c) (url url) (commit #f) (branch branch))) (#f (channel (inherit c) (url url))))) but not ecab937897385fce3e3ce0c5f128afba4304187c. :-) Cheers, simon