From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kJizAFTxk18pHgAA0tVLHw (envelope-from ) for ; Sat, 24 Oct 2020 09:18:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YKkdOFPxk18IFwAAB5/wlQ (envelope-from ) for ; Sat, 24 Oct 2020 09:18:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7C38C9401DD for ; Sat, 24 Oct 2020 09:18:11 +0000 (UTC) Received: from localhost ([::1]:34942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWFgf-0004vT-MO for larch@yhetil.org; Sat, 24 Oct 2020 05:18:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWFgY-0004uW-P6 for guix-patches@gnu.org; Sat, 24 Oct 2020 05:18:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47429) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWFgY-0001nm-EE for guix-patches@gnu.org; Sat, 24 Oct 2020 05:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWFgY-0005Rp-75 for guix-patches@gnu.org; Sat, 24 Oct 2020 05:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Oct 2020 09:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 43946-done@debbugs.gnu.org Received: via spool by 43946-done@debbugs.gnu.org id=D43946.160353104720494 (code D ref 43946); Sat, 24 Oct 2020 09:18:02 +0000 Received: (at 43946-done) by debbugs.gnu.org; 24 Oct 2020 09:17:27 +0000 Received: from localhost ([127.0.0.1]:58975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWFfy-0005KQ-Ll for submit@debbugs.gnu.org; Sat, 24 Oct 2020 05:17:27 -0400 Received: from mail-qv1-f66.google.com ([209.85.219.66]:46684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWFft-0005I0-PF for 43946-done@debbugs.gnu.org; Sat, 24 Oct 2020 05:17:24 -0400 Received: by mail-qv1-f66.google.com with SMTP id s1so2058121qvm.13 for <43946-done@debbugs.gnu.org>; Sat, 24 Oct 2020 02:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Z7IApHdqppembymsbkzzY31q1IDDwt1J7Ui4EFiulqw=; b=H/K/5fFSToqrXY+e1KeX9/3VbwlFoW/WrY1kVDTLJGvmUviVDFlHS8N/ODfwzsOmHW ongOrms9z5tx1m1o+1BxHtVDFs61UsEWrPSf7mstdWmjWFr8NIIiJCEN3BYVXvPcih/T NIv5W1/gn0fey/tMxb5lfudzQtHwFyWotjJr0MBDxRVWyzmu4N/vNXMLNqdB0Q3k2N7N KMd/T+KxkTIpBl23c52izNmKYWWa5C1OJ3MZK68nzgHu6M6E3dVGdOvkD4LeFSMbdDBz IP0erZ/EbjvOxnwedaeRhMSCUZQeU1Ys3MVxRTvCdcc9Eiq1PgOwHbBy/Wu5JDhEHtm6 htug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Z7IApHdqppembymsbkzzY31q1IDDwt1J7Ui4EFiulqw=; b=J7GnHjISioEXS7MKbpVefSOJxSpVo/Z7avXDqoDxRewkmM5asfXwEpXpZKxELKq1se SaPrFACGPThICuDwsbEkzPWcJjbb44bzHBktxd56U0magQ0XPBn21spCIyHWaS1wBC6h ZHaHXU7XsvsVgxhObL6OB+t6qjm0zXQ9skdORUYGOh4MAu/pJL5rZK1A7loGF6iCsGgS Y/kgOT9kZakPwT4yuzmsQJ6rH219O5gPIdEjeR2Usdd8ED/nR5YdEbOy8lVE1fKEjB6N moJdzuCExaTdf5q8MCeSuI/yitTDRKFoWDuBTlfpynkp/Rd5WwhAUiA/e4w6sk7eFR29 EYpQ== X-Gm-Message-State: AOAM5325QW8gGecYoc3J4jdmSrg9vNyZD2mOwCzVt3UL+EaS/YiVm8Kb d26LwBCDJGgIqAO+9L1i4hBZr9IiS4+WMeCxCV4= X-Google-Smtp-Source: ABdhPJy8C068IhoRE5aklViPFFipPeFIryR1VW3P5PrQU6NpSehTt0a1YonwU1dJ8Ro/jmQJC2gzE1Rm3tAVxAIxQ4s= X-Received: by 2002:a05:6214:1268:: with SMTP id r8mr471809qvv.40.1603531036152; Sat, 24 Oct 2020 02:17:16 -0700 (PDT) MIME-Version: 1.0 References: <20201012082003.19936-1-zimon.toutoune@gmail.com> <87d0189ev4.fsf@gmail.com> In-Reply-To: <87d0189ev4.fsf@gmail.com> From: zimoun Date: Sat, 24 Oct 2020 11:17:03 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=H/K/5fFS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: rZSV+baJpal/ Dear, Thank you for the review. On Sat, 24 Oct 2020 at 11:01, Oleg Pykhalov wrote: > zimoun writes: > > > * doc/contributing.texi (Submitting Patches): Add item about 'git-forma= t-patch > > --base'. > > --- > > doc/contributing.texi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/doc/contributing.texi b/doc/contributing.texi > > index af3601442e..5ea3cb1899 100644 > > --- a/doc/contributing.texi > > +++ b/doc/contributing.texi > > @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a = package definition, > > please run through this check list: > > > > @enumerate > > +@cindex @code{git format-patch} > > +@cindex @code{git-format-patch} > > +@item > > +We recommend to use the command @code{git format-patch --base} to > > +include the commit where your patch applies. > > =E2=80=9Cgit format-patch=E2=80=9D already mentioned in the documentation= in the first > paragraph https://guix.gnu.org/manual/en/html_node/Submitting-Patches.htm= l The point of the patch is: - the addition of the cindex - the addition of the option --base and AFAITC it is not already in the manual. If it is the wrong place, please let me know where it could be better. All the best, simon