From: zimoun <zimon.toutoune@gmail.com>
To: pinoaffe <pinoaffe@airmail.cc>
Cc: 50755@debbugs.gnu.org
Subject: [bug#50755] [PATCH v3] import: Generate list of importers based on available modules
Date: Mon, 27 Sep 2021 22:09:26 +0200 [thread overview]
Message-ID: <CAJ3okZ05LLzBLTY_srqarf1LG-tq2sN7wJmg3UaU7fxFBMovHQ@mail.gmail.com> (raw)
In-Reply-To: <87mtnxswwq.fsf@airmail.cc>
Hi,
On Mon, 27 Sept 2021 at 20:21, pinoaffe <pinoaffe@airmail.cc> wrote:
> +(define importers (delete-duplicates
This fixes my first point...
> + (filter-map (lambda (module)
> + (match (module-name module)
> + (`(guix scripts import ,importer)
> + (symbol->string importer))
> + ( #t #f)))
> + (all-modules (map (lambda (entry)
> + `(,entry . "guix/scripts/import"))
> + %load-path)))))
...and it means it is walking more than needed. Therefore, what is
the performance loss?
For instance, on my machine and hot cache, it is 4x slower. And, this
readibility improvement is not worth, IMHO.
On cold cache, I do not have meaningful numbers because it requires to
run it several times and then compute an average. What are the
numbers of your machine?
All the best,
simon
next prev parent reply other threads:[~2021-09-27 20:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 12:24 [bug#50755] [PATCH] import: Generate list of importers based on available modules pinoaffe
2021-09-23 18:07 ` Sarah Morgensen
2021-09-23 21:17 ` pinoaffe
2021-09-23 21:19 ` [bug#50755] [PATCH v2] " pinoaffe
2021-09-27 14:28 ` zimoun
2021-09-27 18:27 ` pinoaffe
2021-09-27 18:20 ` [bug#50755] [PATCH v3] " pinoaffe
2021-09-27 20:09 ` zimoun [this message]
2021-09-28 9:51 ` Maxime Devos
2021-09-28 14:39 ` pinoaffe
2021-09-29 20:59 ` Maxime Devos
2021-09-30 8:17 ` pinoaffe
2021-09-30 8:37 ` Maxime Devos
2021-10-11 11:51 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3okZ05LLzBLTY_srqarf1LG-tq2sN7wJmg3UaU7fxFBMovHQ@mail.gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=50755@debbugs.gnu.org \
--cc=pinoaffe@airmail.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).