From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id QEuqGr/RWmfsjwAAqHPOHw:P1 (envelope-from ) for ; Thu, 12 Dec 2024 12:06:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id QEuqGr/RWmfsjwAAqHPOHw (envelope-from ) for ; Thu, 12 Dec 2024 13:06:23 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=j7GMhGQ3; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=GSRBgNgA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734005183; a=rsa-sha256; cv=none; b=ZGHE3bOMUF2DC+UbzJoUpKtqh6VoX+2zPP8bGgL7l6Zs3uyqyV/DV0N41SWur3uS5m2t37 JYtHoY90ZjsHlHQe5QXiZ2FeF2tUHH93CeiAPhkMWurGmKPbCF/09B8F5pMYoVYxL4HNED 1MUppMs3sWOn9WArb5cHrb3XNQ7VSkzSbtbe3ikrTl237r2v++3ZniczCkZyYLta+/lfib +azAItInbfWFL/zljawQQm89AbdrdSReDl0k8tNVOTNIrQbAmoQRAJOuz3Pfoohq+Lbl0/ KqJKf3/9F1XPaNcqv/Vi0IGGnuJBySlKQMpu+xSOlVGZsdIZneVQaKbvg9344g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=j7GMhGQ3; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=GSRBgNgA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734005183; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=yyrQaHGNg87a+pUF90YE0a02zWgelZFFgPxPYH0eLSE=; b=eJfLTSQTuwzosjmqH3zxfQ8ugn6WLVesYxkrffqOPYQIwYvekC43bS/bfIHKtdjahQDcgk 7QjAyji9nlxm6xD643gisdBJMTlEu8zkIj9ClcshqPIl4EqlqiBBrwoFdEEVerAmWnkoqw vW0RmZ5Q57BUm4M9nB3gKzpTLKmkcX5fQknIEj0DdLl95Gh4CoFerJfnhRafaYGaqfoJ4j ci+XM5riZ/KL1T9/o6SmZn+EHqTAXft+/ld0pzp8AQWRp9ebc4QTPX8/caBnpmpX5WAzGJ i3N0N/crwG2EqKwTL7wHpKhWBFVHY61wYmNWXfOxAmIMbzoivR5ri9WRlYtyEg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 318D71D277 for ; Thu, 12 Dec 2024 13:06:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLhxJ-0005yJ-5l; Thu, 12 Dec 2024 07:06:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLhxE-0005wY-AR for guix-patches@gnu.org; Thu, 12 Dec 2024 07:06:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLhxE-0005FS-2q for guix-patches@gnu.org; Thu, 12 Dec 2024 07:06:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=yyrQaHGNg87a+pUF90YE0a02zWgelZFFgPxPYH0eLSE=; b=j7GMhGQ32je0+S6Gy6m42TJtoQe/5TiV84dUeToouW+MAh85U/XfeRHtRvXq6okCFenx6byH+M72gmgLP20b4uVD4XZsXeItvCsjRTzQpZ2rnuWHfqlZy1XBfD1mpo9qIC+msS88CDAVVZjnCSOdTSlvG+4iJ3VABON7UIctxXBUmrzv62uv4tBOHZG/TcjJEyFtp5C25iROafkwA8GD2eJEZkNFX1LbwGiVPIFvkUZGVKuEyQwoN1/CgTmykfe7SCXya7nN4BN2VVVNNgy5xBfNxKZsSdj+kOipp13chW4pQHSuC1mCbt+mCpgk+yMUPHI0/j3l3STSLlxLRhtYQg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLhxD-0004Hs-Ey for guix-patches@gnu.org; Thu, 12 Dec 2024 07:06:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74481] [PATCH 1/2] git: Catch Git errors when updating cached checkout. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 12 Dec 2024 12:06:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74481 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 74481@debbugs.gnu.org, Josselin Poiret , Tobias Geerinckx-Rice , Mathieu Othacehe , Christopher Baines Received: via spool by 74481-submit@debbugs.gnu.org id=B74481.173400512416367 (code B ref 74481); Thu, 12 Dec 2024 12:06:03 +0000 Received: (at 74481) by debbugs.gnu.org; 12 Dec 2024 12:05:24 +0000 Received: from localhost ([127.0.0.1]:38054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLhwZ-0004Fv-Pp for submit@debbugs.gnu.org; Thu, 12 Dec 2024 07:05:24 -0500 Received: from mail-qv1-f47.google.com ([209.85.219.47]:52399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLhwX-0004Fk-60 for 74481@debbugs.gnu.org; Thu, 12 Dec 2024 07:05:21 -0500 Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6d8edad9932so3569156d6.0 for <74481@debbugs.gnu.org>; Thu, 12 Dec 2024 04:05:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734005061; x=1734609861; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yyrQaHGNg87a+pUF90YE0a02zWgelZFFgPxPYH0eLSE=; b=GSRBgNgAvulT6xknj3+7cOCzViz70kbLhctAznYvRCQKYSq1qDU5XkrrulIYiLQ8pw EPjxK8pvijH+jESh0ij/ND8qhxSxyS3UQ5jSUWaWbHxytvr4OCTrY4zjR8PF6dtRWV+5 nlgN9X0spi9dIkT818bDETeQwSQXWOyVAsD7PyT6GHuidrqh02GqmJiIZOmu0WjLBOaF myA7blF6FvHKwSCjPcR3yNliM+BeHtD8FhOhalPLh3jpvmavr9IUg66Db9f9u2zEVXfH w6/B3SCGV62EAsvRY0/zQR+GahJUH1b8IfqzTY1BjL6fyRTzILZVzDbe4w/AmDHTQwPd De8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734005061; x=1734609861; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yyrQaHGNg87a+pUF90YE0a02zWgelZFFgPxPYH0eLSE=; b=ooB7eMWzOghVHJPgMacciCl1siY38mIr9fvbVCxh70AP+f5Gqv/TdDLtTRlXt69c77 CeFrFcjMxEwzYyfsUTUfily8wefK8lOYl0xc3wntTruuXETf28DET3fAbTSb9BUg9h47 z8WVR4RDG9W2M3hEyEx10exw/HR7ybwau9bfbVEZ0S8NrLmeSLHDa5SQpkOTctvTmwZA UC7vlxnBS0XrWA/dt1xdQK/4dUjTLdYBWuZDGgMSIcrEi9Bczw/G3GPcghpjig0x9wEQ wLWZqmWHqQT8xPheJQPzLrF7Iwl4J+T7q4YIxB45euRffJr32pGNA2xVTEvVbEPJU/ba B1BQ== X-Gm-Message-State: AOJu0YzGYKQMNv8vABXWF958sm3IGZx6Hx/jEi5orGhzYlYZzvR2lttj 3vpjoqa9LEEKCgFUDRnhg7rNTfjdEF6ZJF9TMeUOFLvXamuRYQyTXlrpPO3YXPUugw3gfZiRVc0 GSFqvjGsyq+u1ERayXGZn4iaEayUa2aNy X-Gm-Gg: ASbGncudpxlCLgx5I/8Bb0HufE2fqchNBzSZTVhio2z/HLf5HcmKx5CRka9cKIN9Edk Wk5RSKUGz+xVRxQqsjgZdMzrsyxsEdRQS+i3ULA== X-Google-Smtp-Source: AGHT+IEWzoH8S6gTTkLs9XCNa6HQ8Hoh7NTkqRnsMbs/tfc5zIquAzFbndvdQSXv67sRAebPY39QthY4GaBCISXwVfI= X-Received: by 2002:a05:6214:212b:b0:6d8:8fbf:d1b7 with SMTP id 6a1803df08f44-6dae39cf5f2mr45149676d6.43.1734005060714; Thu, 12 Dec 2024 04:04:20 -0800 (PST) MIME-Version: 1.0 References: <87bjxhb0da.fsf@gnu.org> In-Reply-To: <87bjxhb0da.fsf@gnu.org> From: Simon Tournier Date: Thu, 12 Dec 2024 13:04:08 +0100 Message-ID: Content-Type: multipart/alternative; boundary="000000000000aec7360629118388" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.69 X-Spam-Score: -4.69 X-Migadu-Queue-Id: 318D71D277 X-Migadu-Scanner: mx12.migadu.com X-TUID: ku5rwPcbbzIr --000000000000aec7360629118388 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ludo, On Thu, 12 Dec 2024 at 12:35, Ludovic Court=C3=A8s wrote: > Sorry for not replynig earlier. I would avoid such a change: it changes > the semantics of =E2=80=98resolve-reference=E2=80=99 in a non-trivial and= hard-to-test > way. Could you explain more what you mean for "the semantics" of 'resolve-reference'? > Instead, since the goal is to address a problem that=E2=80=99s specific t= o > importers (or to one importer), I would suggest making a local change in > the importer itself, or in code that is shared among importers only. Well, from my understanding this suggestion is not possible because of the way it's implemented. Or the importer needs a rewrite. The crash comes from the call of 'update-cached-checkout' and it appears to me impossible to catch the error at the level of the importer because it's too late. If you think that's possible to have a local change somewhere in the importers, please point me because I'm clueless. :-) BTW, the bug of looking for an non-existent reference still remains. In other words, all the calls to Guile-Git as 'object-lookup repository' should be protected with some error-catch, IMHO. Cheers, simon --000000000000aec7360629118388 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ludo,

On Thu, 12 Dec 2024 at 12:35, Ludovic Cour= t=C3=A8s <ludo@gnu.org> wrote:

> Sorry for not replynig earlier.=C2=A0 I would avo= id such a change: it changes
> the semantics of =E2=80=98resolve-re= ference=E2=80=99 in a non-trivial and hard-to-test
> way.
Could you explain more what you mean for "the semantics&qu= ot; of 'resolve-reference'?

> Instead, s= ince the goal is to address a problem that=E2=80=99s specific to
> im= porters (or to one importer), I would suggest making a local change in
&= gt; the importer itself, or in code that is shared among importers only.

Well, from my understanding this suggestion is not pos= sible because of the way it's implemented.=C2=A0 Or the importer needs = a rewrite.=C2=A0 The crash comes from the call of 'update-cached-checko= ut' and it appears to me impossible to catch the error at the level of = the importer because it's too late.

If you thi= nk that's possible to have a local change somewhere in the importers, p= lease point me because I'm clueless. :-)

BTW, = the bug of looking for an non-existent reference still remains.=C2=A0 In ot= her words, all the calls to Guile-Git as 'object-lookup repository'= should be protected with some error-catch, IMHO.

= Cheers,
simon

--000000000000aec7360629118388--