From: Felipe Balbi <balbi@kernel.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 47726-done@debbugs.gnu.org
Subject: [bug#47726] [PATCH] gnu: Add vice emulator
Date: Mon, 26 Apr 2021 21:57:04 +0300 [thread overview]
Message-ID: <CAH8TKc8qFWP7DuiaaQ1kOBg4-g=20UmhJcOazn++P5YorptbuA@mail.gmail.com> (raw)
In-Reply-To: <87sg3cx4d6.fsf@nicolasgoaziou.fr>
Hi,
On Mon, Apr 26, 2021 at 9:55 PM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
> Hello,
>
> balbi@kernel.org writes:
>
> > From: Felipe Balbi <balbi@kernel.org>
> >
> > * gnu/packages/emulators.scm (vice): New variable.
>
> Thank you! I applied it.
Awesome, thanks :-)
> > Signed-off-by: Felipe Balbi <balbi@kernel.org>
>
> We don't have the habit of signing our own patches.
>
> > + (uri (string-append "mirror://sourceforge/vice-emu/releases/"
> > + name "-" version ".tar.gz"))
>
> Nitpick: we hard-code the name in the URI.
sure thing, I'll keep that in mind next time :-)
I did see a couple packages doing that, though.
--
balbi
prev parent reply other threads:[~2021-04-26 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 8:11 [bug#47726] [PATCH] gnu: Add vice emulator balbi
2021-04-26 18:55 ` bug#47726: " Nicolas Goaziou
2021-04-26 18:57 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH8TKc8qFWP7DuiaaQ1kOBg4-g=20UmhJcOazn++P5YorptbuA@mail.gmail.com' \
--to=balbi@kernel.org \
--cc=47726-done@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).