From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KOkkM0Y7Y2DQQgAAgWs5BA (envelope-from ) for ; Tue, 30 Mar 2021 16:52:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GIIpLUY7Y2B2bgAAB5/wlQ (envelope-from ) for ; Tue, 30 Mar 2021 14:52:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5D41E2A215 for ; Tue, 30 Mar 2021 16:52:54 +0200 (CEST) Received: from localhost ([::1]:37440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRFjh-0004NC-Cb for larch@yhetil.org; Tue, 30 Mar 2021 10:52:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRFd6-0004cT-49 for guix-patches@gnu.org; Tue, 30 Mar 2021 10:46:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41009) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRFd5-0000mz-Pb for guix-patches@gnu.org; Tue, 30 Mar 2021 10:46:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lRFd5-0002hg-NT for guix-patches@gnu.org; Tue, 30 Mar 2021 10:46:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47465] [PATCH] Added wlrctl to xdisorg Resent-From: Calum Irwin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 30 Mar 2021 14:46:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47465 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47465@debbugs.gnu.org Cc: maximedevos@telnet.be Received: via spool by 47465-submit@debbugs.gnu.org id=B47465.16171155539801 (code B ref 47465); Tue, 30 Mar 2021 14:46:03 +0000 Received: (at 47465) by debbugs.gnu.org; 30 Mar 2021 14:45:53 +0000 Received: from localhost ([127.0.0.1]:52553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRFcu-0002XF-Pl for submit@debbugs.gnu.org; Tue, 30 Mar 2021 10:45:53 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:33352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRBfa-0007XM-M8 for 47465@debbugs.gnu.org; Tue, 30 Mar 2021 06:32:23 -0400 Received: by mail-qt1-f181.google.com with SMTP id 1so10858933qtb.0 for <47465@debbugs.gnu.org>; Tue, 30 Mar 2021 03:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=rYv4fLoV708MvIWiDEpzdSD+5R99JU6oO7inD4yABHQ=; b=trx1mLbrsBqLUwVPEmq9Czsrp58ddH8NvP6iUFuGiaVacL99Rgd7z+cshHneLLdd7k KrUXX4/jowtDOFb0nfaS31PmUsKiqyeAPXRVFaYp3x8sgZHDT+QFPyw2SyIMp94rzvZC NYB/u7ofjq9kQK0vXBsKBcViA4dWOM5/+j4VfAdB72EdLnuwNWcmFCv/dn342FBj632E dVJQ/94ydeNLfp3oJpLKb4qCEFjr8zq/rb2md9KeXwcT+IHoCPns56PRV4h8RkM8ti85 f7o6WGKO5JK5Xf5+LX9bnKMkB280x6W/vhqe/Uk7ERKi6xQu7LSWUJ5rcDuvRCoer3nD +NoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rYv4fLoV708MvIWiDEpzdSD+5R99JU6oO7inD4yABHQ=; b=PGttSvlDGkLzEPvcUkJ3RL2xwjc2GlOK0kxxKBRPTA7mn845MOlzY2Dk+hO7h6B4bp 7bkySsNSZwboo897OCTMMLsnF9ZYq/cYrWfrrKq2yrsckLB9vRQVs9SoWAGq6nOpAAD/ UBiHoFEpMY1ebfUu7NoIxUBiAcLwKY8zaUA+RcX+h3fAxzv5ctrU0XZnH6EiyUS10k2C aSjvJGf9QSetQOiced4b9dMTlOuQhvIyU7x3sgZT+05M85v7jquLxSVkVrZqAdv0/Cfh qLXpXNH9aC9eXLEBiveXueCCefFmhcBs8eZtu1ngVx1RPEPsT9qexRHzNw0DFhUUa69s onqA== X-Gm-Message-State: AOAM533IpViGhbmLA+JK6qiO2yPlar1/E5M0pIkLrtSQV4C3Xy8GfvZS ozBOTyQFh0lLKCBSVmBqOtfDFyMtSUx9Gye0e619yZL4HVo= X-Google-Smtp-Source: ABdhPJxlkM83FTyoUZ0VXxiOWlmR0fOK6OBy3o8uRQu49jKhH+QAaFW3xLrNwkUPqMo33JFXL91bAiSWwgbq38tu9fI= X-Received: by 2002:ac8:68d:: with SMTP id f13mr26887979qth.300.1617100336953; Tue, 30 Mar 2021 03:32:16 -0700 (PDT) MIME-Version: 1.0 References: <20210329105622.5812-1-calumirwin1@gmail.com> <97eef11b9cbaeea1035fb05a2e8925c8350c085b.camel@telenet.be> In-Reply-To: <97eef11b9cbaeea1035fb05a2e8925c8350c085b.camel@telenet.be> From: Calum Irwin Date: Tue, 30 Mar 2021 23:32:05 +1300 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Tue, 30 Mar 2021 10:45:52 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617115974; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rYv4fLoV708MvIWiDEpzdSD+5R99JU6oO7inD4yABHQ=; b=UhJDHp2YqO+4WaDf/knJ1jtF5KmEXU92Hc56ICQiCCw7V6hQW5DBtCE+NYexUw6zmZz5gR WhOHVSwMg0SElUwTA1ENcu671uqvEkxNNKPZOjLicx1WByT0IGOTBqM76oJm6i47L/JRi5 k8Fni7yI+VseFpH3t1lh/WCbiFJgRMYxWcVZz5s46P9+WIj5N62RUfGwH4VBKH/DuNU9uD V+0JXEkVPSXaKsiWp766jAbxOWNxMRi6AYA8SmQmPPf5I5kLPFc+gPVVZlrhIBmeMZh+0V 2c/MlGvz1D24txq9z4ooXKKjkPAcvpmISt4m0TBkJ4hxIELB4IGl0BpN+9RIUg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617115974; a=rsa-sha256; cv=none; b=P5l6NGoem9L/1kXsnYXaVrcVOQTEa/r7HXAO1Jof7ZyVeNJyEYv846wg/DC4orvGfHLuom O4l3ZejKuXAO6cXUD71w1BUPZ8KoTYwOtBEzricfSTc6etWE0I/HnTBsRAUJVtQrI1L92w 8ktyOb4h309VIv3KIDDbNNcqZYwOtWC2TDDiLNA6P2GIvJXZNAN6bzjT3N7BGWHHDMFSm2 H3qJE4mTHEOM3jrmQ/xhRRyNxApB0xN8Yfg86RL718HZQ9WuT5f8riZ674+SgnPhulLSl9 BG1UKVS4w8pNqBteRaWsMPVz2cMyfbiYUJuZVJFzRFXiuXJQC/4NWJMdYVIR7Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=trx1mLbr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=trx1mLbr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5D41E2A215 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: MMjbACP+gSX5 freedesktop.scm seemed to be more for libraries while xdisorg was for miscellaneous applications and there were already a number of wayland specific applications in there (redshift-wayland, gammastep, bemenu...) As an aside, if you're a maintainer for the repo you may want to take a quick look at the README and HACKING documents which mention a doc/guix.info which looks to have been replaced with a texi file that info doesn't support the MENU-ITEM jumping to, for example, "Contributing" or "Building from git". Apologies if the commit message is screwed up again. It's supposed to say: gnu: Add wlrctl * gnu/packages/xdisorg.scm (wlrctl): New variables. On Tue, Mar 30, 2021 at 2:50 AM Maxime Devos wrote= : > > Hi, > > On Mon, 2021-03-29 at 23:56 +1300, calum wrote: > > --- > > gnu/packages/xdisorg.scm | 31 +++++++++++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > Please include a commit message. There are plenty of examples > in the git history to base you on. Also see section > 16.6 =E2=80=98Submitting Patches=E2=80=99 of the manual. > > > diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm > > index 56ac53edec..6d936efee6 100644 > > --- a/gnu/packages/xdisorg.scm > > +++ b/gnu/packages/xdisorg.scm > > @@ -80,6 +80,7 @@ > > You should add a copyright line. > > > #:use-module (gnu packages base) > > #:use-module (gnu packages bison) > > #:use-module (gnu packages check) > > + #:use-module (gnu packages cmake) > > #:use-module (gnu packages compression) > > #:use-module (gnu packages documentation) > > #:use-module (gnu packages flex) > > @@ -2788,3 +2789,33 @@ and execute @file{.desktop} files of the Applica= tion type.") > > "The @command{hsetroot} command composes wallpapers for X. > > This package is the fork of hsetroot by Hyriand.") > > (license license:gpl2+))) > > + > > +(define-public wlrctl > > + (package > > + (name "wlrctl") > > + (version "0.2.1") > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://git.sr.ht/~brocellous/wlrctl") > > + (commit (string-append "v" version)))) > > + (file-name (git-file-name name version)) > > + (sha256 > > + (base32 > > + "039cxc82k7x473n6d65jray90rj35qmfdmr390zy0c7ic7vn4b78"= )))) > > + (build-system meson-build-system) > > + (native-inputs > > + `(("pkg-config" ,pkg-config) > > + ("cmake" ,cmake) > > + ("scdoc" ,scdoc))) > > + (inputs > > + `(("libxkbcommon" ,libxkbcommon) > > + ("wayland" ,wayland))) > > If this is a wayland package, shouldn't this be in (gnu packages freedesk= top)? > I'm not sure myself where it should be, but at least that's were the 'way= land' > package resides. > > > + (home-page "https://git.sr.ht/~brocellous/wlrctl") > > + (synopsis "Command line utility for wlroots automation and extensi= ons") > > + (description > > + "wlrctl is a command line utility for miscellaneous wlroots Wayla= nd > > +extensions. At this time, wlrctl supports the foreign-toplevel-mangem= ent > > +(window/toplevel command), virtual-keyboard (keyboard command), > > +and virtual-pointer (pointer command) protocols.") > > + (license license:expat))) > > The package definition seems about right to me, but I don't have time to > actually test this. > > Greetings, > Maxime. >