From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 2GmdFi9l/WYgywAA62LTzQ:P1 (envelope-from ) for ; Wed, 02 Oct 2024 15:22:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 2GmdFi9l/WYgywAA62LTzQ (envelope-from ) for ; Wed, 02 Oct 2024 17:22:23 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="gl/Jy5vc"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=RR03Ma75; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727882543; a=rsa-sha256; cv=none; b=Bqp508O8QWweHFZoxuG0b+KKsX+u8KeBdZlHPxP2uRjJ8KymnTgNURKSVby0JbQtPTkZoj NA9usgYzW7VSIGAkupggLoBz6HNVxxoE0k7x/gnUqoEVm0b8gqeJul9WhsuO/mZKlcECME qgOWTb7ODWKNwUPG1iZEhFEyXfrmvimVKR9hXF3pCSZjNMK+M6w95wzpXUTGd7vFbjGh7p AW2P3Moju2bfyyliiLdMGSvp+U19TSGfh9bt0qHHvUeZLtuyKQwrP3LRpmGT1FuEP9O3cV Mq2DFVnlhzlW52/S7ytp4vUf86wmYerw80dl6sXAdH0V41xX56hvqvd7JRQXyw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="gl/Jy5vc"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=RR03Ma75; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727882543; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=L5byGQnOXpZXRvr7hBHqzhBkI/AdTYWNyjdDK2ACXo8=; b=UUn5wtg1flFeo/5VjToabQ0pzIorUuYJFrpgFoQ3gptSL6vAW4QCIf/h053U7AKVA7DdEm KCvuK1GI6FqvckXr2FseejzJnauy9kEmsDDjqAZYkFgrGIaykxdVOSkek2lAGj/xXEZY72 ZVX5kiOtodBkLUQ3G6St32fpfcS2s5cBxZxPigUiCgIDCHcxm3X2RC/9ojKxL4OUTrtl2a dIurtjztY69ObfbYHWpvKIApTNsp+7aRgWJa+4Yb7pFaljhJr5ZMuKW80DVtju4/txxyf8 4v2pFsCE5hortP03kLB9KgSitSzEUkGDJnojjmtcZ8ahouEJA/d9kUhBiKYnIQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D2C68349FA for ; Wed, 02 Oct 2024 17:22:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sw1Ap-0008EO-8N; Wed, 02 Oct 2024 11:21:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sw1AA-000866-Ks for guix-patches@gnu.org; Wed, 02 Oct 2024 11:21:15 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sw1A1-0005G9-R0 for guix-patches@gnu.org; Wed, 02 Oct 2024 11:21:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=L5byGQnOXpZXRvr7hBHqzhBkI/AdTYWNyjdDK2ACXo8=; b=gl/Jy5vc6pIuQcBPxXkcMKDIkR2ON8daxEHe7r4jfy5qpomc0W1iSBcLjKUMpPywszD6bWWxoiBiQQRNDtLxwdEkZew+R2mlH1xwmxTUMCouB71a/OhAW8Y7wtUNNpOUGGpZdIzvTzoTbi0ff/vANHU8NeKL8R8dWa4bxbVUtLcr8QNkIYG8PVs4nnx5JtCtkvG/MzMpakrUPzlbnRwDECgYukn5jaudPqb3hc4uGU1s5U1zX06uwezbPA5nSyDMiD3WOIZYmC+VsfCBtRCch0Y4GDnhF7MQONT8J3mitoFy76lx2hPo+GALbGpexFq4XVjVz+TpKLZuCam0pKvCmA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sw1A2-00079M-CU; Wed, 02 Oct 2024 11:21:06 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] [PATCH v3] adding jpm package Resent-From: Omar Bassam Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org, "Suhail Singh" Resent-Date: Wed, 02 Oct 2024 15:21:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Suhail Singh Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.172788243627360 (code B ref 72925); Wed, 02 Oct 2024 15:21:06 +0000 Received: (at 72925) by debbugs.gnu.org; 2 Oct 2024 15:20:36 +0000 Received: from localhost ([127.0.0.1]:59006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw19X-000779-6X for submit@debbugs.gnu.org; Wed, 02 Oct 2024 11:20:35 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:43146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sw103-0006Z0-Bi for 72925@debbugs.gnu.org; Wed, 02 Oct 2024 11:10:48 -0400 Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20b84bfbdfcso6966735ad.0 for <72925@debbugs.gnu.org>; Wed, 02 Oct 2024 08:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727881785; x=1728486585; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L5byGQnOXpZXRvr7hBHqzhBkI/AdTYWNyjdDK2ACXo8=; b=RR03Ma75qJjgv1IagYAnrGCo/dk+W70mowNc+DNdstJ5FzxrJeaabKGD/SEqNbzuv4 0nX62V+fCqEfZtl53nSQm4tuLnOTbNFacY7rzrdJLm0Ce9JRrV/BmIRFAvZfnwh+kAy0 mxDAk+1f02xFyW6cqhV26+OOtQTjKcKqQ2lokAG3oLXFXUL4np6T9su1uxTJSP/OfEQR spEv4eCLgr1EZqjC0kBcokYQTjfUKs6yHRNZpSifM2PxS3AJehuBaYGCKwp6MKKa13LV V6O0b6n3kKf86quJ8xsfC0MTT2qEk3EwuKsBw5ONCXw+wWCQSF30eSMWozsNde4cWyd7 d3DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727881785; x=1728486585; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L5byGQnOXpZXRvr7hBHqzhBkI/AdTYWNyjdDK2ACXo8=; b=duYQ7a6I5KI7MkhUobPMEq7o65O+LbgbN0m+99vzvdOz3gv+cXsaAJj6lItlrlYIKM lRBkCCwQv1GXAnX4JXGPnuM5jETCoP1Yzv+r1+iY6eYDJnqgf1ckxoWmiGg+DV4jy9Xx BOBKQQs9B7cu0XXNGsEs6s1od8iJorxHof/A4JQAXIVLT9G6RsBd2MK2HwFZXS6X8Rqo ZpcfEnH6vlS+pMJzNZ/p2FqyRSzn/NWs2O7WhKgMgl7CKkGq1fjdth3MSA18WJ5ouX2N FvO/Mzu/1pXPrxul1/wxrozpZT7VczKBazUUOgly0JQgdPvgkLAkZowBeXkJLYdC/AnN b/kQ== X-Gm-Message-State: AOJu0YyrJje1nOeJfc+T4m3YzJq+Y8T/UipY+zM35MaNeSALluR6BBVm zHV4cV/nMuxpt/N9iZvcNsOtTet1u/wsvf9GHGznPzvffm9+Vpc8zqqY8rdt10FYcL3zCeM3QU9 JP4wdVVuaj8hkG2alkAMQ3s8q9/k= X-Google-Smtp-Source: AGHT+IEjRx2SqspeVje1IACcBjEMrgouOXb7+/o7w0gsna2QPKfZxQDh0/kHHALsGL7Ni0pfFf1lpBMDYyhPFBMPhcc= X-Received: by 2002:a17:90a:d483:b0:2e0:8780:ecb with SMTP id 98e67ed59e1d1-2e18521f746mr5381751a91.12.1727881784429; Wed, 02 Oct 2024 08:09:44 -0700 (PDT) MIME-Version: 1.0 References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> In-Reply-To: <87plok7kkn.fsf@gmail.com> From: Omar Bassam Date: Wed, 2 Oct 2024 18:09:33 +0300 Message-ID: Content-Type: multipart/alternative; boundary="000000000000f9945e06237fd311" X-Mailman-Approved-At: Wed, 02 Oct 2024 11:20:22 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.23 X-Spam-Score: 0.23 X-Migadu-Queue-Id: D2C68349FA X-Migadu-Scanner: mx10.migadu.com X-TUID: D5yIkL7D/1O6 --000000000000f9945e06237fd311 Content-Type: text/plain; charset="UTF-8" Hi Suhail, I just submitted a new patch (v7) applying your suggestions and running guix lint and guix style. regarding your questions. I'll try to answer them below: On Tue, 1 Oct 2024 at 03:07, Suhail Singh wrote: > Omar, thank you for sending a revised patch. I have a few comments > relating to style and one unanswered question from our last exchange. > > > Subject: [bug#72925] [PATCH v3] adding jpm package > > In v4, could you please update the commit message to conform to the > ChangeLog format as noted in > . > Please see > > > for additional details. If you're using magit, > `magit-generate-changelog' can help with this. > > In your case the commit will probably look something like: > #+begin_quote > gnu: Add jpm. > > * gnu/packages/lisp.scm (jpm): New variable. > #+end_quote > > Omar Bassam writes: > > > +(define-public jpm > > + (package > > + (name "jpm") > > + (version "1.1.0") > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/janet-lang/jpm.git") > > + (commit (string-append "v" version)))) > > + (file-name (git-file-name name version)) > > + (sha256 (base32 > "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) > > There are no build errors with this, however, it's not clear how to > verify that the runtime behaviour of jpm is as expected. After > installing janet and jpm in a guix profile, running a command such as: > > #+begin_src sh > jpm install sh > #+end_src > > Results in the following: > > #+begin_example > $> jpm install sh > error: Read-only file system: > /gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/.cache > in os/mkdir [src/core/os.c] on line 1981 > in download-bundle > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 200, column 3 > in bundle-install > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 217, column 13 > in resolve-bundle-name > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 118, column 20 > in resolve-bundle > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 148, column 9 > in bundle-install > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] > on line 216, column 4 > in install > [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1.1.0/lib/janet/jpm/commands.janet] > (tail call) on line 190, column 20 > in run-main [boot.janet] on line 4432, column 16 > in cli-main [boot.janet] on line 4613, column 17 > #+end_example > > Could you please share an example code snippet which can be used to > verify correctness of the installation? > > This is expected as the jpm install command is meant to install janet packages globally which would be impure. To install janet packages to your local project directory, you need to add the "-l" flag as follows: jpm install -l sh Alternatively you can also set the JPM_TREE environment variable to install to a custom directory that you have access to. Maybe in the future we can add a "janet-build-system" that will allow us to add janet packages to the guix repository. > Additionally, it seems that the jpm repository comes with a test > (./test/installtest.janet and ./testinstall). However, it doesn't seem > like we're running it during the build. Could you please share the > reasons why? If possible, we should enable and run these tests. > > These tests are not testing the installation of jpm, they are only testing the "jpm install" command which will not work as I explained above. > > + (build-system copy-build-system) > > + (arguments > > + (list > > + #:phases #~(modify-phases %standard-phases > > + (add-after 'unpack 'fix-prefix-path > > + (lambda _ > > + (substitute* "configs/linux_config.janet" > > + (("/usr/local") #$output)) > > + (setenv "PREFIX" #$output))) > > > + (replace 'install > > + (lambda _ > > V3 doesn't cleanly apply due to whitespace issues on this (^) line. > Please fix. > > On a related note, in case you're not aware, please observe all the > steps listed in > . > Steps 3 and 4 recommend invoking guix lint and guix style which, unless > I'm mistaken, would've caught this issue. > > -- > Suhail > --000000000000f9945e06237fd311 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Suhail,
I just submitte= d a new patch (v7) applying your suggestions and running guix lint and guix= style.
regarding your questions. I'll try to answer the= m below:

On Tue, 1 Oct 2024 at 03:07, Suhail Singh <suhailsingh247@gmail.com> wrote:
Omar, thank you fo= r sending a revised patch.=C2=A0 I have a few comments
relating to style and one unanswered question from our last exchange.

> Subject: [bug#72925] [PATCH v3] adding jpm package

In v4, could you please update the commit message to conform to the
ChangeLog format as noted in
<https://guix.gnu.org/manua= l/devel/en/html_node/Submitting-Patches.html>.
Please see
<https://www.gnu.org/pre= p/standards/html_node/Change-Logs.html#Change-Logs>
for additional details.=C2=A0 If you're using magit,
`magit-generate-changelog' can help with this.

In your case the commit will probably look something like:
#+begin_quote
=C2=A0 gnu: Add jpm.

=C2=A0 * gnu/packages/lisp.scm (jpm): New variable.
#+end_quote

Omar Bassam <omar.bassam88@gmail.com> writes:

> +(define-public jpm
> +=C2=A0 (package
> +=C2=A0 =C2=A0 (name "jpm")
> +=C2=A0 =C2=A0 (version "1.1.0")
> +=C2=A0 =C2=A0 (source (origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (method git-fetch) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uri (git-reference<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (url "https://github.com/janet-lang/jpm.git") > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (commit (string-append "v" version))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-name (git-file= -name name version))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sha256 (base32 &quo= t;05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l"))))

There are no build errors with this, however, it's not clear how to
verify that the runtime behaviour of jpm is as expected.=C2=A0 After
installing janet and jpm in a guix profile, running a command such as:

#+begin_src sh
=C2=A0 jpm install sh
#+end_src

Results in the following:

#+begin_example
=C2=A0 $> jpm install sh
=C2=A0 error: Read-only file system: /gnu/store/ffmis4y6rld42biqx5lq4nvsjp0= bqiq6-jpm-1.1.0/lib/janet/.cache
=C2=A0 =C2=A0 in os/mkdir [src/core/os.c] on line 1981
=C2=A0 =C2=A0 in download-bundle [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqi= q6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 200, column 3
=C2=A0 =C2=A0 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq= 6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 217, column 13
=C2=A0 =C2=A0 in resolve-bundle-name [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp= 0bqiq6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 118, column 20
=C2=A0 =C2=A0 in resolve-bundle [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq= 6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 148, column 9
=C2=A0 =C2=A0 in bundle-install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq= 6-jpm-1.1.0/lib/janet/jpm/pm.janet] on line 216, column 4
=C2=A0 =C2=A0 in install [/gnu/store/ffmis4y6rld42biqx5lq4nvsjp0bqiq6-jpm-1= .1.0/lib/janet/jpm/commands.janet] (tail call) on line 190, column 20
=C2=A0 =C2=A0 in run-main [boot.janet] on line 4432, column 16
=C2=A0 =C2=A0 in cli-main [boot.janet] on line 4613, column 17
#+end_example

Could you please share an example code snippet which can be used to
verify correctness of the installation?


This is expected as the jpm install co= mmand is meant to install janet packages globally which would be impure.=C2= =A0
To install janet packages to your local project directory, yo= u need to add the "-l" flag as follows:
jpm install -l = sh

Alternatively you can also set the JPM_TREE env= ironment variable to install to a custom directory that you have access to.=

Maybe in the future we can add a "janet-buil= d-system" that will allow us to add janet packages to the guix reposit= ory.
=C2=A0
Additionally, it seems that the jpm repository comes with a test
(./test/installtest.janet and ./testinstall).=C2=A0 However, it doesn't= seem
like we're running it during the build.=C2=A0 Could you please share th= e
reasons why?=C2=A0 If possible, we should enable and run these tests.

=C2=A0
These tests are not testing the inst= allation of jpm, they are only testing the "jpm install" command = which will not work as I explained above.
=C2=A0
> +=C2=A0 =C2=A0 (build-system copy-build-system)
> +=C2=A0 =C2=A0 (arguments
> +=C2=A0 =C2=A0 =C2=A0(list
> +=C2=A0 =C2=A0 =C2=A0 #:phases #~(modify-phases %standard-phases
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (add-after &#= 39;unpack 'fix-prefix-path
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambd= a _
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (substitute* "configs/linux_config.janet"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (("/usr/local") #$output))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (setenv "PREFIX" #$output)))

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (replace '= ;install
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambd= a _

V3 doesn't cleanly apply due to whitespace issues on this (^) line.
Please fix.

On a related note, in case you're not aware, please observe all the
steps listed in
<https://guix.gnu.org/manua= l/devel/en/html_node/Submitting-Patches.html>.
Steps 3 and 4 recommend invoking guix lint and guix style which, unless
I'm mistaken, would've caught this issue.

--
Suhail
--000000000000f9945e06237fd311--