From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id UNspNx3/6mZOegAA62LTzQ:P1 (envelope-from ) for ; Wed, 18 Sep 2024 16:26:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id UNspNx3/6mZOegAA62LTzQ (envelope-from ) for ; Wed, 18 Sep 2024 18:26:06 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="u/gb9l7E"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="NqhCOdA/"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726676765; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=mwFnAV/834GkdJhWuQRm8S9dgpvkwbxshmeTTuhItx8=; b=AFiAp/GWJCKUXHBp7SeaUvp1egQ/ynLNmz+nlFNVorWv/TXzxO8UC+esZ/8MVvtnqh5VLK Zrdc7vCscL6UAQey3LyJ4QT2WdBPt05OU8v9co0w8uFaktM8SRwd4tsSV2yJgbcBB5WnBa Vgkz68CpcX9XHnRfBZwhXebn92SWMesZbFBOn0uHHOGQYe+5QgiUYIBNhtbW1AjrcwS2kS O6Cq0tr6U1b8oFw4ciavRjAdge+0uh9AbELgV8cDIH2wP9IolC4qluvksHGa3C94cPCpUU cemWSe7yONIygyv44v/1GJA7oRGqZr/mIVl/K5gS9mk3jJ8xSXy7pd3ijbx76Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="u/gb9l7E"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="NqhCOdA/"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726676765; a=rsa-sha256; cv=none; b=ebQiOetPa5RJWNB0srk3zouhyti+nCwuXn0DOTrL/eXE29aFI9WMYLm4NljiW3AZroidcN 4h/l8rkyFuo9/UmM4AOkF1kJg/4C76vHmm0dknWhbw8PlfvFTMOn/cC90vtjWp98Fo8atb vD+2qUqeDdOZ9mR3FX/41SKMne5NewzKlWoTGodNcLdslQ+qs9qRB+brIX370qjQUABbDv bx+zaSUArm//iDmqO0p6dz5y/aTeGMNpF3rl0WMylhQOOuR6BJL1u8Pe6iCtn6IDtFkmUL e+1PNVfYXNa6dTXHm/qa5AiuhLzx3WHck/gajlJjRvSKLT4u+oJ8tDhDDOY0gg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 823E67F32D for ; Wed, 18 Sep 2024 18:26:05 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqxV3-0003f7-C6; Wed, 18 Sep 2024 12:25:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqxUw-0003eT-Sb for guix-patches@gnu.org; Wed, 18 Sep 2024 12:25:46 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqxUw-00055t-G9 for guix-patches@gnu.org; Wed, 18 Sep 2024 12:25:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=mwFnAV/834GkdJhWuQRm8S9dgpvkwbxshmeTTuhItx8=; b=u/gb9l7EgCGaP434ip5g0LhP/wH7YvxjIEERNwoV1TOEoz+kXvZ88FAz0v1RcljJDiYtR9RrHQ8ztPxDf9GaAhwwSxTFkDCsTiQf1ITiDZKkh+dNArr25AQYQewO7IURjP0fBYHzac3Q39c46Gmt7VD3g3NzxD/g/ItQ7lrm2nWn33VqTNMXzRY7B1yeySKWCt99Wilkoa/7X2J8WIwD0Q+bB+4nJKi5rNCJlKUITatip+aae837agVhL9d9h0bNSk/iKZ7OD9rEZW8gEWsxolXWjbb6u0mxOE2eH/wtHkvhdKE+IkH2YW1RpAGBMlbSKxGZ9XYQStGaE37LSmjVBQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqxVC-0006E6-Cu; Wed, 18 Sep 2024 12:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] Adding JPM package for Janet Resent-From: Omar Bassam Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org, "Suhail Singh" Resent-Date: Wed, 18 Sep 2024 16:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Suhail Singh Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.172667672323617 (code B ref 72925); Wed, 18 Sep 2024 16:26:02 +0000 Received: (at 72925) by debbugs.gnu.org; 18 Sep 2024 16:25:23 +0000 Received: from localhost ([127.0.0.1]:59204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqxUY-00068D-Nq for submit@debbugs.gnu.org; Wed, 18 Sep 2024 12:25:23 -0400 Received: from mail-pj1-f50.google.com ([209.85.216.50]:45378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqwid-0003Us-8E for 72925@debbugs.gnu.org; Wed, 18 Sep 2024 11:35:51 -0400 Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2d877e9054eso4981310a91.3 for <72925@debbugs.gnu.org>; Wed, 18 Sep 2024 08:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726673669; x=1727278469; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mwFnAV/834GkdJhWuQRm8S9dgpvkwbxshmeTTuhItx8=; b=NqhCOdA/V+zKgrb14mOpOhpHBD+8PUjJe+GaX5wMIJsBOH929mLqpp6VhY+MAMrzge bQ5FIfyPlVtJ3scBhfrL2tBNeG9tpfvqSNNh0v+6te5OxPOtQa+y4+OKGvvt/Z0S36DC zUCA7ukp4vqtVUrm7MuMIxfI2HIxo9oHyNUa5r5/svZOnM8Pl+4NckbEae0Iq2k6T1aa jrQqD/7UlwEG4YH65oKMRsxI7f7UAx8N/c2VcPCnIFxw2sHVIaK/+yRrMCaT/xsfnk4P l63wFoKJVuat/SU+7e74hVR83TaTIGngwxA1zeVTXOy3eXx3C6LjElxXI2w4tKoNCUxh QP7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726673669; x=1727278469; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mwFnAV/834GkdJhWuQRm8S9dgpvkwbxshmeTTuhItx8=; b=Wvevo0y9nRb3YTFTZ3xVor3h0ez8i56yiDfQPUoseKprcJmeK6arZ94RLdL7kRiBRh k06+BtBz/JloT+jrv2bKXVeahDqfVU7l3bIarpPRGK/7a3yGbRnChgVgAIlm+z7yU/5q SC71/o9y+4EqjBVNlZDxrWYJ8xf56gcg/PIxVxGvMdxXxs2+qa+Qk6i9M14v9r07Y76j UxYMYab7CD6I73NQDmjb2DNdPgtRvEJfyg7Yz5E3Ess6RTjY+5Vy/LUPOGZ9mOgkbkbs NKwPPZboURyK0+qH+vpRqT+hJE/jqLDAgfBJMiAoId99EL05E9wFaMbFTMHXcwroqVGa Z/6w== X-Gm-Message-State: AOJu0Yz95aYM98dbhxlzd5tAMTqW2p4W9u9EAk7oyRPj6wJ5IFc0UhtG I2ghsWu65tz6TzLJZ7aWRhxAnCwh6XsD0fATG/q82Dfg07Zw//V4EtuYojPu9psZe81x/2nN1bz WX4uctp1ys0KZuU/WsXO+mL/Okng= X-Google-Smtp-Source: AGHT+IHr6WYR106NSUlJLQO69xRKrXNJ8/6fy0Cg0US3IVduYMpfyhTfHB4/L9bdImHFmZpYJFZoVdgoqb9advvKpds= X-Received: by 2002:a17:90a:f2c3:b0:2d8:b205:2345 with SMTP id 98e67ed59e1d1-2db9ffb416cmr25737931a91.23.1726673668901; Wed, 18 Sep 2024 08:34:28 -0700 (PDT) MIME-Version: 1.0 References: <950a7d3637ddf17be84f52dc2ae0aac2ce4c4be6.1725547778.git.omar.bassam88@gmail.com> <87h6adyua5.fsf_-_@gmail.com> In-Reply-To: <87h6adyua5.fsf_-_@gmail.com> From: Omar Bassam Date: Wed, 18 Sep 2024 18:34:17 +0300 Message-ID: Content-Type: multipart/alternative; boundary="000000000000ad9bdf0622668af8" X-Mailman-Approved-At: Wed, 18 Sep 2024 12:25:21 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 823E67F32D X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -8.95 X-Migadu-Spam-Score: -8.95 X-TUID: n9JkZwgQgtmT --000000000000ad9bdf0622668af8 Content-Type: text/plain; charset="UTF-8" Thank you for taking the time to look into my patch. Sorry, I'm new to Guix and to this workflow. So, forgive me if my questions look a bit naive: 1. What do you mean by reroll count for the patch? 2. I looked at the copy-build-system documentation. I'm not sure how it can be used here. I'm not just updating the shebang. As you can already see in the patch, I'm doing a lot of string substitutions in the source code itself because some values are hard coded. That's why I preferred to use the trivial-build-system to have more control of what I need to substitute. Thanks, Omar On Wed, 18 Sept 2024 at 16:19, Suhail Singh wrote: > Hi Omar, > > Thank you for submitting this patch. A few comments: > > Omar Bassam writes: > > > Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd > > --- > > gnu/packages/lisp.scm | 52 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 52 insertions(+) > > > > diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm > > index 5d4399f145..96698d375d 100644 > > Could you please update the reroll-count when you send amendments to the > patch? IIUC, this version should have been v2. > > > +(define-public jpm > > + (package > > + (name "jpm") > > + (version "1.1.0") > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/janet-lang/jpm.git") > > + (commit (string-append "v" version)))) > > + (file-name (git-file-name name version)) > > + (sha256 (base32 > "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) > > + (build-system trivial-build-system) > > ... > > + (substitute* (string-append %output "/bin/jpm") > > + (("/usr/bin/env janet") > > + (string-append #$janet "/bin/janet"))) > > Is my understanding correct that you're updating the shebang line here? > If so, would it be better to use the copy-build-system instead? If not, > could you please elaborate? If copy-build-system does indeed turn out > to be better suited, could you please send v3 of the patch? > > -- > Suhail > --000000000000ad9bdf0622668af8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you for taking the time to look into my patch. = Sorry, I'm new to Guix and to this workflow. So, forgive me if my quest= ions look a bit naive:
1. What do you mean by reroll count for th= e patch?
2. I looked at the copy-build-system documentation. I= 9;m not sure how it can be used here. I'm not just updating the shebang= . As you can already see in the patch, I'm doing a lot of string substi= tutions in the source code itself because some values are hard coded. That&= #39;s why I preferred to use the trivial-build-system to have more control = of what I need to substitute.

Thanks,
Om= ar

On Wed, 18 Sept 2024 at 16:19, Suhail Singh <suhailsingh247@gmail.com> wrote:
Hi Omar,

Thank you for submitting this patch.=C2=A0 A few comments:

Omar Bassam <omar.bassam88@gmail.com> writes:

> Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd
> ---
>=C2=A0 gnu/packages/lisp.scm | 52 +++++++++++++++++++++++++++++++++++++= ++++++
>=C2=A0 1 file changed, 52 insertions(+)
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index 5d4399f145..96698d375d 100644

Could you please update the reroll-count when you send amendments to the patch?=C2=A0 IIUC, this version should have been v2.

> +(define-public jpm
> +=C2=A0 (package
> +=C2=A0 =C2=A0 (name "jpm")
> +=C2=A0 =C2=A0 (version "1.1.0")
> +=C2=A0 =C2=A0 (source (origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (method git-fetch) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uri (git-reference<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (url "https://github.com/janet-lang/jpm.git") > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (commit (string-append "v" version))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-name (git-file= -name name version))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sha256 (base32 &quo= t;05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l"))))
> +=C2=A0 =C2=A0 (build-system trivial-build-system)
> ...
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (substitute* (string-append %output "/bin/jpm")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (("/usr/bin/env janet")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0(string-append #$janet "/bin/janet")))

Is my understanding correct that you're updating the shebang line here?=
If so, would it be better to use the copy-build-system instead?=C2=A0 If no= t,
could you please elaborate?=C2=A0 If copy-build-system does indeed turn out=
to be better suited, could you please send v3 of the patch?

--
Suhail
--000000000000ad9bdf0622668af8--