From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id iADaM8lE/mZMsQAA62LTzQ:P1 (envelope-from ) for ; Thu, 03 Oct 2024 07:16:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id iADaM8lE/mZMsQAA62LTzQ (envelope-from ) for ; Thu, 03 Oct 2024 09:16:25 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=lYdxwWP+; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=MmyiYm3j; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727939785; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Bo8YtopV9BAT9CLtcOU3du6+2Cu/55tHyrZx78T5LbM=; b=ADhKimHmqsVuf/SYKlk7K537WTPQQpshY4C+bXnQmyBKF1KkBUFzhhU1DUhnNSDsjZpcl7 LEJNK0elav3z8oZ+0bMdqq+r8gjLe8cliETrA6PnQ+pRAIBlKhFgRH8V/sTzUMIDIxaR8b Xm5CZuQKcpDm5xZ+nDOQQiDFRka31br884n1ojhqOFGxY+nIuOVmeVCLPQYLE/VDaqoS8L r+VU2gye+km3vGSbChyy+GZnC/SMu41YswWFMBkM6JA9CkfrDZG/8YIeVNU7LWmg3Hz6fl jK8nVsaRVQVVy5Auvka30TPq7b1TtLr/FYmLSb6zCygDcsMY4OiKhlYTWgmDXg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=lYdxwWP+; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=MmyiYm3j; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727939785; a=rsa-sha256; cv=none; b=SlH9sI7gzD96WM2wtkek6LOK0Tvfo/G6CGqm4yaoN6rviDCgPuuXnYumCkSAF5INaYPuU/ 0wABJctLLCimQSGDkI5EToMaLf93T3lvB6P8w8UqvBrvYzeE3OdVmt7c5UOefk/FivnE3h Vb+B7vdCM9N8qwYLseVddAdCT1usxKKWSD1BB0kBhB4kzIa3LAKWQVVhDh2JdFRcLQnL3O WJC75PlXqJBDxDwBf41rhXQHqmN2FL/TUauTEnsDhDMawebPyCjck2lXxvTIG0DsXWYqSV vFHbrTGpICQ8BVO/CtF7u8MZGs0ckSyGVjqEzlLa3hV56IMX0+MjyR8bAZGg0g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 617E378D8F for ; Thu, 03 Oct 2024 09:16:25 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swG4B-0003Ev-QB; Thu, 03 Oct 2024 03:16:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swG49-0003ER-BR for guix-patches@gnu.org; Thu, 03 Oct 2024 03:16:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swG49-0007ue-32 for guix-patches@gnu.org; Thu, 03 Oct 2024 03:16:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=Bo8YtopV9BAT9CLtcOU3du6+2Cu/55tHyrZx78T5LbM=; b=lYdxwWP+dp9pq6RrYlYH76ZiiLf4zCnVH89RWwxTid4qr65+yQB5UBm8yXozsc5Ia4+yvkREJuq5XtS5fLa7yte8eMUPW9rljcjF8q6v4QNJLddPl/7FsGfQW3Q4DobRjWV7JMbFfXDha5BedwCQBpPCrXoDFQyVS3KV46v3Hnr5hyupw4rbF9kdRESeBgukNyPtBRGPKOlEJ/b2i4kWM8y3P+sDCDau8fDMp0oRkppxirMwM1jiD82SYzlawkt/sSZtGVJkhlGrVGnAtL5BcpmrHJ9rXGJiQ8yrTrP6uZ5kHLNzlDCWD1/fXptS0dZZ4CsJJ+Nqb++Ibl/9NKN4Nw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1swG4A-0001Nr-Fe; Thu, 03 Oct 2024 03:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] [PATCH v3] adding jpm package Resent-From: Omar Bassam Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org, "Suhail Singh" Resent-Date: Thu, 03 Oct 2024 07:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Suhail Singh Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.17279397415277 (code B ref 72925); Thu, 03 Oct 2024 07:16:02 +0000 Received: (at 72925) by debbugs.gnu.org; 3 Oct 2024 07:15:41 +0000 Received: from localhost ([127.0.0.1]:59844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swG3p-0001N2-3h for submit@debbugs.gnu.org; Thu, 03 Oct 2024 03:15:41 -0400 Received: from mail-pj1-f53.google.com ([209.85.216.53]:47243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swG3n-0001Mb-2b for 72925@debbugs.gnu.org; Thu, 03 Oct 2024 03:15:39 -0400 Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2e1c91fe739so100429a91.2 for <72925@debbugs.gnu.org>; Thu, 03 Oct 2024 00:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727939671; x=1728544471; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Bo8YtopV9BAT9CLtcOU3du6+2Cu/55tHyrZx78T5LbM=; b=MmyiYm3jyzXdtzTwdwso9iUpvey+n3baHfPEo1VjeZXlahyszvF3PBjJif9f2mvB4+ e8NLRANOEecGch7v8l6YvXW2kr2K6+CG4c4FGTHqMoht8wF7rvPu0gUWtHfKwk7nZl8I 5NsjI/v2Jvor/JY1x9HE8NVoDyHIpZ70bl6CLlz/KBhRi6kEYNazSu96SOP/eMIdrmrB mmLODMUUS5K+ymkFk2zAjJ2tGP/jEvUKLqQR0eLM4J6ln62ebe/Oe8UXiVz+EhP9nNTn +QxI6qTKJduGGydOSRkHMcF2mwSzQutlbsia4KdgWyyuHV4Ng4KHM4qd2a8SLzcKrE4+ r+Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727939671; x=1728544471; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bo8YtopV9BAT9CLtcOU3du6+2Cu/55tHyrZx78T5LbM=; b=gOucb//d+RSfss9ut1ae3VhJJm/YqPeMFCPxEptCBNCv82Q/i8i5Tv/iMLDrJRIJQr tihDt/+36AMLrrBMYIgwngvYWqJPYxsiq91IUOG7jvWwM48/xv8REtSZgNSIV/iU/vXA YS6+8zamL6ajDpRQVjIdb8q9CDpNXyAWHCXmPcGUFgY+0pmiAt1H8gJ/gwBCjODPC07F ya9VkiP1qD9DI04Yc5BurF2vveD6H8YtzrXcaEEOey5q0FLhFa+qpKSVlP1wWucsenxX E8w7OIYSWAAoE7419Ixo8r/GcsGY4LGbPuHhUoARP2407DAy6gtEkeruWvh1n0x2Bovt u3Mg== X-Gm-Message-State: AOJu0YxgXHRigeCgG2e5+ga08PcJf7Uv2jGwo+L96++Z6wsdAsYvMMUc RWUt/c1cLVh6ZH8dicxpsgQsIRPXur/BYEVtBQ0MlFCj9gJbJFgkroObh//pnfqw3a5Yg1F2s3t rrzf1pddhfNwcHgb/3L6oNkjZinU= X-Google-Smtp-Source: AGHT+IGp+3ckR8gs5MPcE9mFxqoJozEQ3KWH7qwiL697CR62LuG42BjMql73q4x6IJQOlnVTXTP9W5ln1Uzekqg2rtg= X-Received: by 2002:a17:90b:164f:b0:2e0:927a:6928 with SMTP id 98e67ed59e1d1-2e1846c5140mr7634298a91.24.1727939671353; Thu, 03 Oct 2024 00:14:31 -0700 (PDT) MIME-Version: 1.0 References: <4e623d9571ff648ae1d1c6ffb8f9d73c421a5c10.1727683810.git.omar.bassam88@gmail.com> <87plok7kkn.fsf@gmail.com> <8734lev012.fsf@gmail.com> <875xqanty2.fsf@gmail.com> <87cyki9obi.fsf@gmail.com> <878qv69n0o.fsf@gmail.com> <874j5u7yme.fsf@gmail.com> In-Reply-To: <874j5u7yme.fsf@gmail.com> From: Omar Bassam Date: Thu, 3 Oct 2024 10:14:20 +0300 Message-ID: Content-Type: multipart/alternative; boundary="0000000000004df1e006238d4e26" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 4.43 X-Spam-Score: 4.43 X-Migadu-Queue-Id: 617E378D8F X-TUID: CAYu8Cd/lxOE --0000000000004df1e006238d4e26 Content-Type: text/plain; charset="UTF-8" Hi Suhail, I just have some questions before submitting v8 if you don't mind. just to make sure I understand correctly. On Thu, 3 Oct 2024 at 04:40, Suhail Singh wrote: > Suhail Singh writes: > > >> I don't think this should be related to this patch. > > > > As I mentioned previously, I believe your packaging of "jpm" is > > correctly done. > > After having taken a look at the source of JPM, I believe I was > previously mistaken. I don't believe the JPM packaging is correct. And > I do believe that the issue I was observing is related to the patch. > > Specifically, in the file "configs/linux_config.janet", among other > things, the below are set > > #+begin_src janet > :c++ "c++" > :c++-link "c++" > :cc "cc" > :cc-link "cc" > #+end_src > > Since Guix, as far as I know, doesn't have packages that provide c++ nor > cc, I believe the above need to be patched to refer to gcc and g++ > respectively. > > So we need to substitute the above "c++" and "cc" in the "configs/linux_config.janet" to point to the absolute path for the gcc and g++ packages? Should we also replace other commands that are hard-coded like "cp" and "chown" from coreutils the same way I did in my first initial patch? Further, I believe JPM should have a few propagated inputs: > - gcc-toolchain > - curl > - git > - nss-certs. > > I understand why we need gcc-toolchain. But why do we need curl, git and nss-certs? Please address the above two in v8 if you agree. If not, please help me > understand where I may have erred in the analysis above. > > -- > Suhail > Thanks, Omar --0000000000004df1e006238d4e26 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Suhail,
I just have some que= stions before submitting v8 if you don't mind. just to make sure I unde= rstand correctly.

On Thu, 3 Oct 2024 at 04:40, Suhail Singh <suhailsingh247@gmail.com> wrote= :
Suhail Singh &= lt;suhailsing= h247@gmail.com> writes:

>> I don't think this should be related to this patch.
>
> As I mentioned previously, I believe your packaging of "jpm"= is
> correctly done.

After having taken a look at the source of JPM, I believe I was
previously mistaken.=C2=A0 I don't believe the JPM packaging is correct= .=C2=A0 And
I do believe that the issue I was observing is related to the patch.

Specifically, in the file "configs/linux_config.janet", among oth= er
things, the below are set

#+begin_src janet
=C2=A0 =C2=A0:c++ "c++"
=C2=A0 =C2=A0:c++-link "c++"
=C2=A0 =C2=A0:cc "cc"
=C2=A0 =C2=A0:cc-link "cc"
#+end_src

Since Guix, as far as I know, doesn't have packages that provide c++ no= r
cc, I believe the above need to be patched to refer to gcc and g++
respectively.

So we need to substitute the above "c++" an= d "cc" in the=20 "configs/linux_config.janet" to point to the absolute path for th= e gcc=20 and g++ packages?=C2=A0
Should we also replace other command= s that are hard-coded like "cp" and "chown" from coreut= ils the same way I did in my first initial patch?

<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex"> Further, I believe JPM should have a few propagated inputs:
- gcc-toolchain
- curl
- git
- nss-certs.

I understand why we need gcc-toolchain. But why do we= need curl, git and nss-certs?

Please address the above two in v8 if you agree.=C2=A0 If not, please help = me
understand where I may have erred in the analysis above.

--
Suhail

Thanks,
Omar
--0000000000004df1e006238d4e26--