From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iG6qMSycJGMYWwAAbAwnHQ (envelope-from ) for ; Fri, 16 Sep 2022 17:54:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kJecMSycJGN3OwAA9RJhRA (envelope-from ) for ; Fri, 16 Sep 2022 17:54:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4DB3718FEF for ; Fri, 16 Sep 2022 17:54:20 +0200 (CEST) Received: from localhost ([::1]:57590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZDfX-0003Cy-6v for larch@yhetil.org; Fri, 16 Sep 2022 11:54:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZDfH-0003Bv-1I for guix-patches@gnu.org; Fri, 16 Sep 2022 11:54:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44925) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZDfG-0005x5-LE for guix-patches@gnu.org; Fri, 16 Sep 2022 11:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZDfG-00039Z-GN for guix-patches@gnu.org; Fri, 16 Sep 2022 11:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57857] [PATCH] gnu: busybox: fix the cross build. Resent-From: =?UTF-8?Q?=E8=B7=AF=E8=BE=89?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Sep 2022 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57857 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 57857@debbugs.gnu.org Received: via spool by 57857-submit@debbugs.gnu.org id=B57857.166334360712075 (code B ref 57857); Fri, 16 Sep 2022 15:54:02 +0000 Received: (at 57857) by debbugs.gnu.org; 16 Sep 2022 15:53:27 +0000 Received: from localhost ([127.0.0.1]:44003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZDeg-00038h-PG for submit@debbugs.gnu.org; Fri, 16 Sep 2022 11:53:27 -0400 Received: from mail-yw1-f194.google.com ([209.85.128.194]:33437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZDec-00038P-D7 for 57857@debbugs.gnu.org; Fri, 16 Sep 2022 11:53:24 -0400 Received: by mail-yw1-f194.google.com with SMTP id 00721157ae682-3457bc84d53so265433447b3.0 for <57857@debbugs.gnu.org>; Fri, 16 Sep 2022 08:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date; bh=mOtlZa4hTRWqo0TP0RQTu+bjAZtF6K3+wSDqG+8/AzQ=; b=bqvsAK3pBJWNyYYYo9OGIK5cVbjHxlsthUCfeZHlxDqPchXzZfFYFianlnq1wckBEv TU6JLeEMguMnjxhCL67czZ2AX/OBEfkiXuafOVruFMv4Gm08qoDfndW0XwPOwfly//97 u6gNXr/yhByWuettoC3z7KDsYbJg/yjzEBJHe1572TfxZNu9tRTaZBDbC+cUX4fClZG+ yCiO142AD5zHsh9GgKBaNMRhEBzrv9ZMWYALLtEBltVSz/Uk3JJwzwnDtxbDGHf5uHlZ fUhDsskcTVjmPlu2zifyzWgZYfzL19RN2vz40a8ZOGX8UGZyIb3DxGGrXpnqZshoAATj 4fXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=mOtlZa4hTRWqo0TP0RQTu+bjAZtF6K3+wSDqG+8/AzQ=; b=FZXYP+HLg7KqxZ6c5REfo4bOGAycPCh/C91aG0QvHJjVnr+cSZRNCDW5PGuSrTz4l8 IayZsLI6XohDGiZdA+6JPuQN4AXpKAkYt5dj6+1OSwFisk8RYGWpi3ibyYkKpjLLWozL +AeCJs1DjE3+NTYNpJrsEPcmMhrfOaZHD79MeTTmqe4ridodX1US0JbmWHvldWF2cJKK 74UgRuW4GpQu7cI8Da2nedFgZPR6TWj67fjQUR+86+wG0yv/wnsn9CjDA0LmSH35fVvs B85dnbU9/b4PCu8ChqBopD/swSoBNBfywP5a8JM1piGhxMOG2gByUUYLemO/01EK31Dq fd1A== X-Gm-Message-State: ACrzQf3tdNlXFmmErkeDQyQY6kjgXDJh7sybLZBuIRokovKBPqxSoJQh ARPCdegeiszKR/9NyqYGEWsLQ/hM7ICdHR2TNnQ= X-Google-Smtp-Source: AMsMyM6cZ5IVQqk/LLo6FsBC8CNDWidI0TMwuFTOa/4MWRyk6UCLLFRzDntQPLSguMvVfhJe1Be9Y8MuD4HeqYjn+c0= X-Received: by 2002:a81:83d0:0:b0:345:2499:cd76 with SMTP id t199-20020a8183d0000000b003452499cd76mr4956011ywf.500.1663343596776; Fri, 16 Sep 2022 08:53:16 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a0d:d0c6:0:0:0:0:0 with HTTP; Fri, 16 Sep 2022 08:53:14 -0700 (PDT) In-Reply-To: <3044d0d3-8a3b-baf7-b86b-55960e77eec1@telenet.be> References: <3044d0d3-8a3b-baf7-b86b-55960e77eec1@telenet.be> From: =?UTF-8?Q?=E8=B7=AF=E8=BE=89?= Date: Fri, 16 Sep 2022 15:53:14 +0000 Message-ID: Content-Type: multipart/mixed; boundary="00000000000039c5b405e8cd5cb6" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663343660; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=mOtlZa4hTRWqo0TP0RQTu+bjAZtF6K3+wSDqG+8/AzQ=; b=jPII6xX+PwkVIWBRWSaXw2u3GQlW9GmaB9dydKzVUftDnWTU/66g1Wl3iUrGXm+EM2vt/W ItQhjpVBevWrCw73xeBnQupjYwuk/CStDqXYpmmc/XpuKwYAyMrkXG7VrHMcxuPngO16gS HeDNiSh9r3wNee7j4SoQQi2wQ2Lw1f7dtcEX+dYIs0K3HuxGBkn+gZ7kZeD1xCEc5qQQHS scV2wJvtxd6pUdMvNCa1Ekl7q6sa7TVFlY4tYd5SeyVzCtQSP3qJaBDFd6maXb9L/hdv33 t9hEP2uvAcyY7russhhM2QZi6Qf43QMA4YYONGph0Q3YtzQo7kalAsnZNQBdcg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663343660; a=rsa-sha256; cv=none; b=UgSlmD0CTUHl4T0RFnj7WYpv/iSmfv2DLaD8xEGFbKgF7GP0YgvbpCzNxb11NfmlWiqqJf 1/2ibG2ZBJ6F5Pb3QY8m2qouwZsjnR8RqMiytgF1V4EUU7Erm/zUirJMpnasbR5T92FBdZ RWuc5zQCsIEswiQ4ywPXBWLcUPJJ+RNvuF8r20UwectlMtAuLAp54GGyLIJUWaTfOYrTZ+ JQqcH3ulyMKeU5FfXuZpB47iT9/bbTG3eb+du8uhmrN3+5gX4rXJtDC2ojY3I/p0nVyhao MCnTjTxD4DOa79vPrAW08ou1+0aw7ZVhg9PGCrgtqH3j6ngriL5Glup/gXzjlA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=bqvsAK3p; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.77 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=bqvsAK3p; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4DB3718FEF X-Spam-Score: 7.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: KYmpgt5FEZxy --00000000000039c5b405e8cd5cb6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2022-09-16 15:08 GMT, Maxime Devos : > > > On 16-09-2022 14:35, =E8=B7=AF=E8=BE=89 wrote: >> > > > + (if tests? > + (apply invoke "make" > + ;; "V=3D1" > + "SKIP_KNOWN_BUGS=3D1" > + "SKIP_INTERNET_TESTS=3D1" > + "check" make-flags) > + #t))) > > Can be simplified to > > (when tests? > (apply invoke "make" > ;; "V=3D1" > "SKIP_KNOWN_BUGS=3D1" > "SKIP_INTERNET_TESTS=3D1" > "check" make-flags)) > > > + `(#:tests? (if ,(%current-target-system) #f #t) > > That's the default, no need to mention it again here. > > + #:make-flags > + (let ((target ,(%current-target-system))) > + (if target > + (list (string-append "CROSS_COMPILE=3D" target "-")) > + (list))) > > Can be simplified: > > #:make-flags > ,(let ((target ,(%current-target-system))) > (if target > #~(list (string-append "CROSS_COMPILE=3D" ,target)) > #~'())) > > (the #~ makes the phasing more explicit, if you go for that, I recommend > turning the arguments into (arguments (list #:phases #~(modify-phases > ...) #:make-flags ...)), instead of using ` / , , to remain consistent.) > > Greetings, > Maxime > new patch vvvv --00000000000039c5b405e8cd5cb6 Content-Type: text/x-patch; charset="UTF-8"; name="0001-gnu-busybox-fix-the-cross-build.patch" Content-Disposition: attachment; filename="0001-gnu-busybox-fix-the-cross-build.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 RnJvbSBhYmIyMTVlNmRiZWU3M2ZlZmMzMmRiZmQxM2NmMTUzYjAyOGJjZjkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdSBIdWkgPGx1aHV4NzZAZ21haWwuY29tPgpEYXRlOiBGcmks IDE2IFNlcCAyMDIyIDE4OjM0OjU5ICswODAwClN1YmplY3Q6IFtQQVRDSF0gZ251OiBidXN5Ym94 OiBmaXggdGhlIGNyb3NzIGJ1aWxkLgoKKiBnbnUvcGFja2FnZXMvYnVzeWJveC5zY20gKGJ1c3li b3gpOiBmaXggY3Jvc3MgYnVpbGQKLS0tCiBnbnUvcGFja2FnZXMvYnVzeWJveC5zY20gfCAyNiAr KysrKysrKysrKysrKysrKy0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMo KyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2J1c3lib3guc2Nt IGIvZ251L3BhY2thZ2VzL2J1c3lib3guc2NtCmluZGV4IDQ0NjhkNzEwODguLjQ2MDEyMDVmOGIg MTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9idXN5Ym94LnNjbQorKysgYi9nbnUvcGFja2FnZXMv YnVzeWJveC5zY20KQEAgLTIsNiArMiw3IEBACiA7OzsgQ29weXJpZ2h0IMKpIDIwMTQgSm9obiBE YXJyaW5ndG9uIDxqbWRAZ251Lm9yZz4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxNiwgMjAxNywgMjAx OCwgMjAxOSwgMjAyMCBFZnJhaW0gRmxhc2huZXIgPGVmcmFpbUBmbGFzaG5lci5jby5pbD4KIDs7 OyBDb3B5cmlnaHQgwqkgMjAxOOKAkzIwMjIgVG9iaWFzIEdlZXJpbmNreC1SaWNlIDxtZUB0b2Jp YXMuZ3I+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMjIgTHVIdWkgPGx1aHV4NzZAZ21haWwuY29tPgog Ozs7CiA7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTQ1LDggKzQ2 LDkgQEAgKGRlZmluZS1wdWJsaWMgYnVzeWJveAogICAgICAgICAgICAgICAgICIwamZtOWZpazdu djR3MjF6cWRnODMwcGRkZ2tkam1wbG1uYTl5am45Y2sxbHduNHZzcHMxIikpKSkKICAgICAoYnVp bGQtc3lzdGVtIGdudS1idWlsZC1zeXN0ZW0pCiAgICAgKGFyZ3VtZW50cwotICAgICAnKCM6cGhh c2VzCi0gICAgICAgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAobGlzdAor ICAgICAgIzpwaGFzZXMKKyAgICAgICAjfihtb2RpZnktcGhhc2VzICVzdGFuZGFyZC1waGFzZXMK ICAgICAgICAgIChhZGQtYmVmb3JlICdjb25maWd1cmUgJ2Rpc2FibGUtdGltZXN0YW1wcwogICAg ICAgICAgICAobGFtYmRhIF8KICAgICAgICAgICAgICAoc2V0ZW52ICJLQ09ORklHX05PVElNRVNU QU1QIiAiMSIpKSkKQEAgLTY1LDcgKzY3LDcgQEAgKGRlZmluZS1wdWJsaWMgYnVzeWJveAogICAg ICAgICAgICAgICAgKCgiIyBDT05GSUdfSU5TVEFMTF9OT19VU1IgaXMgbm90IHNldCIpCiAgICAg ICAgICAgICAgICAgIkNPTkZJR19JTlNUQUxMX05PX1VTUj15IikpKSkKICAgICAgICAgIChyZXBs YWNlICdjaGVjawotICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgbWFrZS1mbGFncyAjOmFsbG93 LW90aGVyLWtleXMpCisgICAgICAgICAgIChsYW1iZGEqICgjOmtleSB0ZXN0cz8gbWFrZS1mbGFn cyAjOmFsbG93LW90aGVyLWtleXMpCiAgICAgICAgICAgICAgKHN1YnN0aXR1dGUqICcoInRlc3Rz dWl0ZS9kdS9kdS1zLXdvcmtzIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICJ0ZXN0c3Vp dGUvZHUvZHUtd29ya3MiKQogICAgICAgICAgICAgICAgKCgiL2JpbiIpICIvZXRjIikpICA7IHRo ZXJlIGlzIG5vIC9iaW4gYnV0IHRoZXJlIGlzIGEgL2V0YwpAQCAtOTMsMTcgKzk1LDIzIEBAIChk ZWZpbmUtcHVibGljIGJ1c3lib3gKICAgICAgICAgICAgICAoZGVsZXRlLWZpbGUgInRlc3RzdWl0 ZS93aGljaC93aGljaC11c2VzLWRlZmF1bHQtcGF0aCIpCiAgICAgICAgICAgICAgKHJtZGlyICJ0 ZXN0c3VpdGUvd2hpY2giKQogCi0gICAgICAgICAgICAgKGFwcGx5IGludm9rZSAibWFrZSIKLSAg ICAgICAgICAgICAgICAgICAgIDs7ICJWPTEiCi0gICAgICAgICAgICAgICAgICAgICAiU0tJUF9L Tk9XTl9CVUdTPTEiCi0gICAgICAgICAgICAgICAgICAgICAiU0tJUF9JTlRFUk5FVF9URVNUUz0x IgotICAgICAgICAgICAgICAgICAgICAgImNoZWNrIiBtYWtlLWZsYWdzKSkpCisgICAgICAgICAg ICAgKHdoZW4gdGVzdHM/CisgICAgICAgICAgICAgICAgIChhcHBseSBpbnZva2UgIm1ha2UiCisg ICAgICAgICAgICAgICAgICAgICAgICA7OyAiVj0xIgorICAgICAgICAgICAgICAgICAgICAgICAg IlNLSVBfS05PV05fQlVHUz0xIgorICAgICAgICAgICAgICAgICAgICAgICAgIlNLSVBfSU5URVJO RVRfVEVTVFM9MSIKKyAgICAgICAgICAgICAgICAgICAgICAgICJjaGVjayIgbWFrZS1mbGFncykp KSkKICAgICAgICAgIChyZXBsYWNlICdpbnN0YWxsCiAgICAgICAgICAgIChsYW1iZGEqICgjOmtl eSBvdXRwdXRzIG1ha2UtZmxhZ3MgIzphbGxvdy1vdGhlci1rZXlzKQogICAgICAgICAgICAgIChs ZXQgKChvdXQgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkpCiAgICAgICAgICAgICAgICAoYXBw bHkgaW52b2tlICJtYWtlIgogICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAi Q09ORklHX1BSRUZJWD0iIG91dCkKLSAgICAgICAgICAgICAgICAgICAgICAgImluc3RhbGwiIG1h a2UtZmxhZ3MpKSkpKSkpCisgICAgICAgICAgICAgICAgICAgICAgICJpbnN0YWxsIiBtYWtlLWZs YWdzKSkpKSkKKyAgICAgICM6bWFrZS1mbGFncworICAgICAgI34obGV0ICgodGFyZ2V0ICMkKCVj dXJyZW50LXRhcmdldC1zeXN0ZW0pKSkKKyAgICAgICAgICAoaWYgdGFyZ2V0CisgICAgICAgICAg ICAgIChsaXN0IChzdHJpbmctYXBwZW5kICJDUk9TU19DT01QSUxFPSIgdGFyZ2V0ICItIikpCisg ICAgICAgICAgICAgICcoKSkpKSkKICAgICAobmF0aXZlLWlucHV0cyAobGlzdCBwZXJsIDsgbmVl ZGVkIHRvIGdlbmVyYXRlIHRoZSBtYW4gcGFnZXMgKHBvZDJtYW4pCiAgICAgICAgICAgICAgICAg ICAgICAgICAgOzsgVGhlIGZvbGxvd2luZyBhcmUgbmVlZGVkIGJ5IHRoZSB0ZXN0cy4KICAgICAg ICAgICAgICAgICAgICAgICAgICBpbmV0dXRpbHMKLS0gCjIuMzcuMwoK --00000000000039c5b405e8cd5cb6--