From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id LkRFKyLhlWV+LgEAkFu2QA (envelope-from ) for ; Wed, 03 Jan 2024 23:35:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id WIeZIiLhlWUUUwEAe85BDQ (envelope-from ) for ; Wed, 03 Jan 2024 23:35:14 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=foundationdevices.com header.s=google header.b=PYaBmYEZ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704321314; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9MHDCVakUelkJ8kmyrDGTP5uyO+qFwS6kREoATIqEi8=; b=pntQwhlNryLB3u9rJv6Lw6gDwGAAM0ND1z7E6KLvQs0QslmDVCpnSYFVVJMbBZXJDGJxZX hZY9iHLjWAMwf/ZLuzf6cnlBOARKjG3aGhXJDlaNId85zcUxiGe8V5N/143v0hxbWuBT7V M64DLg4C0cD86NGWyqh0FlHuMT3np6Q7zBjIH40s5hbRK9TxmG9+600Nw6CHoCuEXtbocI j/chhmyUZdXWMUBy6JopQc8sbCBlHeYuC4CPo1rpgSHpdxoSDfnZSPues0R8J7pLEl7Jli cKL5UYUlpSbmFToisfmHMxz8DOLnRJ+vNYhx3tPh44Qcwb+C7SDO7KCZuhi6FA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=foundationdevices.com header.s=google header.b=PYaBmYEZ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704321314; a=rsa-sha256; cv=none; b=JivmZkPLDZh6q8nZWoT+0i53DSAZJt3stUjSts6aaV0c9qkSoX6eLx11sYoFCbrGbkN6Ro b7PDdrwhAkCdKkE2P8iYzZQAFh72D9mefBoOyACl+ZbgxQzXQFm3pJwd/FodUkdCbBB7Xr 7Boatf59Sj3npN55ISVVn+u86esKIFr29mYppk2vJzW8cketwfzAKG4spNEPXVXQjElgP4 c+k1UIsIDEkeSEbH+7oDkAnbb87w2d1GyDrwnttFj72N8T7eoi80rzhWOTDkmS4s8jXGw3 RZn0VXgWXyUNAJrr7Ld3Twr/fXiR4b0Pi+8QOB7CYdqcU5N6Za/8El9YgD+4Pw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3F9DB5E873 for ; Wed, 3 Jan 2024 23:35:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rL9pF-0004ed-67; Wed, 03 Jan 2024 17:35:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rL9pD-0004e8-Kw for guix-patches@gnu.org; Wed, 03 Jan 2024 17:34:59 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rL9pD-0003ns-Ct for guix-patches@gnu.org; Wed, 03 Jan 2024 17:34:59 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rL9pG-0004k7-E8 for guix-patches@gnu.org; Wed, 03 Jan 2024 17:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67623] [PATCH 0/3 gnome-team]: Require zlib in gdk-3.0.pc. Resent-From: Jean-Pierre De Jesus Diaz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Jan 2024 22:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67623 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Maxim Cournoyer Cc: Raghav Gururajan , Liliana Marie Prikler , 67623@debbugs.gnu.org Received: via spool by 67623-submit@debbugs.gnu.org id=B67623.170432128818203 (code B ref 67623); Wed, 03 Jan 2024 22:35:02 +0000 Received: (at 67623) by debbugs.gnu.org; 3 Jan 2024 22:34:48 +0000 Received: from localhost ([127.0.0.1]:53333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rL9p2-0004jW-2A for submit@debbugs.gnu.org; Wed, 03 Jan 2024 17:34:48 -0500 Received: from mail-ua1-x934.google.com ([2607:f8b0:4864:20::934]:56472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rL9oz-0004jF-49 for 67623@debbugs.gnu.org; Wed, 03 Jan 2024 17:34:46 -0500 Received: by mail-ua1-x934.google.com with SMTP id a1e0cc1a2514c-7cc94f8756aso2128723241.0 for <67623@debbugs.gnu.org>; Wed, 03 Jan 2024 14:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foundationdevices.com; s=google; t=1704321275; x=1704926075; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9MHDCVakUelkJ8kmyrDGTP5uyO+qFwS6kREoATIqEi8=; b=PYaBmYEZvmfTRA4TP7j50CCcaYmgcFuYwJ+DlmdXbchf/mVV3uujz/Z+c5ceaxifIO AILv+aRIYIUBW2CyR3bC5FG1z04p3kewTjfMi56nuiHllrtMgvV6XPeVrucscShgv6tq eO5wORqkzUEUMIVLFw7S7Sbn2LUN69RYJLgM71MVPZFInlht7GMiVrfglNCPMHaVgOw4 +D9exI4tF49zAvuPhmc/Xa78OZyWLnbE4wUtU7tHf7/AaXVb9Fa/jT0SXHhUgHZ/ib/A OkVZ6QmHaXA0BRNnVzI7N4tc+Rbt0aWTyLI3ezTM8BnXWUjw9G6FlClBjbCgNhCDiAk6 xFmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704321275; x=1704926075; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9MHDCVakUelkJ8kmyrDGTP5uyO+qFwS6kREoATIqEi8=; b=mdmGmanIgRI7Vr2MpsPT7Ia2WkkFkJKukj3/x0cAyeTyXFwTeqha1ZJUDhwZGD1Fvi f7TpHidES+h4AOWb0FQQkETn4qnhMZDf7c58mVTFmawmJJeyJ+W9RIEIX9IzmIki/WuI F6VE5/Z1v6TUL1MV4btbc5Vx/ZysZOqKz1hlkSXzst41BVRPMQZMxu5qMPEO1MnGrRKA PEFyiK1v9RHTMjXG2sc6yH3GunoaQRd67DQICuK1j5/Z7papKA++ukbTIq+rIUZlee6G K0KH/gw+knJGi/WX2QYJqQS9Y5jaIN2sgqgZsDGXbyvd5z8zsYrYuSko0PT8+tf/YKNS hRIQ== X-Gm-Message-State: AOJu0Yy7JGyqw27fQvzpZMY4A9uoGmAcRkoohIxjrpQCpnLL8o6/T8Vy ogC0t5Z+Yt1Q0UY5T2EG8unYM9e5CqFQHwc+BiOo1euDtbhqPQ== X-Google-Smtp-Source: AGHT+IGkXx2b7GAklEqjuyoGI1viFJxcA7O2IDlgNcaDYxYEpO5U+gX9rhQCXfz8v4San9sPbv+nQrfm0EE6gcmN2tE= X-Received: by 2002:a05:6102:3d86:b0:466:f130:9d0d with SMTP id h6-20020a0561023d8600b00466f1309d0dmr10069045vsv.32.1704321275719; Wed, 03 Jan 2024 14:34:35 -0800 (PST) MIME-Version: 1.0 References: <20231204133657.3448-1-jean@foundationdevices.com> <20231204133934.3890-1-jean@foundationdevices.com> <671b1d16807a8c4b55973de440e14d5816a5f048.camel@gmail.com> <87cyui5h8d.fsf_-_@gmail.com> In-Reply-To: <87cyui5h8d.fsf_-_@gmail.com> Date: Wed, 3 Jan 2024 22:34:25 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jean-Pierre De Jesus Diaz X-ACL-Warn: , Jean-Pierre De Jesus Diaz via Guix-patches From: Jean-Pierre De Jesus Diaz via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.29 X-Spam-Score: -5.29 X-Migadu-Queue-Id: 3F9DB5E873 X-Migadu-Scanner: mx10.migadu.com X-TUID: 7D1NLxLgTUsu Hello On Wed, Jan 3, 2024 at 7:50=E2=80=AFPM Maxim Cournoyer wrote: > > Hello, > > Liliana Marie Prikler writes: > > > Am Montag, dem 04.12.2023 um 14:39 +0100 schrieb Jean-Pierre De Jesus > > DIAZ: > >> * gnu/packages/gtk.scm (gtk+) : Add zlib. > >> > >> * gnu/packages/gtk.scm (gtk+) : Add 'add-zlib-to-gdk- > >> 3.0.pc > >> phase. > >> > >> Change-Id: I5efadebded159e0bd495ec07020b431413bd6e10 > >> --- > >> gnu/packages/gtk.scm | 13 ++++++++++++- > >> 1 file changed, 12 insertions(+), 1 deletion(-) > >> > >> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm > >> index 47d4c1808f..752c9f456d 100644 > >> --- a/gnu/packages/gtk.scm > >> +++ b/gnu/packages/gtk.scm > >> @@ -1032,7 +1032,9 @@ (define-public gtk+ > >> mesa > >> pango > >> wayland > >> - wayland-protocols)) > >> + wayland-protocols > >> + ;; When broadway backend is enabled gdk-3.0 requires > >> zlib. > >> + zlib)) > >> (inputs > >> (list colord-minimal ;to prevent a cycle with > >> inkscape > >> cups > >> @@ -1087,6 +1089,15 @@ (define-public gtk+ > >> (add-after 'unpack 'generate-gdk-pixbuf-loaders-cache-file > >> (assoc-ref glib-or-gtk:%standard-phases > >> 'generate-gdk-pixbuf-loaders-cache-file)) > >> + (add-after 'unpack 'add-zlib-to-gdk-3.0.pc > >> + (lambda _ > >> + ;; When -Dbroadway_backend=3Dtrue zlib is added as a > >> dependency to > >> + ;; gdk-3.0 but isn't done correctly and can cause pkg- > >> config to > >> + ;; not add the correct -L...-zlib/lib flag. > >> + (substitute* "meson.build" > >> + (("pc_gdk_extra_libs +=3D \\['-lz'\\]") "") > >> + (("^gdk_packages \\+=3D cairo_packages" all) > >> + (string-append all "\ngdk_packages +=3D ' > >> zlib'\n"))))) > > Is there a good reason to do it this way? I would hope that > > downstreams are already aware of this pkg-config variable. > > It seems a problem that should be taken to upstream. Then while > waiting, we could carry that patch, with a reference to the upstream > issue. > > Jean-Pierre, could you please check if this issue is known with the GTK > project, else file it on there tracker and reference it as a comment > with your patch? > > -- > Thanks, > Maxim I've searched on the GNOME's GitLab instance for related issues but found none so instead filed this one: https://gitlab.gnome.org/GNOME/gtk/-/issues/6306 Thanks, --=20 Jean-Pierre De Jesus DIAZ Foundation Devices, Inc.