unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Prafulla Giri <pratheblackdiamond@gmail.com>
To: 43060@debbugs.gnu.org
Subject: [bug#43060] usage text for git-lfs
Date: Wed, 26 Aug 2020 20:26:42 +0545	[thread overview]
Message-ID: <CAFw+=j3vDmk36p0k7NDGCVjTC0YC3iOHUgXzcAhxg5LxptM4Uw@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 434 bytes --]

Esteemed maintainers,

This is a follow-up to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=43044

Despite making the man pages available, the usage text (--help) was still
not available. While `git lfs --help` did bring up the man page, `git-lfs
--help` threw 'Sorry, no usage text found for "git-lfs"'.

The attached patch fixes that. And any calls to invalid lfs commands, or
just `git-lfs` (without any sub-commands).

Thank you.

[-- Attachment #1.2: Type: text/html, Size: 716 bytes --]

[-- Attachment #2: 0001-gnu-git-lfs-Make-usage-text-available.patch --]
[-- Type: text/x-patch, Size: 1258 bytes --]

From 933ae9f1eab0eb74f59f379877d9b442b6ec96f2 Mon Sep 17 00:00:00 2001
From: Prafulla Giri <pratheblackdiamond@gmail.com>
Date: Wed, 26 Aug 2020 20:16:54 +0545
Subject: [PATCH] gnu: git-lfs: Make usage text available.

* gnu/packages/version-control.scm (git-lfs)[arguments]: Add phase
'man-gen to make usage text available for embedding for the 'build
phase.
---
 gnu/packages/version-control.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 3b23e8b873..bc8e5f21ab 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -2591,6 +2591,12 @@ interrupted, published, and collaborated on while in progress.")
        #:install-source? #f
        #:phases
        (modify-phases %standard-phases
+         (add-before 'build 'man-gen
+           ;; Without this, the binary generated in 'build
+           ;; phase won't have any embedded usage-text.
+           (lambda _
+             (with-directory-excursion "src/github.com/git-lfs/git-lfs"
+               (invoke "make" "mangen"))))
          (add-after 'build 'build-man-pages
            (lambda _
              (with-directory-excursion "src/github.com/git-lfs/git-lfs"
-- 
2.28.0


             reply	other threads:[~2020-08-26 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 14:41 Prafulla Giri [this message]
2020-08-27 21:50 ` bug#43060: usage text for git-lfs Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFw+=j3vDmk36p0k7NDGCVjTC0YC3iOHUgXzcAhxg5LxptM4Uw@mail.gmail.com' \
    --to=pratheblackdiamond@gmail.com \
    --cc=43060@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).