unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Prafulla Giri <pratheblackdiamond@gmail.com>
To: 43288@debbugs.gnu.org
Subject: [bug#43288] Kdenlive Fixes #2
Date: Wed, 9 Sep 2020 15:05:45 +0545	[thread overview]
Message-ID: <CAFw+=j0reVBEg=rPRcLdonzutRGCdRzgEVH-ymuSRDv2+1ymgw@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 471 bytes --]

Esteemed maintainers,

This is a follow-up to https://issues.guix.gnu.org/43200 and addresses the
second issue mentioned there: breeze icon theme not being found by kdenlive.

Attached are two patches: the first makes the breeze icon theme available
to kdenlive during runtime by setting XDG_DATA_DIRS to include the 'share'
directory of the breeze package. The second updates kdenlive's source url
to follow permanent redirection as reported by `guix lint`.

Thank you.

[-- Attachment #1.2: Type: text/html, Size: 800 bytes --]

[-- Attachment #2: 0001-gnu-kde-kdenlive-Make-breeze-theme-available-at-runt.patch --]
[-- Type: text/x-patch, Size: 1801 bytes --]

From 01b6f35a272e569c9cd0beed2ed210f536e5e44f Mon Sep 17 00:00:00 2001
From: Prafulla Giri <pratheblackdiamond@gmail.com>
Date: Wed, 9 Sep 2020 14:02:24 +0545
Subject: [PATCH 1/2] gnu: kde: kdenlive: Make breeze theme available at
 runtime.

* gnu/packages/kde.scm (kdenlive):
[inputs]: Add breeze.
[arguments]: In wrap-program phase, add XDG_DATA_DIRS to include
the 'share' sub-directory of the package breeze.
---
 gnu/packages/kde.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index a9ac23e049..b22c3f0d8f 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -177,6 +177,7 @@ This package contains GUI widgets for baloo.")
          ("qtquickcontrols" ,qtquickcontrols)
          ("qtquickcontrols2" ,qtquickcontrols2)
          ("kiconthemes" ,kiconthemes)
+         ("breeze" ,breeze)
          ("qtgraphicaleffects" ,qtgraphicaleffects)
          ("kplotting" ,kplotting)))
       (arguments
@@ -192,10 +193,13 @@ This package contains GUI widgets for baloo.")
                       (qtdeclarative (assoc-ref inputs "qtdeclarative"))
                       (frei0r (assoc-ref inputs "frei0r-plugins"))
                       (ffmpeg (assoc-ref inputs "ffmpeg"))
+                      (breeze (assoc-ref inputs "breeze"))
                       (qml "/lib/qt5/qml"))
                  (wrap-program (string-append out "/bin/kdenlive")
                    `("PATH" ":" prefix
                      ,(list (string-append ffmpeg "/bin")))
+                   `("XDG_DATA_DIRS" ":" prefix
+                     ,(list (string-append breeze "/share")))
                    `("QT_PLUGIN_PATH" ":" prefix
                      ,(map (lambda (label)
                              (string-append (assoc-ref inputs label)
-- 
2.28.0


[-- Attachment #3: 0002-gnu-kdenlive-Change-source-URL-to-follow-permanent-r.patch --]
[-- Type: text/x-patch, Size: 985 bytes --]

From 84b32417f838f703aa37a69ff7b974341504c046 Mon Sep 17 00:00:00 2001
From: Prafulla Giri <pratheblackdiamond@gmail.com>
Date: Wed, 9 Sep 2020 14:55:22 +0545
Subject: [PATCH 2/2] gnu: kdenlive: Change source URL to follow permanent
 redirection.

* gnu/packages/kde.scm (kdenlive)[source]: Change url to follow
permanent redirection.
---
 gnu/packages/kde.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index b22c3f0d8f..75e7f39c4b 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -142,7 +142,7 @@ This package contains GUI widgets for baloo.")
        (origin
          (method git-fetch)
          (uri (git-reference
-               (url "https://anongit.kde.org/kdenlive.git")
+               (url "https://invent.kde.org/multimedia/kdenlive")
                (commit (string-append "v" version))))
          (file-name (string-append name "-" version "-checkout"))
          (sha256
-- 
2.28.0


             reply	other threads:[~2020-09-09  9:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09  9:20 Prafulla Giri [this message]
2020-09-14 21:03 ` bug#43288: Kdenlive Fixes #2 Ludovic Courtès
2020-09-15  5:31   ` [bug#43288] " Prafulla Giri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFw+=j0reVBEg=rPRcLdonzutRGCdRzgEVH-ymuSRDv2+1ymgw@mail.gmail.com' \
    --to=pratheblackdiamond@gmail.com \
    --cc=43288@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).