From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QIMjKEdJzF4pHwAA0tVLHw (envelope-from ) for ; Mon, 25 May 2020 22:40:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EF/vI0dJzF4AMgAAbx9fmQ (envelope-from ) for ; Mon, 25 May 2020 22:40:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 18B579404C3 for ; Mon, 25 May 2020 22:40:07 +0000 (UTC) Received: from localhost ([::1]:58240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdLlO-0000vb-2s for larch@yhetil.org; Mon, 25 May 2020 18:40:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdLlK-0000vG-Cl for guix-patches@gnu.org; Mon, 25 May 2020 18:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdLlK-0004Ig-1y for guix-patches@gnu.org; Mon, 25 May 2020 18:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdLlJ-0001Ec-UU for guix-patches@gnu.org; Mon, 25 May 2020 18:40:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41345] 000-update-python-argon2-cffi.patch Resent-From: Josh Marshall Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 May 2020 22:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41345 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Marius Bakke Cc: 41345-done@debbugs.gnu.org Received: via spool by 41345-done@debbugs.gnu.org id=D41345.15904463944728 (code D ref 41345); Mon, 25 May 2020 22:40:01 +0000 Received: (at 41345-done) by debbugs.gnu.org; 25 May 2020 22:39:54 +0000 Received: from localhost ([127.0.0.1]:42749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdLlB-0001EB-Ov for submit@debbugs.gnu.org; Mon, 25 May 2020 18:39:54 -0400 Received: from mail-vk1-f182.google.com ([209.85.221.182]:34724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdLlA-0001Dy-2G for 41345-done@debbugs.gnu.org; Mon, 25 May 2020 18:39:52 -0400 Received: by mail-vk1-f182.google.com with SMTP id w67so460131vkw.1 for <41345-done@debbugs.gnu.org>; Mon, 25 May 2020 15:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PBTtOdc9B3hRlKAeRwmed22HYqSKYJbVWwQZ2AolLFw=; b=gRa5kx4rDPY7OpzcTMpfOKvx2EcOqItSSovRe8jaDb8Kgwbcwz/7Xj+HoDTjZpGt0y V3zBBe/01nkai+NF1jqo0d4gyoqhUoBuHFxmQpK+58RN+fCS58menYFWgiKuilm6e7CB NOCT1SZauIn4O++4V6WeT6HEbc6XbftS7+348GijDMbgyYFYB1Ad9mMn1gT9HmI0lfff GtO+MSeC4LXGZ7VEXN/FfzXtIISgQbLgw/dJaprKQZ81OOZnzEgZN/12e70u5aU6ccfY nSi+VC5IHi1iAnEMoe0s7qlbhcnqC+ZRLsDe1IJjSShg6K99fbm9C80DEt4o1Aera/Yr 8PqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PBTtOdc9B3hRlKAeRwmed22HYqSKYJbVWwQZ2AolLFw=; b=AmtCNcjVbrbXK8UgEtDIE2BOBGOzWhRqb/tdytKZfngTzRa+TCmPthPAMnCvdEcUXx vsZG2vBzUO7TFilQVJfMuSsHd48XS7YWIkpMdJ9YAwwRUar+4xWiFDrtLo8zZ35Iuz9G k19K1SHVXyafXmc7+R9xoWg6YNb5UWGWpzK1QI5X9Km6wgeThZQQf643GjxHpmkikRSX HYCvrbKNpDjWb+X0JQVRCtTjTHMyZ6juX30TxgJEpTaA/Fh2TbOPcbg9+8QMqn9o89vP pll16f+sqLDUYyP/m7lLFHBAa7cReCXZbD9aTQCnokWoLtzervEAhieaauNURZ364aNB eILQ== X-Gm-Message-State: AOAM531RLMODofWo96j21DdukbtbK/5gZhBT7/NSflF/Tzlw00HOGwB5 7yxqKtsMxLmuDNFXL7MqUUr3fWF9+tbFpKI/WMk= X-Google-Smtp-Source: ABdhPJxeQQXWBk0ohlMtroJwmfatyP7Ja2VMo0GrmdSO9ILOc9tWN33vdwt+0It+PxMkMFEJgptxG1YCBakK2ogTNoY= X-Received: by 2002:a1f:9193:: with SMTP id t141mr20409697vkd.8.1590446386386; Mon, 25 May 2020 15:39:46 -0700 (PDT) MIME-Version: 1.0 References: <87o8qi9v8i.fsf@devup.no> <87lflg6owx.fsf@gnu.org> <87a71v7l5d.fsf@gnu.org> In-Reply-To: <87a71v7l5d.fsf@gnu.org> From: Josh Marshall Date: Mon, 25 May 2020 18:39:34 -0400 Message-ID: Content-Type: multipart/alternative; boundary="000000000000e51e7905a680a792" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.7 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=gRa5kx4r; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: LubhdmxF6M8I --000000000000e51e7905a680a792 Content-Type: text/plain; charset="UTF-8" If those are the particular expectations and standards, should they change from only policy in the manual to something enforced by a git pre-commit hook? On Mon, May 25, 2020, 17:35 Marius Bakke wrote: > Josh Marshall writes: > > > When reading https://guix.gnu.org/manual/en/guix.html#Submitting-Patches > > I do not see guidance on this particular aspect of sending patches. > > What do I need to alter, and should those details be added to the > > manual? > > It's not very prominent, but it's there: > > Please write commit logs in the ChangeLog format (see Change Logs in > GNU Coding Standards); you can check the commit history for examples. > > With a link to the GNU Coding Standards document: > > https://www.gnu.org/prep/standards/standards.html#Change-Logs > > Perhaps we could include a condensed version as it borders on TL;DR. > > > git commit -am "Updating python-argon2-cffi to 20.1.0" > > If you omit the -m, git will open your $EDITOR where you can contemplate > on how best to communicate what the patch does, and write over multiple > lines. There are helper functions in Emacs to fill out the boring > "* gnu/packages/file-name.scm (variable):" part of the commit message. > > When unsure, I recommend running "git log the-file.scm" and look at > previous commit messages for inspiration. > > Thanks for persevering! :-) > --000000000000e51e7905a680a792 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
If those are the particular expectations and standards, s= hould they change from only policy in the manual to something enforced by a= git pre-commit hook?

On Mon, May 25, 2020, 17:35 Marius Bakke <marius@gnu.org> wrote:
Josh Marshall <joshua.r.marshall.199= 1@gmail.com> writes:

> When reading https://guix= .gnu.org/manual/en/guix.html#Submitting-Patches
> I do not see guidance on this particular aspect of sending patches. > What do I need to alter, and should those details be added to the
> manual?

It's not very prominent, but it's there:

=C2=A0 Please write commit logs in the ChangeLog format (see Change Logs in=
=C2=A0 GNU Coding Standards); you can check the commit history for examples= .

With a link to the GNU Coding Standards document:

=C2=A0 https://www.gnu.org/p= rep/standards/standards.html#Change-Logs

Perhaps we could include a condensed version as it borders on TL;DR.

>=C2=A0 git commit -am "Updating python-argon2-cffi to 20.1.0"=

If you omit the -m, git will open your $EDITOR where you can contemplate on how best to communicate what the patch does, and write over multiple
lines.=C2=A0 There are helper functions in Emacs to fill out the boring
"* gnu/packages/file-name.scm (variable):" part of the commit mes= sage.

When unsure, I recommend running "git log the-file.scm" and look = at
previous commit messages for inspiration.

Thanks for persevering!=C2=A0 :-)
--000000000000e51e7905a680a792--