From: Stephen Webber <montokapro@gmail.com>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 37863@debbugs.gnu.org
Subject: [bug#37863] [PATCH] gnu: emacs-helm-projectile: Apply patch.
Date: Tue, 29 Oct 2019 00:06:30 +0000 [thread overview]
Message-ID: <CAFaJjfHwm+4mVVTX9OjTrtn62G2YXYPpB0xk4+EgMck+vdwRaA@mail.gmail.com> (raw)
In-Reply-To: <87r22xj5cs.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2370 bytes --]
Mathieu,
Great! I chose this PR because I wanted to learn when patching was deemed
appropriate. Thank you for the suggestion.
On Mon, Oct 28, 2019 at 2:45 PM Mathieu Othacehe <m.othacehe@gmail.com>
wrote:
>
> Hello Stephen,
>
> As this project seems unmaintained and the last release was in 2016, I
> think the best option would be to package a 0.14.0-1 based on
> helm-projectile last commit.
>
> Thanks,
>
> Mathieu
>
> Stephen Webber writes:
>
> > * gnu/packages/emacs-xyz.scm (emacs-helm-projectile): Apply patch.
> > * gnu/packages/patches/emacs-helm-projectile-require-dash.patch: New
> file.
> > ---
> > gnu/packages/emacs-xyz.scm | 4 +++-
> > .../emacs-helm-projectile-require-dash.patch | 13 +++++++++++++
> > 2 files changed, 16 insertions(+), 1 deletion(-)
> > create mode 100644
> gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> >
> > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> > index 8c3c50efdc..5ed2cf67bc 100644
> > --- a/gnu/packages/emacs-xyz.scm
> > +++ b/gnu/packages/emacs-xyz.scm
> > @@ -6967,7 +6967,9 @@ as well as features for editing search results.")
> > (commit (string-append "v" version))))
> > (file-name (git-file-name name version))
> > (sha256
> > - (base32
> "0lph38p112fridighqcizpsyzjbv7qr3d8prbfj6w6q6gfl6cna4"))))
> > + (base32 "0lph38p112fridighqcizpsyzjbv7qr3d8prbfj6w6q6gfl6cna4"))
> > + (patches
> > + (search-patches "emacs-helm-projectile-require-dash.patch"))))
> > (build-system emacs-build-system)
> > (propagated-inputs
> > `(("emacs-dash" ,emacs-dash)
> > diff --git
> a/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> b/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> > new file mode 100644
> > index 0000000000..9da3deff50
> > --- /dev/null
> > +++ b/gnu/packages/patches/emacs-helm-projectile-require-dash.patch
> > @@ -0,0 +1,13 @@
> > +Make dash dependency explicit - this issue is resolved in master and is
> > +documented at https://github.com/bbatsov/helm-projectile/issues/120
> > +
> > +--- a/helm-projectile.el
> > ++++ b/helm-projectile.el
> > +@@ -41,6 +41,7 @@
> > +
> > + (require 'projectile)
> > + (require 'cl-lib)
> > ++(require 'dash)
> > + (require 'grep)
> > + (require 'helm)
> > + (require 'helm-types)
>
>
[-- Attachment #2: Type: text/html, Size: 3225 bytes --]
next prev parent reply other threads:[~2019-10-29 0:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 3:16 [bug#37863] [PATCH] gnu: emacs-helm-projectile: Apply patch Stephen Webber
2019-10-28 14:45 ` Mathieu Othacehe
2019-10-29 0:06 ` Stephen Webber [this message]
2019-10-29 1:46 ` [bug#37863] [PATCH v2] gnu: emacs-helm-projectile: Update package Stephen Webber
2019-10-29 8:27 ` bug#37863: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFaJjfHwm+4mVVTX9OjTrtn62G2YXYPpB0xk4+EgMck+vdwRaA@mail.gmail.com \
--to=montokapro@gmail.com \
--cc=37863@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).