From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CEJtETdVKGcDQwAA62LTzQ:P1 (envelope-from ) for ; Mon, 04 Nov 2024 05:01:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id CEJtETdVKGcDQwAA62LTzQ (envelope-from ) for ; Mon, 04 Nov 2024 06:01:43 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=FYKkCePq; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=S2qCEQcs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730696502; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Mw6wInM+NQlHGIwsnZQXzgWdXLwP0e2onp3COkp1zgE=; b=O92p17373orsuD0Ukub17CXHJvey6SVhIhVJmhSM6MyRhEfOLW++m5VEeWjdOeHsMuBgxa Ds0ZFakdJ0tBoM1CXh8Y7LjSl9Xd9SokK/LNuZpk47E/bfO6rsnQSax1Y8fCgge3NzTTio /l/KprzTCqQcgXpFlqC5FSqz9VwZN3lTpTt6OlNCj45PiZIqrl/lSXdeXIHbuZ1eoG/7fe UKKz//ee672xl3290fOQi/QyfMxVYdPmCP9KbJpozI3mJpRpcZjhCgxQdbfeOtLdp0Ebit H0Z5qPcMtTJX/5jYDSJ0MtXtnBROf06xRgGBb/94xUYv/Nxo81A/F7hi2B8kmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=FYKkCePq; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=S2qCEQcs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730696502; a=rsa-sha256; cv=none; b=TLzmoE9T3z2ZzngBFgwjI7MOxkuOj3ytJx+tk4ysPUR9zUc0GME+ES+JF+JjxzLr6aUI1N GjlUo7QrkrlmrRLlko3GzP9oVxMdXA9KBZySMPOotJtoTPNGgvgqhDqd0j+y40quZL8vQX 02OWCWAvaFBaKnVOTQOfFt+hnK1oWph+GH/A5Z0cWve9hVyvc1HT5Qt1MDhGyEOflq9ByB r/LIZ3EUa7X1e+6IY4XL0NgVfbkXnoJmKtJJ9bIu3QEM0w6A/QTMs5FDuGkTbePVKDKPMr +nKfnfS3jUsS2RUKGQ2HBRffGCFjgYo3DvFHhov+kIs9frq9wcc1l4etY6EVdA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 69B477CD5F for ; Mon, 04 Nov 2024 06:01:41 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7pDN-00062m-Gm; Mon, 04 Nov 2024 00:01:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7pD8-00062D-N4 for guix-patches@gnu.org; Mon, 04 Nov 2024 00:01:14 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t7pD4-0006Mm-Eb for guix-patches@gnu.org; Mon, 04 Nov 2024 00:01:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:MIME-Version:To:In-Reply-To:References:Subject; bh=Mw6wInM+NQlHGIwsnZQXzgWdXLwP0e2onp3COkp1zgE=; b=FYKkCePqsHd5NdJY+0wYL6xQwN+AyOf2EfAwM6cLMUYcLzYomtoefYOBt6b41GcxkdfQ7kvvAAXgq6hh3ApJaCemtD/2UGHesc1YTME/SqjKW/RWd+P/gpeW6gboV6B4qpQ5hWvgV9dmmT+kynHzimeqzzgeKDK3jtV6HTNGBH/Pz4F1KYF+bqR5a210dndatvoP29ZYbggi8h6CtRFqxPrmjYsr9H5LlyyndIL8G0sRTlZYb6NETMUpJte4RO5CiejffFjLSdFT2kGjq5IRfHJ/I3dJImkqW0eafeOW6TN0p88h8kGDlEECbk+X1t0TeCr4QmBsHEuC8s3BLOhtrA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t7pD4-0003hc-8q for guix-patches@gnu.org; Mon, 04 Nov 2024 00:01:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74173] [PATCH] gnu: Add emacs-eslint-flymake. References: In-Reply-To: Resent-From: Javier Olaechea Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Nov 2024 05:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74173 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74173@debbugs.gnu.org Received: via spool by 74173-submit@debbugs.gnu.org id=B74173.173069645514215 (code B ref 74173); Mon, 04 Nov 2024 05:01:02 +0000 Received: (at 74173) by debbugs.gnu.org; 4 Nov 2024 05:00:55 +0000 Received: from localhost ([127.0.0.1]:37253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7pCw-0003hD-Pz for submit@debbugs.gnu.org; Mon, 04 Nov 2024 00:00:55 -0500 Received: from mail-yb1-f174.google.com ([209.85.219.174]:44128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7pCu-0003h7-GP for 74173@debbugs.gnu.org; Mon, 04 Nov 2024 00:00:53 -0500 Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-e30cef4ac5dso3377254276.0 for <74173@debbugs.gnu.org>; Sun, 03 Nov 2024 21:00:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730696392; x=1731301192; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=Mw6wInM+NQlHGIwsnZQXzgWdXLwP0e2onp3COkp1zgE=; b=S2qCEQcsUm3dXs5EOkoaUW+/LRc3bO6NHJW0hBkLmC6kGGNQ2m0Duvx7mLDsVM1+AQ x8alA0p4ClFPlEUobK1NvAovd+gE3UtSAxY0IrIe5NVqLTRbqMH4ijp5kNgN6gj8U7xA ddEct9FfaMzux2e5m2sqnn+4wxDt8Q8BXv7Jqbs/E0cemgph8/us+XDwxJ274RLqFcz9 OeLplbYQN1vWcHGBnIy9o583PxMZUd15TQ0Th/rS33eKwdQKR4aVYi0N4VIYbOzhkT8g DZsxkueJ6bLpHVzNsnwYBthCAndOqKh/Tw2aablphOufV3MlUHcSFIBY38mGlEq+Iv4Z YOXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730696392; x=1731301192; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Mw6wInM+NQlHGIwsnZQXzgWdXLwP0e2onp3COkp1zgE=; b=vo8aWXHo2+HZwoBEn0jm+v/RjIE66TkPfIMvBqDRXhtSafLlzCZ/FSyASkt/OeA2MN 5IDpaid4rkRuFh59F2XAZCeuFz21BusA27t64proMDVtSx0E19POJ9Pg6ozQ/Fcxz5Bf jETWnwPcOQWAosC1ZO7iBipPkoI6j3f4G8AlW3UD/TR3Ij+ltGTXWxu7j76JR+XjZWFp t+9hkZBKtpbRTqF9Rs+VGyd07FNTDjKkmH39H+nY4rik9djuqUe4baQN8U35fR8xvx3K XYAVAIH88aMgxlnK+AdctGHfvmC0HKAPyNuFtt0hcrjPPhOEj5il/wc+D53XJxFhrMKa CAzA== X-Gm-Message-State: AOJu0YxDnrLeS3KKIrj1IejF4SrOJcpdHjisvypJDfrxUo+I7WnRJAyy 6VqB555FuSMmLEovC+ajgyajy8KbCntsxZ44BppHPqf+r/es3yCZ7yDSxf18ZJPf0P86hTmtZDh uRL1oaK2Kjemwfn2ZHjeZXQ9+q3hLTG8/ X-Google-Smtp-Source: AGHT+IH/mZjwuVxW+ON3gpQFfF8TOKdAlWx0Ye4TlIYW2RnjEmqpmbJRWeF4bKTNnBP+F9L7RpLnoAKYunGbNy4Mvow= X-Received: by 2002:a05:690c:89:b0:6e6:248:341e with SMTP id 00721157ae682-6ea3b72366amr198123797b3.0.1730696391904; Sun, 03 Nov 2024 20:59:51 -0800 (PST) MIME-Version: 1.0 From: Javier Olaechea Date: Mon, 4 Nov 2024 04:59:41 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000a754f806260f272d" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 3.47 X-Spam-Score: 3.47 X-Migadu-Queue-Id: 69B477CD5F X-TUID: 4o2jHuYUUkfC --000000000000a754f806260f272d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Shouldn't it hardcode the eslint binary and add eslint as an input? I can see the argument for both cases. In favor of listing as a dependency is that the minor mode can be enabled globally out of the box and it will run successfully. I also checked other flymake packages included by GUIX, https://packages.guix.gnu.org/search/?query=3Dflymake, like proselint and percritic and we _do_ include programs they depend on as a dependency. So including eslint as dependency seems aligned with our practices. If we end up deciding to do this, should we include rubocop as a dependency of emacs-flymake? The flymake package ships with a rubocop backend. The argument against is that ESlint is a program one runs in the context of developing software for a specific project. ESlint has multiple versions with different defaults. And one always wants to run the same version of ESLint that is specified by the package.json. As that is the version that will be used by CI. Personally I use npx to ensure that the version of ESLint being used is the project specific one w/o having to resort to project specific configuration. My personal preference would be to not include it, but I'm fine either way. Let me know what you think. A more practical consideration for not including ESLint as an input right now is that we don't have a package for it! I can look into packaging ESLint but I'd rather we block this patch until we package ESLint. It seems RDE has a package for it. Cheers --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --000000000000a754f806260f272d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Shouldn't it hardc= ode the eslint binary and add eslint as an input?

I can= see the argument for both cases. In favor of listing as a dependency is th= at the minor mode can be enabled globally out of the box and it will run su= ccessfully. I also checked other flymake packages included by GUIX, https://packages= .guix.gnu.org/search/?query=3Dflymake, like proselint and percritic and= we _do_ include programs they depend on as a dependency. So including esli= nt as dependency seems aligned with our practices.=C2=A0 If we end up decid= ing to do this, should we include rubocop as a dependency of emacs-flymake?= The flymake package ships with a rubocop backend.

The argument against is that ESlint is a program one runs in the cont= ext of developing software for a specific project. ESlint has multiple vers= ions with different defaults. And one always wants to run the same version = of ESLint that is specified by the package.json. As that is the version tha= t will be used by CI. Personally I use npx to ensure that the version of ES= Lint being used is the project specific one w/o having to resort to project= specific configuration.

My personal preference wo= uld be to not include it, but I'm fine either way. Let me know what you= think.

A more practical consideration for not= including ESLint as an input right now is that we don't have a package= for it! I can look into packaging ESLint but I'd rather we block this = patch until we package ESLint. It seems RDE has a package for it.

Cheers

--
"I object to doing things that computers can do.= " =E2=80=94 Olin Shivers
--000000000000a754f806260f272d--