unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Stefan Stefanović" <stefanx2ovic@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 35345-done@debbugs.gnu.org
Subject: [bug#35345] [PATCH 2/2] gnu: tlp: Add required x86-energy-perf-policy input dependency.
Date: Tue, 28 May 2019 18:21:28 +0000	[thread overview]
Message-ID: <CAFBTj=gOqV+5XYycd1dvC3SHO5anjjPuWW4KWOsW1EN7asTrAg@mail.gmail.com> (raw)
In-Reply-To: <87woict0tv.fsf@gnu.org>

Hi,

The patch you made works fine on my system.
Sorry for the late response.

Your work on correcting, improving and applying my original patch is
appreciated,
thank you.

Stefan.

On 5/27/19, Ludovic Courtès <ludo@gnu.org> wrote:
> Hi,
>
> Stefan Stefanović <stefanx2ovic@gmail.com> skribis:
>
>> From a7264289ba328478a1dab1978fe080a5b4f392c2 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Stefan=20Stefanovi=C4=87?= <stefanx2ovic@gmail.com>
>> Date: Sat, 20 Apr 2019 16:13:37 +0200
>> Subject: [PATCH 2/2] gnu: tlp: Add required x86-energy-perf-policy input
>>  dependency.
>>
>> * gnu/packages/linux.scm (tlp)
>> [inputs]: Add system specific x86-energy-perf-policy dependency.
>> [arguments]<#:phases>['wrap]:
>> Adjust bin-directory procedure to return #f on missing input,
>> a guard against system specific input dependencies.
>> Filter only strings in the path list. Reformat for-each block.
>> Add x86-energy-perf-policy in bin-directory input-name list.
>
> I reworded it to use ‘filter-map’ intead of (filter string? …).
>
>> +              ,@(if (member (or (%current-target-system)
>> (%current-system))
>> +                            (package-supported-systems
>> x86-energy-perf-policy))
>
> This would not work, because ‘%current-target-system’ returns a
> “triplet”, not a “system type”, so I’ve also rephrased it.
>
> Let me know if something’s broken!
>
> Thanks,
> Ludo’.
>

      reply	other threads:[~2019-05-28 18:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-20 16:26 [bug#35345] [PATCH 0/2] Add missing run-time dependency for TLP (Power management tool for Linux) Stefan Stefanović
2019-04-20 16:45 ` [bug#35345] [PATCH 1/2] gnu: Add x86-energy-perf-policy Stefan Stefanović
2019-05-27 14:35   ` Ludovic Courtès
2019-04-20 16:48 ` [bug#35345] [PATCH 2/2] gnu: tlp: Add required x86-energy-perf-policy input dependency Stefan Stefanović
2019-05-27 14:43   ` bug#35345: " Ludovic Courtès
2019-05-28 18:21     ` Stefan Stefanović [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFBTj=gOqV+5XYycd1dvC3SHO5anjjPuWW4KWOsW1EN7asTrAg@mail.gmail.com' \
    --to=stefanx2ovic@gmail.com \
    --cc=35345-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).