From: Aniket Patil <aniket112.patil@gmail.com>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 44006@debbugs.gnu.org
Subject: [bug#44006] [PATCH] doc: Fix typo
Date: Thu, 15 Oct 2020 18:45:11 +0530 [thread overview]
Message-ID: <CAF-xJguoZDLG8Tz0Cp1NaSkzNQ3Q+fUiNUENN3-d4u4m2f795w@mail.gmail.com> (raw)
In-Reply-To: <86mu0n1vqh.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]
Thanks for the feedback sir!
But I didn’t get
>> 2. Idem inside the commit message.
What does Idem means?
I will do new changes As well.
Aniket.
On Thu, 15 Oct 2020 at 6:39 PM, zimoun <zimon.toutoune@gmail.com> wrote:
> Dear,
>
> Thank you for your contribution. It is almost fine. Three things are
> not “correct“.
>
> 1. The commit subject must end with a dot. Like:
>
> doc: Fix typo.
>
> 2. Idem inside the commit message.
> 3. It is “star space path/to/file”, see below.
>
>
> And last, about the message itself:
>
> > *doc/guix.texi (section 7.5): Fix typo
>
> Usually, the section numbering does not appear. It does not make sense
> since it is a moving target. Instead, it seems better to provide the
> node name, e.g.,
>
> * doc/guix.texi (Invoking guix import): Fix typo.
>
>
> Does it make sense?
>
>
> Now, you should send an updated patch. To do so, you should
> ‘interactively rebase’. Using Emacs and Magit , it looks like:
>
> r i
> edit C-c C-c
> # do your tweaks
> r r
> W c C-m b origin/master C-m v 2 c
> ! git send-email --to= 44006@debbugs.gnu.org v2-0001-blabla.patch
>
> How does it sound for you?
>
>
> All the best,
> simon
>
>
[-- Attachment #2: Type: text/html, Size: 2292 bytes --]
next prev parent reply other threads:[~2020-10-15 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 7:47 [bug#44006] [PATCH] doc: Fix typo Aniket Patil
2020-10-15 13:09 ` zimoun
2020-10-15 13:15 ` Aniket Patil [this message]
2020-10-15 13:42 ` zimoun
2020-10-15 13:44 ` Aniket Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF-xJguoZDLG8Tz0Cp1NaSkzNQ3Q+fUiNUENN3-d4u4m2f795w@mail.gmail.com \
--to=aniket112.patil@gmail.com \
--cc=44006@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).