From: Aniket Patil <aniket112.patil@gmail.com>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 44033@debbugs.gnu.org
Subject: [bug#44033] [PATCH 1/3] gnu: Add r-decon.
Date: Mon, 19 Oct 2020 17:57:52 +0530 [thread overview]
Message-ID: <CAF-xJguThfaHPUMQHhywQ5Aa4qFrJNFDFYLMY7Ta1HiaTNqyng@mail.gmail.com> (raw)
In-Reply-To: <87wnzm76y4.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4715 bytes --]
Sure, I will do that.
On Mon, 19 Oct 2020 at 5:40 PM, zimoun <zimon.toutoune@gmail.com> wrote:
> Dear,
>
> Thank you for this contribution.
>
>
> The file gnu/packages/cran.scm has changed between so your patches do
> not apply anymore. Could you rebase on the top? Please.
>
> (Note that using “git format-patch --base=<hash>” where <hash> is the
> hash on which your patch is applying simplifies the process. IMHO.)
>
>
> On Fri, 16 Oct 2020 at 18:43, Aniket Patil <aniket112.patil@gmail.com>
> wrote:
> > * gnu/packages/cran.scm (r-decon): New variable.
> > ---
> > gnu/packages/cran.scm | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> > index 59a409f8e9..0370cdd993 100644
> > --- a/gnu/packages/cran.scm
> > +++ b/gnu/packages/cran.scm
> > @@ -24596,3 +24596,26 @@ enrichment analysis (GSEA) calculation with or
> without the absolute filtering.
> > Without filtering, users can perform (original) two-tailed or
> one-tailed
> > absolute GSEA.")
> > (license license:gpl2)))
> > +
> > +(define-public r-decon
> > + (package
> > + (name "r-decon")
> > + (version "1.2-4")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (cran-uri "decon" version))
> > + (sha256
> > + (base32
> > + "1v4l0xq29rm8mks354g40g9jxn0didzlxg3g7z08m0gvj29zdj7s"))))
>
> The indentation does not seem correct. It should be:
>
> (sha256
> (base32
> "1v4l0xq29rm8mks354g40g9jxn0didzlxg3g7z08m0gvj29zdj7s"))))
>
> > + (properties `((upstream-name . "decon")))
> > + (build-system r-build-system)
> > + (native-inputs `(("gfortran" ,gfortran)))
>
> Usually, we use:
>
> (native-inputs
> `(("gfortran" ,gfortran)))
>
> instead on the in-line.
>
> > + (home-page
> > + "https://cran.r-project.org/web/packages/decon")
> > + (synopsis
> > + "Deconvolution Estimation in Measurement Error Models")
>
> Usually, the synopsis is on the same line:
>
> (synopsis "Deconvolution Estimation in Measurement Error Models")
>
>
> > + (description
> > + "This package contains a collection of functions to deal with
> nonparametric measurement error problems using deconvolution kernel
> methods. We focus two measurement error models in the package: (1) an
> additive measurement error model, where the goal is to estimate the density
> or distribution function from contaminated data; (2) nonparametric
> regression model with errors-in-variables. The R functions allow the
> measurement errors to be either homoscedastic or heteroscedastic. To make
> the deconvolution estimators computationally more efficient in R, we adapt
> the \"Fast Fourier Transform\" (FFT) algorithm for density estimation with
> error-free data to the deconvolution kernel estimation. Several methods
> for the selection of the data-driven smoothing parameter are also provided
> in the package. See details in: Wang, X.F. and Wang, B. (2011).
> Deconvolution estimation in measurement error models: The R package decon.
> Journal of Statistical Software, 39(10), 1-24.")
> > + (license license:gpl3+)))
> > +
>
> The lines should not be longer than 80 characters. Something like.
>
> (description
> "This package contains a collection of functions to deal with
> nonparametric measurement error problems using deconvolution
> kernel methods. We focus two measurement error models in the
> package: (1) an additive measurement error model, where the goal
> is to estimate the density or distribution function from
> contaminated data; (2) nonparametric regression model with
> errors-in-variables. The R functions allow the measurement errors
> to be either homoscedastic or heteroscedastic. To make the
> deconvolution estimators computationally more efficient in R, we
> adapt the \"Fast Fourier Transform\" (FFT) algorithm for density
> estimation with error-free data to the deconvolution kernel
> estimation. Several methods for the selection of the data-driven
> smoothing parameter are also provided in the package. See details
> in: Wang, X.F. and Wang, B. (2011). Deconvolution estimation in
> measurement error models: The R package decon. Journal of
> Statistical Software, 39(10), 1-24.")
>
>
> To help you to spot, you can apply the linter with:
>
> ./pre-inst-env guix lint r-deconv
>
> and then address the warnings, if any.
>
>
> Could you send a v2?
>
> All the best,
> simon
>
[-- Attachment #2: Type: text/html, Size: 5815 bytes --]
next prev parent reply other threads:[~2020-10-19 12:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 13:13 [bug#44033] [PATCH 1/3] gnu: Add r-decon Aniket Patil
2020-10-16 13:13 ` [bug#44033] [PATCH 2/3] gnu: Add r-locpol Aniket Patil
2020-10-16 13:13 ` [bug#44033] [PATCH 3/3] gnu: Add r-lpme Aniket Patil
2020-10-19 12:09 ` [bug#44033] [PATCH 1/3] gnu: Add r-decon zimoun
2020-10-19 12:27 ` Aniket Patil [this message]
[not found] ` <CAF-xJgsF_M7R7nrPtP4iXL7yxqz6r09G-cNpJ0+VDsDYqTj6Zg@mail.gmail.com>
2020-10-22 7:59 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF-xJguThfaHPUMQHhywQ5Aa4qFrJNFDFYLMY7Ta1HiaTNqyng@mail.gmail.com \
--to=aniket112.patil@gmail.com \
--cc=44033@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).