From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OFj9DXtb41/LfQAA0tVLHw (envelope-from ) for ; Wed, 23 Dec 2020 15:00:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 0H3aCXtb41+pYgAA1q6Kng (envelope-from ) for ; Wed, 23 Dec 2020 15:00:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CDDDF940429 for ; Wed, 23 Dec 2020 15:00:10 +0000 (UTC) Received: from localhost ([::1]:40860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ks5cX-0000Ls-PW for larch@yhetil.org; Wed, 23 Dec 2020 10:00:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ks5cR-0000Le-7c for guix-patches@gnu.org; Wed, 23 Dec 2020 10:00:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ks5cQ-0007It-Vt for guix-patches@gnu.org; Wed, 23 Dec 2020 10:00:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ks5cQ-0002fb-Q9 for guix-patches@gnu.org; Wed, 23 Dec 2020 10:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#40601] [PATCH 2/5] guix-install.sh: Remove $UID bashism. Resent-From: Vincent Legoll Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 23 Dec 2020 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40601 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Received: via spool by 40601-submit@debbugs.gnu.org id=B40601.160873556110180 (code B ref 40601); Wed, 23 Dec 2020 15:00:02 +0000 Received: (at 40601) by debbugs.gnu.org; 23 Dec 2020 14:59:21 +0000 Received: from localhost ([127.0.0.1]:53801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks5bl-0002e8-KX for submit@debbugs.gnu.org; Wed, 23 Dec 2020 09:59:21 -0500 Received: from mail-lf1-f48.google.com ([209.85.167.48]:39361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks5bi-0002dq-AD for 40601@debbugs.gnu.org; Wed, 23 Dec 2020 09:59:21 -0500 Received: by mail-lf1-f48.google.com with SMTP id a12so40737410lfl.6 for <40601@debbugs.gnu.org>; Wed, 23 Dec 2020 06:59:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n+WwnB0V2R4AizcWwkRQ03C4MpRYvn4kCAOB4S5+bPs=; b=qeabBzJNNCi6HFNqbLF9+tQOGXXgzmwGSTYnFajgQEJkrW3wJBKLqWOu8IuNybrcNC cPzbTDYtmuL2U6q3WPV42xWKPQWx22N3h1Qz8MmsAYzr2w7hEJ+DfajVMWRR2cbDWy+a SyISwUV/6T+2THXa7eZo5sffKplBn2P7H7QmcxSphxsO8ni5FFgvTThQVAPBmsez2kko fyUv72nZvfLI3nJVAlEWsSp+zgNvUDkuMUaW/AqtuSa6i3PDRUyDvB5gjP98L5Nd7jUe 88xQN8LUNEQyKg++c/u+t8bRPo9MQe8OSpPl3EmJJAMphzWSq9xYGKkqCiYLYSHOp2UX 3CNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n+WwnB0V2R4AizcWwkRQ03C4MpRYvn4kCAOB4S5+bPs=; b=OBkDkkodp8TdUEPzcB/2eeSDVmLPU6ctcFn2G+qM8tBtZVxQyw4kHBUIMR1ODvW7ZO 91tikKCYdEUS6NX3VTAt3CsFEuhtWvORgyohAwIt7hLohaDWn+183vyFMOpe9Yxebxy2 Vbx9pXByVhGipcRDTFMz34S61gSmqhbZq3ihMasICDP+ww4oVMcGkZsvZzGhN4cvnq4E 5dDVr9Or1ADkf11+2mD+xIGM2u3ygmCgBcXqOJN86Fpo7EP8R5+XpgCrnHsL4HCH2++3 1g9Iv/f8CWZQr6Inm9EPMrU+DsB3khiEuxd8uVKpZUVAGOZnl6PsrElwGCAsZAV8Apoi ZjLQ== X-Gm-Message-State: AOAM533LZW+ZRZZW68N+tVYarfMW5jzVNwoK8lUEWGFBDYlKNQcTzwF+ H/WyFJ6UEMMRJ+ilVhNWNWT6lHR8hd4v7iJ8c94= X-Google-Smtp-Source: ABdhPJwmM7u6bppYSH7mLZbaWIx6VYgDEz52uA2eaqzz18+LmjmFBMsk45emPsjQvC74j7SV1mbqlyFBvEw7C/7Y5OU= X-Received: by 2002:a2e:89d7:: with SMTP id c23mr11717698ljk.282.1608735552065; Wed, 23 Dec 2020 06:59:12 -0800 (PST) MIME-Version: 1.0 References: <20201220172839.3059-1-vincent.legoll@gmail.com> <20201220172839.3059-2-vincent.legoll@gmail.com> <874kkcbtsl.fsf@cbaines.net> In-Reply-To: <874kkcbtsl.fsf@cbaines.net> From: Vincent Legoll Date: Wed, 23 Dec 2020 15:59:00 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 40601@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.23 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=qeabBzJN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CDDDF940429 X-Spam-Score: -0.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: GCICT5PErbJg Hello, On Wed, Dec 23, 2020 at 1:17 PM Christopher Baines wrote: > > -[ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; } > > +[ "$(id -u)" -eq 0 ] || { echo "This script must be run as root."; exit 1; } > > > > REQUIRE=( > > "dirname" > > Should id be added as a requirement? good catch ! thanks, I'll respin after this round of feedback -- Vincent Legoll