From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:45927) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDwce-000073-AQ for guix-patches@gnu.org; Mon, 16 Mar 2020 16:46:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDwcc-0000HQ-6K for guix-patches@gnu.org; Mon, 16 Mar 2020 16:46:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60187) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDwcc-0000G0-1w for guix-patches@gnu.org; Mon, 16 Mar 2020 16:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jDwcb-0003Vw-VJ for guix-patches@gnu.org; Mon, 16 Mar 2020 16:46:01 -0400 Subject: [bug#40091] [PATCH] gnu: dune: Update to 2.4.0. Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:45502) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDwcG-00005B-NE for guix-patches@gnu.org; Mon, 16 Mar 2020 16:45:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDwcF-00069y-Lu for guix-patches@gnu.org; Mon, 16 Mar 2020 16:45:40 -0400 Received: from mail-il1-x144.google.com ([2607:f8b0:4864:20::144]:36969) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDwcF-0005wz-Dc for guix-patches@gnu.org; Mon, 16 Mar 2020 16:45:39 -0400 Received: by mail-il1-x144.google.com with SMTP id a6so17950332ilc.4 for ; Mon, 16 Mar 2020 13:45:39 -0700 (PDT) MIME-Version: 1.0 References: <20200316204618.09d068df@tachikoma.lepiller.eu> In-Reply-To: <20200316204618.09d068df@tachikoma.lepiller.eu> From: Vincent Legoll Date: Mon, 16 Mar 2020 21:45:27 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 40091@debbugs.gnu.org Hello, On Mon, Mar 16, 2020 at 8:46 PM Julien Lepiller wrote: > Thanks for the patch! I tried using it, but even though dune builds > fine, this new version removed support for jbuild, which creates > build errors when building e.g. ocaml4.07-sexplib0. Ah, that explains the build problem I met in my attempt to package coccinelle... It surprised me since I read in the dune doc that jbuild should be supported by dune. Maybe that doc is outdated... > Note that according to "guix refresh -l dune" there are only 137 > dependents, so this change could go to master. Yep, I saw that, but I also tried "guix refresh -lr" and that gave a huge list. Maybe that's not relevant, I'm still low on the guix / guile learning curve... > However, we need to find a solution to the above issue. Yes > The guix refresh command should give you > the list of packages that depend on dune. > Make sure that those who > build now still build after your patch, or fix them. Yes > We could also > duplicate the dune package and uses the older dune for our > packages that still use jbuild. This may be the path of least resistance, and would let us handle problems without a flag day... > Alternatively, as suggested by dune, maybe we > can try to run "dune upgrade" in these packages. > > What do you think would work best? That is a question I cannot answer, I did not know about dune before today ;-) But I'll try to "dune upgrade" a few of them and we'll see where this'll lead... I was not expecting to fall in such a rabbit hole... But this is fun, I'll keep at it. -- Vincent Legoll