From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:39522)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jDWl5-0003lY-2l
 for guix-patches@gnu.org; Sun, 15 Mar 2020 13:09:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jDWl4-0004lH-4C
 for guix-patches@gnu.org; Sun, 15 Mar 2020 13:09:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:57669)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jDWl4-0004kj-0R
 for guix-patches@gnu.org; Sun, 15 Mar 2020 13:09:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jDWl3-0001wb-SA
 for guix-patches@gnu.org; Sun, 15 Mar 2020 13:09:01 -0400
Subject: [bug#40032] [PATCH] gnu: Add nvme-cli
Resent-Message-ID: <handler.40032.B40032.15842920827402@debbugs.gnu.org>
MIME-Version: 1.0
References: <CAEwRq=r4yWqyJ6GEK+Bj4UibDvXkqBpphVchw7UmeTe04r7+5g@mail.gmail.com>
 <20200312181513.GA8595@jasmine.lan>
 <CAEwRq=qtHYZ7wXT-TWfZLh837mGMb+cCgjbKOrPagdsq5-r8MQ@mail.gmail.com>
In-Reply-To: <CAEwRq=qtHYZ7wXT-TWfZLh837mGMb+cCgjbKOrPagdsq5-r8MQ@mail.gmail.com>
From: Vincent Legoll <vincent.legoll@gmail.com>
Date: Sun, 15 Mar 2020 18:07:44 +0100
Message-ID: <CAEwRq=pMDGyhQvOBMex6PXYx+2W71kZGHGx3p_v=26APXbtw8w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 40032@debbugs.gnu.org

It looks like the tests require the presence of /sys/devices...

Should I just add that explanation as comment ?

On Sat, Mar 14, 2020 at 12:14 AM Vincent Legoll
<vincent.legoll@gmail.com> wrote:
>
> I'll investigate further and amend the patch
>
> On Thu, Mar 12, 2020 at 7:15 PM Leo Famulari <leo@famulari.name> wrote:
> >
> > On Thu, Mar 12, 2020 at 02:13:06AM +0100, Vincent Legoll wrote:
> > > +       #:tests? #f))
> >
> > Why are the tests skipped? Please, always add a code comment here for
> > reviewers.
>
>
>
> --
> Vincent Legoll



-- 
Vincent Legoll