From: Vincent Legoll <vincent.legoll@gmail.com>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 45825@debbugs.gnu.org, 45825-done@debbugs.gnu.org
Subject: [bug#45825] [PATCH] gnu: Add efi_analyzer.
Date: Tue, 12 Jan 2021 23:17:58 +0100 [thread overview]
Message-ID: <CAEwRq=oy8ZfLFvdp-FtDUR86nkPw9ikYLMpXLJUdqAkitEvODw@mail.gmail.com> (raw)
In-Reply-To: <87im81olu7.fsf@nckx>
Hello,
On Tue, Jan 12, 2021 at 11:02 PM Tobias Geerinckx-Rice <me@tobias.gr> wrote:
> > gnu/packages/engineering.scm | 27 +++++++++++++++++++++++++++
>
> I failed to see any connection to engineering and moved this to
> efi.scm.
I searched a bit (debug.scm, etc.) but failed to find
the *really* obvious one :facepalm: I chose engineering
because another rev-eng tool (radare2) was here.
> Don't forget to add or update your copyright line.
I almost always forgot to do that.
> > + (source (origin
> > + (method git-fetch)
> > + (uri (git-reference
> > + (url
> > "https://github.com/xypron/efi_analyzer")
> > + (commit commit)))
> > + (sha256
> > + (base32
> > "1izdkzybqyvzpzqz6kx4j7y47j6aa2dsdrychzgs65466x1a4br1"))
>
> I added a newline after ‘source’ to give this 81-character line
> some breathing room.
This one I swear I ran the etc/indent.el script on, was it in
my brain only ?
> > + (file-name (string-append name "-" version
> > "-checkout"))))
>
> This can be done with the
>
> (file-name (git-file-name name version))
>
> helper.
Argh, another forgetting, you probably taught me that
a few times already.
> > + (arguments
> > + `(#:phases
> > + (modify-phases %standard-phases
> > + (delete 'configure))
>
> Not a comment on your patch, but I added a
> ‘support-cross-compilation’ phase here that replaces the
> Makefile's hard-coded ‘gcc’ so you can inspect EFI binaries on
> your cross-compiled ARM box.
I saw that, nice !
> > + #:make-flags (list "prefix=" (string-append "DESTDIR="
> > (assoc-ref %outputs "out")))))
>
> The other way 'round: set $prefix (or the BSD variant $PREFIX) to
> the destination, and never set DESTDIR unless you're working
> around a bug in a broken build system.
>
> DESTDIR is for distributions/builds using a temporary ‘staging’
> destination directory. Guix doesn't.
OK, I hesitated between the 2 options, and failed to choose the
right one :-))
> > + (description
> > + "The EFI Analyzer can be used to check EFI binaries and to
> > print out header
> > +and section information.")
>
> Slash empty ‘x can y’ (or ‘x allows the user to y’) filler with
> gleeful prejudice.
Just a copy-paste from upstream (should have proof read it, though)
Thanks a lot for your patience in bearing with my half-baked
submissions.
I think I'll owe you a beer (or two).
Tchuss
--
Vincent Legoll
prev parent reply other threads:[~2021-01-12 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 19:37 [bug#45825] [PATCH] gnu: Add efi_analyzer Vincent Legoll
2021-01-12 22:02 ` bug#45825: " Tobias Geerinckx-Rice via Guix-patches via
2021-01-12 22:17 ` Vincent Legoll [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEwRq=oy8ZfLFvdp-FtDUR86nkPw9ikYLMpXLJUdqAkitEvODw@mail.gmail.com' \
--to=vincent.legoll@gmail.com \
--cc=45825-done@debbugs.gnu.org \
--cc=45825@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).