From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +C6eK1+K318qcAAA0tVLHw (envelope-from ) for ; Sun, 20 Dec 2020 17:31:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4GtuJ1+K318bSQAAB5/wlQ (envelope-from ) for ; Sun, 20 Dec 2020 17:31:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 75DF69403A7 for ; Sun, 20 Dec 2020 17:31:11 +0000 (UTC) Received: from localhost ([::1]:51212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kr2Y2-0005N4-Cy for larch@yhetil.org; Sun, 20 Dec 2020 12:31:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr2Xu-0005LC-Ms for guix-patches@gnu.org; Sun, 20 Dec 2020 12:31:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kr2Xu-0000Rc-Fv for guix-patches@gnu.org; Sun, 20 Dec 2020 12:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kr2Xu-0002r2-Cf for guix-patches@gnu.org; Sun, 20 Dec 2020 12:31:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#40601] New reduced patchset, the easy bits first Resent-From: Vincent Legoll Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Dec 2020 17:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40601 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Received: via spool by 40601-submit@debbugs.gnu.org id=B40601.16084854268938 (code B ref 40601); Sun, 20 Dec 2020 17:31:02 +0000 Received: (at 40601) by debbugs.gnu.org; 20 Dec 2020 17:30:26 +0000 Received: from localhost ([127.0.0.1]:45511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr2XJ-0002Jo-Om for submit@debbugs.gnu.org; Sun, 20 Dec 2020 12:30:25 -0500 Received: from mail-lf1-f52.google.com ([209.85.167.52]:35544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr2XH-0002CC-GK for 40601@debbugs.gnu.org; Sun, 20 Dec 2020 12:30:24 -0500 Received: by mail-lf1-f52.google.com with SMTP id h22so8669095lfu.2 for <40601@debbugs.gnu.org>; Sun, 20 Dec 2020 09:30:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BXOvI7u3jopCVZKyGUe7GXNW5514DPvv4w4+aW+QKDg=; b=X2StZsAo2v39CPjCzHeluJIs5siJAGt+iK4TyOolvOpEsxqwGIamlwafyo7OBa7Id9 PFY91J9wwRN5myXaDQSuQgyDXMTA8gFZruQOaR6i8d1kp2qVzDs2rkGcgpFpKzggGj7S nolMnPQ7f6L+H4k39Yv3VcCjCYwq5gOMbICJ0CBQ61hwVwGu+dKO4nxNbtjjCsLHf9cF t9yvD5o78yCnHRRKvwlqQYZdHXBRyCnZwUndswsZjHh6pCZxsX74HVW3nVilYooEO7rk wl6aLaY/PlJW/5sOMB6BYWkcUmDw22xrWBtSQ4XITXQ+qkWh8t8GeE+J+9KVCJ2khu1b mIdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BXOvI7u3jopCVZKyGUe7GXNW5514DPvv4w4+aW+QKDg=; b=DK4W96K7ywaINTThgl/uqD75+MC6jEVYVVRRVqk0tbB6eZr9rIRu3knDVMdQidpybf d7pGMQxI9vRxePFARDyMHczBRal2cB/ioIiR8ccWkV1Q7wbWTLq17oUTAK/11fS8FSCT Hzg+a/fpD0v1Z/uJSo0jcrt5C6jzYiBJRIsUNxPOIze1bYgPLtlFbA20Ktyqi8xGVKJ7 mE7Z1sfafk7tmdNJtIn0HD+JDO5iRFAees7P08QtWBDKBbN1gkjbcgNYCk+VeDWqC1Ll Hrqje4fefy/lKYtSjTdF8nXUhQZ8tNOaoumRivvhcI7ItPimhXI8wdS8FIJI6BSIR7MY 7cwA== X-Gm-Message-State: AOAM530U1W7PeUrLKcms4pAIhJ3rpvZWIth9hsoSm1c8JiF/E7EYOs/Q ZSWnXeLz94nv88qhI5j7Yjf3svPkTp51KottEgEJEtBo X-Google-Smtp-Source: ABdhPJzaHrpu1KzavG6J5p0cMzfiIEUoIIp3f0QkwHzOCseIYnF30Cq177A+svO24gZ7oGuubD7S7CiFttFrjQ7LvFU= X-Received: by 2002:a05:6512:94f:: with SMTP id u15mr4773722lft.389.1608485417459; Sun, 20 Dec 2020 09:30:17 -0800 (PST) MIME-Version: 1.0 References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@gmail.com> <00b505a4-0c1a-2f6c-7242-57d7b5eb7d4f@gmail.com> <87v9cz1eo5.fsf@cbaines.net> In-Reply-To: From: Vincent Legoll Date: Sun, 20 Dec 2020 18:30:05 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 40601@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.22 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=X2StZsAo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 75DF69403A7 X-Spam-Score: -1.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: SJ/Zxhbxo4qy I rebased and sent the next batch On Fri, Dec 18, 2020 at 8:35 PM Vincent Legoll wrote: > > Hello, > > > Thanks for sending a smaller set of patches, that makes reviewing > > easier. I made some tweaks, and pushed 4 commits to master as > > d2532317d136ac063a24baeec6688ea0e0ebe37b. > > Thanks for taking care of this, I'll have a look. > > > I'm not sure about the bashisms stuff, given the script seems to depend > > on bash (see the exec bash bit at the start), I think using bash > > functionality is reasonable. What was your motivation behind these > > changes? (sorry if I've missed this earlier in the thread). > > Some distributions that I intended to add support for don't default to bash > (nor have it installed by default). I think this script should aim for > the broadest > possible support, but that is only my opinion. > > And the patch set was not finished, I wanted to tackle the low hanging fruits > first (also to test the interest from the guix team before doing too much). > > > Maybe once we've talked about the bashisms stuff, would you be able to > > send another set of patches for review? > > I'll try to revive the patch set, and submit other portions I should have lying > somewhere. > > Tchuss > > -- > Vincent Legoll -- Vincent Legoll