From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 6FW7JEkWJWdaDQEAe85BDQ:P1 (envelope-from ) for ; Fri, 01 Nov 2024 17:56:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 6FW7JEkWJWdaDQEAe85BDQ (envelope-from ) for ; Fri, 01 Nov 2024 18:56:25 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="c/qRSK1f"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Q6olhphd; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730483785; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WVNgpsxT2PXZm4zYQAcOwbCG+TW1u0Aj6XSpD4pu5f4=; b=KHsA9u+ABpK05O5u3n9FIaC5V/5iu78TbKSznMZSMIVSHOwi4dFU43AVEDAZIEisvzmhTC xxlj2KlM3lfFM5C/4BTl24IAeDeNhT05EZp8BCclCL4HfPfYo4l2dZEnpAjx6HTwID+xe1 0rkrOH5kZAJw01LsUw2s2I5DqIlOTaGb9n1XSGA0vOUPIxLARtDhKkNv7b1m1F3gyw6LTg WtmMDvzogctGDA2Wd+AhuMI8xWZBx4NPDMSPK5rZQ+d1fAevP9M2j2VcxZF6u0DMM9f/hV IB81Rp2BeoA/tpClHLtuN+hnjt419a8bLr4bjuhR0Qa5AlqrlWpDt1BSb36jdg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730483785; a=rsa-sha256; cv=none; b=nnPRwj8oPokYn3d8GO+Drbbop1BSKCH2EEn+3Fxjv2e1rAz77gfbOBj5Hyh1BoT16glJAz 0rx51E0Y6BGhAXsLcisEMVAsaL4sMcBuA4f40uNGJgx26xVm/72+Kgfts1eezBChwHogML qp6XgTPYD03E7DOzK1afw0tQ/4fE6Rn/DK9Bv+iuNilSjAyA8aDg9kpTh1CYGbwRtZbBwn Ke7sPvQ674H95r5I7n8cmYkJaw0pjU3hgk8tE8UXR4yzzb3FDYAYTwU1+ajg1uLFe+hlsL FDeAE7yr36pGdysF695AGzZCK2Q7hdqCY55g74KUJiFj0LUERIoQ9f5nSML5lw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="c/qRSK1f"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Q6olhphd; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 762365F1D2 for ; Fri, 01 Nov 2024 18:56:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6vsT-00084d-BQ; Fri, 01 Nov 2024 13:56:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6vsR-00084N-Pu for guix-patches@gnu.org; Fri, 01 Nov 2024 13:56:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6vsR-0002bG-CF for guix-patches@gnu.org; Fri, 01 Nov 2024 13:56:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=WVNgpsxT2PXZm4zYQAcOwbCG+TW1u0Aj6XSpD4pu5f4=; b=c/qRSK1fdvyjrJGAfvWqvt4r2AMAtyf5nEIESRZtKMKavipRtw28Wg2mUOZNsEA4Ez3vLPLY9lkx1Rw4xcBxySz0IUoIni+HnLClMK9XwelWHRqEXW45tfTFDYBGGzUjNz/dlo9OVcnyvO4HFAhC0CWcn0hYr2eLyoyjpiywhbgfu/6Go/hnJypgpansqyD3a+gMw1Wsu1U7LH/0slbuKWRK2LWhBQ/Konq4Wjw2mwT/X3BuAK28dQdxSFOX4hofpbZFPiA7GDecm6GykmBL9636VFhm8T73E/vNO+5AXoh3rK2/zVwg3LJ66NHhvIDlcyTu5HyTs95Wl7oJQZ2bMA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6vsQ-0000tr-3r for guix-patches@gnu.org; Fri, 01 Nov 2024 13:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#74135] [PATCH 1/2] gnu: Improve emacs-popwin definition. Resent-From: Rostislav Svoboda Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Nov 2024 17:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74135 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: Liliana Marie Prikler , Katherine Cox-Buday , 74135@debbugs.gnu.org, Andrew Tropin Received: via spool by 74135-submit@debbugs.gnu.org id=B74135.17304837593452 (code B ref 74135); Fri, 01 Nov 2024 17:56:02 +0000 Received: (at 74135) by debbugs.gnu.org; 1 Nov 2024 17:55:59 +0000 Received: from localhost ([127.0.0.1]:50983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6vsN-0000tc-Bo for submit@debbugs.gnu.org; Fri, 01 Nov 2024 13:55:59 -0400 Received: from mail-vs1-f50.google.com ([209.85.217.50]:47552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6vsL-0000tU-QA for 74135@debbugs.gnu.org; Fri, 01 Nov 2024 13:55:58 -0400 Received: by mail-vs1-f50.google.com with SMTP id ada2fe7eead31-4a470d330a5so671607137.3 for <74135@debbugs.gnu.org>; Fri, 01 Nov 2024 10:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730483692; x=1731088492; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WVNgpsxT2PXZm4zYQAcOwbCG+TW1u0Aj6XSpD4pu5f4=; b=Q6olhphd0SeGm2VTrMdwFezlBPC1JC13QNLoYP8u//pt0E9VvUkd0E44w7DJHaqmZH 1vqf2Ag1IYhnICciIFoToTPK/r+cVBf7k0qErrfbprfMe6voULiWZviyU76rLm98VPW/ Ahgjx2Z/WEFObgqqO6p/ArowQfkMxGRCRVQvbBzmYLXshpedxKtjTLGYkUfdWFwWImZ0 sQUsoleN+FcOUefp8vB6CyRUkkqnTH2pjflSqtwym5glg3RWgHEpFTglbP+MUewUNjSS 83fuo4bTlgxFzOdYvxbYJ4SkU6wv6K+bSojpTvRzbnHNggnWU63naVei4ZbKbqCn8mup TIHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730483692; x=1731088492; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WVNgpsxT2PXZm4zYQAcOwbCG+TW1u0Aj6XSpD4pu5f4=; b=uq5BQcSiVjQlIECI8cKV8wyNcGA2cE0TNcQc2mliWCL/cTuVv3B56ywVbQsSF3SmrM 2yHwRBe2RirJSAJE3QdRA/+MqyAThCtsbt6pBhckHEkh3va8KU5weUGZXYs3bu8Jd/Rp H+CfZSa5GlSj/hxRDXXB3JjYrzDueaiq6QIw5zoCLWBv/+lfInvRPN6oJaPm+s4j5ux8 X1qmxY6dUgybeSJUyG4iYaovMl8UpbuR+PKEsted6VN31jduOJmU1WGPrc5yHTrL3h4e YQkkV1Wx2jTV7UkTevRS4ZVz3LSiL8j2zrXVOHINzYzCmtlXWrKVhwUfpXyYyfeFvn1L 72yA== X-Gm-Message-State: AOJu0YxW4eu1iiOFLI7GZ8jCZ3kf7d2vNqB0T8svr7mAoafQv9nhkZ6v 4ggFOzmoSA0xPou7cF+kI0IZxUcEgSIVGEvM8LMM1UP5j43KMPfGtFk/1zMhO5Vp6VayUmWJonn Cwzj8K6sE/Qha+TQrZj9jnYMnrBw= X-Google-Smtp-Source: AGHT+IG8ocSJWSePH805poibMRq7rHK0kgFuCfSMlSfh3t907kzHuOLVrAdcHVYskrvBOcD+8CYRbmqKu0S+SIuQuUM= X-Received: by 2002:a05:6102:c04:b0:498:e935:ddb8 with SMTP id ada2fe7eead31-4a954262b0cmr9555655137.1.1730483692124; Fri, 01 Nov 2024 10:54:52 -0700 (PDT) MIME-Version: 1.0 References: <2205123045e70a7cfb11d78405f48586e77df80e.1730382156.git.Rostislav.Svoboda@gmail.com> <87o72zkozl.fsf@nicolasgoaziou.fr> In-Reply-To: <87o72zkozl.fsf@nicolasgoaziou.fr> From: Rostislav Svoboda Date: Fri, 1 Nov 2024 18:54:15 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 1.69 X-Spam-Score: 1.69 X-Migadu-Queue-Id: 762365F1D2 X-Migadu-Scanner: mx13.migadu.com X-TUID: kpGdmHFdz0mn Hello Nicolas, > I disagree with the removal of "#:tests? #f". It is more meaningful than > simply omitting the keyword. It tells us that the package has tests, but > they are difficult or even impossible to run. Without the keyword, it > could as well mean: "I didn't bother to check if there are tests". Which is, in fact, the default behavior of the #:tests parameter. By default, we do not run any tests, so why bother verifying their existence when they=E2=80=99re unnecessary by default? > I have no opinion about the removal of native inputs. Including emacs-ert-runner - a package designed for "Emacs projects tested using ERT" - among native inputs is pointless if no tests are executed. > I also think the change to version should go in the second patch. In the first patch, I intended to fix the Guix package definition without updating the package itself. That's why I incremented the revision number from its default (presumably 0) to 1. The v1.0.2 tag corresponds to commit 215d6cb509b11c63394a20666565cd9e9b2c2eab. In the second patch, I then proceeded with updating the Emacs package. Cheers, Bost