unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Rostislav Svoboda <rostislav.svoboda@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Liliana Marie Prikler <liliana.prikler@gmail.com>,
	Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	74135@debbugs.gnu.org, Andrew Tropin <andrew@trop.in>
Subject: [bug#74135] [PATCH 1/2] gnu: Improve emacs-popwin definition.
Date: Fri, 1 Nov 2024 18:54:15 +0100	[thread overview]
Message-ID: <CAEtmmezbyKpHW4yTUu312Au5SXPhBE9yANErws8z-BxE06ni5g@mail.gmail.com> (raw)
In-Reply-To: <87o72zkozl.fsf@nicolasgoaziou.fr>

Hello Nicolas,

> I disagree with the removal of "#:tests? #f". It is more meaningful than
> simply omitting the keyword. It tells us that the package has tests, but
> they are difficult or even impossible to run. Without the keyword, it
> could as well mean: "I didn't bother to check if there are tests".

Which is, in fact, the default behavior of the #:tests parameter. By
default, we do not run any tests, so why bother verifying their
existence when they’re unnecessary by default?

> I have no opinion about the removal of native inputs.

Including emacs-ert-runner - a package designed for "Emacs projects
tested using ERT" - among native inputs is pointless if no tests are
executed.

> I also think the change to version should go in the second patch.

In the first patch, I intended to fix the Guix package definition
without updating the package itself. That's why I incremented the
revision number from its default (presumably 0) to 1. The v1.0.2 tag
corresponds to commit 215d6cb509b11c63394a20666565cd9e9b2c2eab.

In the second patch, I then proceeded with updating the Emacs package.

Cheers,
Bost




  reply	other threads:[~2024-11-01 17:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 13:42 [bug#74135] [PATCH 1/2] gnu: Improve emacs-popwin definition Rostislav Svoboda
2024-10-31 13:42 ` [bug#74136] [PATCH 2/2] gnu: Update emacs-popwin to 1.0.2.-2.58adcd0 Rostislav Svoboda
2024-11-01 14:28 ` [bug#74135] [PATCH 1/2] gnu: Improve emacs-popwin definition Nicolas Goaziou via Guix-patches via
2024-11-01 17:54   ` Rostislav Svoboda [this message]
2024-11-01 17:58     ` Rostislav Svoboda
2024-11-01 18:19     ` Nicolas Goaziou via Guix-patches via
2024-11-01 19:40       ` Rostislav Svoboda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEtmmezbyKpHW4yTUu312Au5SXPhBE9yANErws8z-BxE06ni5g@mail.gmail.com \
    --to=rostislav.svoboda@gmail.com \
    --cc=74135@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=liliana.prikler@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).