From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UEqGLxSUeWKNHQEAbAwnHQ (envelope-from ) for ; Tue, 10 May 2022 00:22:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AEdmLxSUeWIKLwAAauVa8A (envelope-from ) for ; Tue, 10 May 2022 00:22:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 607EC354F0 for ; Tue, 10 May 2022 00:22:12 +0200 (CEST) Received: from localhost ([::1]:36342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1noBlb-0002x3-8N for larch@yhetil.org; Mon, 09 May 2022 18:22:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noBlT-0002wc-2A for guix-patches@gnu.org; Mon, 09 May 2022 18:22:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1noBlS-0008BL-NY for guix-patches@gnu.org; Mon, 09 May 2022 18:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1noBlS-0001wE-Hr for guix-patches@gnu.org; Mon, 09 May 2022 18:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54852] [PATCH] gnu: Add openjdk18. Resent-From: Rostislav Svoboda Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 May 2022 22:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54852 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54852@debbugs.gnu.org Received: via spool by 54852-submit@debbugs.gnu.org id=B54852.16521348697381 (code B ref 54852); Mon, 09 May 2022 22:22:02 +0000 Received: (at 54852) by debbugs.gnu.org; 9 May 2022 22:21:09 +0000 Received: from localhost ([127.0.0.1]:59645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noBkb-0001uy-Ev for submit@debbugs.gnu.org; Mon, 09 May 2022 18:21:09 -0400 Received: from mail-ed1-f51.google.com ([209.85.208.51]:43521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noBkZ-0001u6-8k for 54852@debbugs.gnu.org; Mon, 09 May 2022 18:21:07 -0400 Received: by mail-ed1-f51.google.com with SMTP id c12so10424161edv.10 for <54852@debbugs.gnu.org>; Mon, 09 May 2022 15:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Y8qKF0uOc8Q8JfNTneMk5B/6l3/ZOlKnjTs6pQX1oXo=; b=IH/dRyWBYgA/4PPxe3iIfqMw1LjXxv7MLwIECFvdp/omyqLFbDKI0O63+kajZzPOiO aFOkCvUwXbXlrM7F/nHaKviMkpBJoVDYFXtw/SlGOg1qUkq3GWvcxTti2B+sXGDRgu5P Kv3vBvBA5AOOn5EO/MQj5PlC0knBo6B9/W++t2MIE1Bt2FYvT/6fkgdjLF6vjUwzzolH h94pb4H8Q2eMjWllDcAcK4ukjysv/5sxcLv4uhdLvxEZFhf1yZ2RDKuZyoOrBZXo1QLf 0pfswGvhY59kBNlNwfsUS5KnPZCghCva94Uhj3CFAmcGUyAIACv7+gkVjAXR570uRWSD IU7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Y8qKF0uOc8Q8JfNTneMk5B/6l3/ZOlKnjTs6pQX1oXo=; b=2hC6m9CUUZUzIKaJhGIsTNum41vKm2ejZIsorFoNBLXpsLhe5XP+WMeX9NuRcokrIw XH5p582Yt/oUsvC1u8Nq9wsWB/R78ksNwMUhh9Y1Rea/oO0x0YnynOMrWuXEW9Kq2POb MUVzTsCuzllfAZRL6N1Pa59su/yw4gGClMU3zu7xxzFRgeZc3KN2DdrWZwzS8wKE9Q5y efpoRrGR/K3+P4EP6D2UlTZO6DhrNkI5bNQu9uaSVD2pR/6J4AvML9v6+ffAO10vVZ6D UkxvpwcyylQZgm4A2QQfTdkc8gTCD6hh8+GYbIfQq65Dtxxl8NzuOf90FmpDiHadTvGr 0qSw== X-Gm-Message-State: AOAM5330COsKeqR+1caMejmSkSIdtyku70ZOOz+vDQs7Hornub6lWBgL D1CumABx7H2U5PAfZPxzG0GNCN/jE2qr/esIay0= X-Google-Smtp-Source: ABdhPJzUsH4jnqB9N/zIRvmIuJnjjaT3uhy4Uk/hGCaqZU4J5G/rRKuw6EDF96DjpEdJc6YbbHTJBwW3Y6IMhJxawgc= X-Received: by 2002:a05:6402:1e88:b0:428:4782:a16e with SMTP id f8-20020a0564021e8800b004284782a16emr20072512edf.191.1652134860830; Mon, 09 May 2022 15:21:00 -0700 (PDT) MIME-Version: 1.0 References: <20220411125335.4047-1-Rostislav.Svoboda@gmail.com> In-Reply-To: From: Rostislav Svoboda Date: Tue, 10 May 2022 00:20:24 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652134932; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Y8qKF0uOc8Q8JfNTneMk5B/6l3/ZOlKnjTs6pQX1oXo=; b=prFs1UeyHn+5wnA0qmMOu18jk1x3dx1/fWmzjL+B1COUj0AYkEc7W8jL2rhfOrbrkQ69uw 1JDxQnKAIbKr7iWWHMn2aZ1jBKhNZuxWKm9wKgpfcWPh7TgXkseX0JEut0R3XmLHzWZzrW Syr/VGYjxfuCec4zQuW1oK1cAkUUPDENj4Ha6Qm6g/Cqg2QqKFqxeEQ406J34NPfFIl2O7 S7NvR1dQfOWrIxlE7/yGID0tY8FXfJmwq3zpBY0vuomTs25J/H1vrL/TwnZdS8UF2miXDY YGli9dJu59StY9gZaUdQOEe97MhYN1F0zqPWUMUdwciQcPor9lRBsSjOshECTw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652134932; a=rsa-sha256; cv=none; b=rs6tlJXlw8wx/oYL8MAi/QZ2saQ70ysiMVJcWf8P5J+4s1ZYnTLR6oTIae8T/9XCNytKKH KPmJBllmDFgqulRacWM6a0QB5ZNNvtL5delBO+FzT38tY3t9W+pBwFpT26as1pzAPNd+3c ILoG7aF87Y12iBxGSH6B6ZwfGDXoCtO/wXK39FgnKmcdFj0v0BNYr7aXBMEWS6CDifDLCU l7JxalxQYoGdN8TERO6zdHeIB++oFlawyRn/sfG7539WTMe7TkG9JADPy2DOCifqXToxne pKsXzuHnrEam9Ybk8p6xGAY65+RqN0xXD5ghBKtf97y3o+Ky2UwDZBKVaffvwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="IH/dRyWB"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="IH/dRyWB"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 607EC354F0 X-Spam-Score: 6.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: wkrKAC2JhUXZ Hi Maxime, > The following simplified package definition =E2=80=98worked=E2=80=99 for = me: > > (define-public openjdk18 > (package > (inherit openjdk17) > (name "openjdk") > (version "18") > (source (origin > (method git-fetch) > (uri (git-reference > (url "https://github.com/openjdk/jdk18u") > (commit (string-append "jdk-" version "-ga")))) > (file-name (git-file-name name version)) > (sha256 > (base32 > "1bv6bdhkmwvn10l0xy8yi9xibds640hs5zsvx0jp7wrxa3qw4qy8")))= ) > (native-inputs > (modify-inputs (package-native-inputs openjdk17) > (replace "openjdk16:jdk" openjdk17))) > [home-page ...])) I'm a bit puzzled. Here is how I run the build: The `/home/bost/dev/guix` contains a clone of https://git.savannah.gnu.org/git/guix.git ```shell $ pwd /home/bost/dev/guix/gnu/packages $ time guix build --check --load-path=3D. openjdk ... Executed in 73.08 secs fish external usr time 151.31 secs 0.00 micros 151.31 secs sys time 0.48 secs 759.00 micros 0.48 secs ``` So my build time is about 2,5 minutes. During the build I get plenty of warnings like: guix build: warning: failed to load '(SOME-THING)': no code for module (SOME-THING) ./SOME-THING.scm:20:0: warning: module name (gnu packages SOME-THING) does not match file name 'SOME-THING.scm' hint: File `./SOME-THING.scm' should probably start with: (define-module (SOME-THING)) and it looks like the warnings can be ignored. Regarding the compilation itself, first of all I had to exclude the 271b2e43bef96f17f3f1e1085394b4bb144c5768 due to the https://issues.guix.gnu.org/55255 from my repo. Then I had to fix the `[home-page ...]` and put there `(home-page "https://openjdk.java.net/projects/jdk/18")` and even after that it doesn't compile. I get: The following graft will be made: /gnu/store/42kdy7fs7pykx79m69v2gpxw7gmph745-openjdk-18.drv guix build: error: some outputs of `/gnu/store/42kdy7fs7pykx79m69v2gpxw7gmph745-openjdk-18.drv' are not valid, so checking is not possible And here are the definitions which work for me: ;; I'd prefer: (define-public openjdk18 (package (inherit openjdk17) (name "openjdk") (version "18") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/openjdk/jdk18u") (commit (string-append "jdk-" version "-ga")))) (file-name (git-file-name name version)) (sha256 (base32 "1bv6bdhkmwvn10l0xy8yi9xibds640hs5zsvx0jp7wrxa3qw4qy8")))) (native-inputs (map (lambda (input) (match (car input) ("openjdk16:jdk" `("openjdk17:jdk" ,openjdk17 "jdk")) (_ input))) (package-native-inputs openjdk17))) (home-page "https://openjdk.java.net/projects/jdk/18"))) ;; This works too: (define-public openjdk18 (package (inherit openjdk17) (name "openjdk") (version "18") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/openjdk/jdk18u") (commit (string-append "jdk-" version "-ga")))) (file-name (git-file-name name version)) (sha256 (base32 "1bv6bdhkmwvn10l0xy8yi9xibds640hs5zsvx0jp7wrxa3qw4qy8")))) (modify-inputs (package-native-inputs openjdk17) (delete "openjdk16:jdk") (append `(("openjdk17:jdk" ,openjdk17 "jdk")))) (home-page "https://openjdk.java.net/projects/jdk/18"))) > About the labels issue: maybe "icedtea-8" could be changed to "icedtea", > "openjdkN" to "openjdk" and "openjdkN:jdk" to "openjdk:jdk" at some point > in the future, such that the package name matches the input label and > the input alist can be changed to a package list. Sure. Good idea. Greetings, Bost